Explorar o código

Merge pull request #134 from sharelatex/as-allow-autocompile-linting-error

Don't check for linting errors when autocompiling if code check is disabled
Alasdair Smith %!s(int64=9) %!d(string=hai) anos
pai
achega
91a8f7d5bd

+ 5 - 1
services/web/public/coffee/ide/pdf/controllers/PdfController.coffee

@@ -85,7 +85,11 @@ define [
 			isTimeNonMonotonic = timeSinceLastCompile < 0
 
 			if isTimeNonMonotonic || timeSinceLastCompile >= AUTO_COMPILE_TIMEOUT
-				if (!ide.$scope.hasLintingError)
+				# If user has code check disabled, it is likely because they have
+				# linting errors that they are ignoring. Therefore it doesn't make sense
+				# to block auto compiles. It also causes problems where server-provided
+				# linting errors aren't cleared after typing
+				if (ide.$scope.settings.syntaxValidation and !ide.$scope.hasLintingError)
 					$scope.recompile(isAutoCompileOnChange: true)
 			else
 				# Extend remainder of timeout