Merge pull request #5302 from overleaf/ta-identify-identity

Skip Identify Job When userId Equal analyticsId

GitOrigin-RevId: 11eac0905dd0060df3556484db7ba301aba55375

services/web/app/src/Features/Analytics/AnalyticsManager.js

@@ -15,7 +15,7 @@ const analyticsUserPropertiesQueue = Queues.getAnalyticsUserPropertiesQueue()
 const ONE_MINUTE_MS = 60 * 1000
 
 function identifyUser(userId, analyticsId, isNewUser) {
-  if (!userId || !analyticsId) {
+  if (!userId || !analyticsId || userId === analyticsId) {
     return
   }
   if (_isAnalyticsDisabled() || _isSmokeTestUser(userId)) {

services/web/test/unit/src/Analytics/AnalyticsManagerTests.js

@@ -70,6 +70,16 @@ describe('AnalyticsManager', function () {
       this.AnalyticsManager.identifyUser(this.fakeUserId, '')
       sinon.assert.notCalled(this.analyticsEventsQueue.add)
     })
+
+    it('userId or analyticsId is missing', function () {
+      this.AnalyticsManager.identifyUser(this.fakeUserId, undefined)
+      sinon.assert.notCalled(this.analyticsEventsQueue.add)
+    })
+
+    it('userId equal analyticsId', function () {
+      this.AnalyticsManager.identifyUser(this.fakeUserId, this.fakeUserId)
+      sinon.assert.notCalled(this.analyticsEventsQueue.add)
+    })
   })
 
   describe('queues the appropriate message for', function () {