Merge pull request #1636 from sharelatex/ho-fail-lint

throw error in bash quickly on error

GitOrigin-RevId: 03df23aff25583f3af122f9a643c8faef64c5c46

services/web/install_deps.sh

@@ -1,10 +1,12 @@
 #!/bin/bash
 
+set -e
+
 WEBPACK_ENV=production make minify &
 make --no-print-directory format & 
 make --no-print-directory lint & 
 npm install git+https://github.com/sharelatex/translations-sharelatex.git#master &
-wait
+wait -n
 
 chmod -R 0755 /app/public
 chown -R node:node /app/public

services/web/public/src/ide/editor/Document.js

@@ -396,7 +396,7 @@ define([
           remote_doc_id: update != null ? update.doc : undefined,
           wantToBeJoined: this.wantToBeJoined,
           update,
-          hasDoc: (this.doc != null)
+          hasDoc: this.doc != null
         })
 
         if (

services/web/public/src/main/new-subscription.js

@@ -27,14 +27,22 @@ define(['base', 'directives/creditCards', 'libs/recurly-4.8.5'], App =>
       event_tracking.sendMB('subscription-form-switch-to-student', {
         plan: window.plan_code
       })
-      event_tracking.send('subscription-funnel', 'subscription-form-switch-to-student', window.plan_code)
+      event_tracking.send(
+        'subscription-funnel',
+        'subscription-form-switch-to-student',
+        window.plan_code
+      )
       window.location = `/user/subscription/new?planCode=${planCode}&currency=${
         $scope.currencyCode
       }&cc=${$scope.data.coupon}`
     }
 
     event_tracking.sendMB('subscription-form', { plan: window.plan_code })
-    event_tracking.send('subscription-funnel', 'subscription-form-viewed', window.plan_code)
+    event_tracking.send(
+      'subscription-funnel',
+      'subscription-form-viewed',
+      window.plan_code
+    )
 
     $scope.paymentMethod = { value: 'credit_card' }
 
@@ -203,13 +211,21 @@ define(['base', 'directives/creditCards', 'libs/recurly-4.8.5'], App =>
           coupon_code: postData.subscriptionDetails.coupon_code,
           isPaypal: postData.subscriptionDetails.isPaypal
         })
-        event_tracking.send('subscription-funnel', 'subscription-form-submitted',  postData.subscriptionDetails.plan_code)
+        event_tracking.send(
+          'subscription-funnel',
+          'subscription-form-submitted',
+          postData.subscriptionDetails.plan_code
+        )
 
         return $http
           .post('/user/subscription/create', postData)
           .then(function() {
             event_tracking.sendMB('subscription-submission-success')
-            event_tracking.send('subscription-funnel', 'subscription-submission-success', postData.subscriptionDetails.plan_code)
+            event_tracking.send(
+              'subscription-funnel',
+              'subscription-submission-success',
+              postData.subscriptionDetails.plan_code
+            )
             window.location.href = '/user/subscription/thank-you'
           })
           .catch(function() {