decaffeinate: Convert ContactsManagerTests.coffee and 1 other file to JS

services/contacts/test/unit/coffee/ContactsManagerTests.js

@@ -1,86 +1,118 @@
-sinon = require('sinon')
-chai = require('chai')
-should = chai.should()
-expect = chai.expect
-modulePath = "../../../app/js/ContactManager.js"
-SandboxedModule = require('sandboxed-module')
-ObjectId = require("mongojs").ObjectId
-tk = require("timekeeper")
+/*
+ * decaffeinate suggestions:
+ * DS102: Remove unnecessary code created because of implicit returns
+ * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
+ */
+const sinon = require('sinon');
+const chai = require('chai');
+const should = chai.should();
+const {
+    expect
+} = chai;
+const modulePath = "../../../app/js/ContactManager.js";
+const SandboxedModule = require('sandboxed-module');
+const {
+    ObjectId
+} = require("mongojs");
+const tk = require("timekeeper");
 
-describe "ContactManager", ->
-	beforeEach ->
-		tk.freeze(Date.now())
-		@ContactManager = SandboxedModule.require modulePath, requires:
+describe("ContactManager", function() {
+	beforeEach(function() {
+		tk.freeze(Date.now());
+		this.ContactManager = SandboxedModule.require(modulePath, { requires: {
 			"./mongojs": {
-				db: @db = contacts: {}
-				ObjectId: ObjectId
+				db: (this.db = {contacts: {}}),
+				ObjectId
 			},
 			'logger-sharelatex': {log: sinon.stub()},
 			'metrics-sharelatex': {timeAsyncMethod: sinon.stub()}
-		@user_id = ObjectId().toString()
-		@contact_id = ObjectId().toString()
-		@callback = sinon.stub()
+		}
+	});
+		this.user_id = ObjectId().toString();
+		this.contact_id = ObjectId().toString();
+		return this.callback = sinon.stub();
+	});
 	
-	afterEach ->
-		tk.reset()
+	afterEach(() => tk.reset());
 
-	describe "touchContact", ->
-		beforeEach ->
-			@db.contacts.update = sinon.stub().callsArg(3)
+	describe("touchContact", function() {
+		beforeEach(function() {
+			return this.db.contacts.update = sinon.stub().callsArg(3);
+		});
 		
-		describe "with a valid user_id", ->
-			beforeEach ->
-				@ContactManager.touchContact @user_id, @contact_id = "mock_contact", @callback
+		describe("with a valid user_id", function() {
+			beforeEach(function() {
+				return this.ContactManager.touchContact(this.user_id, (this.contact_id = "mock_contact"), this.callback);
+			});
 			
-			it "should increment the contact count and timestamp", ->
-				@db.contacts.update
+			it("should increment the contact count and timestamp", function() {
+				return this.db.contacts.update
 					.calledWith({
-						user_id: sinon.match((o) => o.toString() == @user_id.toString())
+						user_id: sinon.match(o => o.toString() === this.user_id.toString())
 					}, {
-						$inc:
+						$inc: {
 							"contacts.mock_contact.n": 1
-						$set:
+						},
+						$set: {
 							"contacts.mock_contact.ts": new Date()
+						}
 					}, {
 						upsert: true
 					})
-					.should.equal true
+					.should.equal(true);
+			});
 			
-			it "should call the callback", ->
-				@callback.called.should.equal true
+			return it("should call the callback", function() {
+				return this.callback.called.should.equal(true);
+			});
+		});
 		
-		describe "with an invalid user id", ->
-			beforeEach ->
-				@ContactManager.touchContact "not-valid-object-id", @contact_id, @callback
+		return describe("with an invalid user id", function() {
+			beforeEach(function() {
+				return this.ContactManager.touchContact("not-valid-object-id", this.contact_id, this.callback);
+			});
 			
-			it "should call the callback with an error", ->
-				@callback.calledWith(new Error()).should.equal true
+			return it("should call the callback with an error", function() {
+				return this.callback.calledWith(new Error()).should.equal(true);
+			});
+		});
+	});
 	
-	describe "getContacts", ->
-		beforeEach ->
-			@user = {
+	return describe("getContacts", function() {
+		beforeEach(function() {
+			this.user = {
 				contacts: ["mock", "contacts"]
-			}
-			@db.contacts.findOne = sinon.stub().callsArgWith(1, null, @user)
+			};
+			return this.db.contacts.findOne = sinon.stub().callsArgWith(1, null, this.user);
+		});
 		
-		describe "with a valid user_id", ->
-			beforeEach ->
-				@ContactManager.getContacts @user_id, @callback
+		describe("with a valid user_id", function() {
+			beforeEach(function() {
+				return this.ContactManager.getContacts(this.user_id, this.callback);
+			});
 			
-			it "should find the user's contacts", ->
-				@db.contacts.findOne
+			it("should find the user's contacts", function() {
+				return this.db.contacts.findOne
 					.calledWith({
-						user_id: sinon.match((o) => o.toString() == @user_id.toString())
+						user_id: sinon.match(o => o.toString() === this.user_id.toString())
 					})
-					.should.equal true
+					.should.equal(true);
+			});
 			
-			it "should call the callback with the contacts", ->
-				@callback.calledWith(null, @user.contacts).should.equal true
+			return it("should call the callback with the contacts", function() {
+				return this.callback.calledWith(null, this.user.contacts).should.equal(true);
+			});
+		});
 		
-		describe "with an invalid user id", ->
-			beforeEach ->
-				@ContactManager.getContacts "not-valid-object-id", @callback
+		return describe("with an invalid user id", function() {
+			beforeEach(function() {
+				return this.ContactManager.getContacts("not-valid-object-id", this.callback);
+			});
 			
-			it "should call the callback with an error", ->
-				@callback.calledWith(new Error()).should.equal true
+			return it("should call the callback with an error", function() {
+				return this.callback.calledWith(new Error()).should.equal(true);
+			});
+		});
+	});
+});
 		

services/contacts/test/unit/coffee/HttpControllerTests.js

@@ -1,120 +1,152 @@
-sinon = require('sinon')
-chai = require('chai')
-should = chai.should()
-expect = chai.expect
-modulePath = "../../../app/js/HttpController.js"
-SandboxedModule = require('sandboxed-module')
+/*
+ * decaffeinate suggestions:
+ * DS102: Remove unnecessary code created because of implicit returns
+ * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
+ */
+const sinon = require('sinon');
+const chai = require('chai');
+const should = chai.should();
+const {
+    expect
+} = chai;
+const modulePath = "../../../app/js/HttpController.js";
+const SandboxedModule = require('sandboxed-module');
 
-describe "HttpController", ->
-	beforeEach ->
-		@HttpController = SandboxedModule.require modulePath, requires:
-			"./ContactManager": @ContactManager = {}
-			"logger-sharelatex": @logger = { log: sinon.stub() }
-		@user_id = "mock-user-id"
-		@contact_id = "mock-contact-id"
+describe("HttpController", function() {
+	beforeEach(function() {
+		this.HttpController = SandboxedModule.require(modulePath, { requires: {
+			"./ContactManager": (this.ContactManager = {}),
+			"logger-sharelatex": (this.logger = { log: sinon.stub() })
+		}
+	});
+		this.user_id = "mock-user-id";
+		this.contact_id = "mock-contact-id";
 		
-		@req = {}
-		@res = {}
-		@res.status = sinon.stub().returns @res
-		@res.end = sinon.stub()
-		@res.send = sinon.stub()
-		@next = sinon.stub()
+		this.req = {};
+		this.res = {};
+		this.res.status = sinon.stub().returns(this.res);
+		this.res.end = sinon.stub();
+		this.res.send = sinon.stub();
+		return this.next = sinon.stub();
+	});
 
-	describe "addContact", ->
-		beforeEach ->
-			@req.params =
-				user_id: @user_id
-			@ContactManager.touchContact = sinon.stub().callsArg(2)
+	describe("addContact", function() {
+		beforeEach(function() {
+			this.req.params =
+				{user_id: this.user_id};
+			return this.ContactManager.touchContact = sinon.stub().callsArg(2);
+		});
 		
-		describe "with a valid user_id and contact_id", ->
-			beforeEach ->
-				@req.body =
-					contact_id: @contact_id
-				@HttpController.addContact @req, @res, @next
+		describe("with a valid user_id and contact_id", function() {
+			beforeEach(function() {
+				this.req.body =
+					{contact_id: this.contact_id};
+				return this.HttpController.addContact(this.req, this.res, this.next);
+			});
 			
-			it "should update the contact in the user's contact list", ->
-				@ContactManager.touchContact
-					.calledWith(@user_id, @contact_id)
-					.should.equal true
+			it("should update the contact in the user's contact list", function() {
+				return this.ContactManager.touchContact
+					.calledWith(this.user_id, this.contact_id)
+					.should.equal(true);
+			});
 			
-			it "should update the user in the contact's contact list", ->
-				@ContactManager.touchContact
-					.calledWith(@contact_id, @user_id)
-					.should.equal true
+			it("should update the user in the contact's contact list", function() {
+				return this.ContactManager.touchContact
+					.calledWith(this.contact_id, this.user_id)
+					.should.equal(true);
+			});
 			
-			it "should send back a 204 status", ->
-				@res.status.calledWith(204).should.equal true
-				@res.end.called.should.equal true
+			return it("should send back a 204 status", function() {
+				this.res.status.calledWith(204).should.equal(true);
+				return this.res.end.called.should.equal(true);
+			});
+		});
 		
-		describe "with an invalid contact id", ->
-			beforeEach ->
-				@req.body =
-					contact_id: ""
-				@HttpController.addContact @req, @res, @next
+		return describe("with an invalid contact id", function() {
+			beforeEach(function() {
+				this.req.body =
+					{contact_id: ""};
+				return this.HttpController.addContact(this.req, this.res, this.next);
+			});
 			
-			it "should return 400, Bad Request", ->
-				@res.status.calledWith(400).should.equal true
-				@res.send.calledWith("contact_id should be a non-blank string").should.equal true
+			return it("should return 400, Bad Request", function() {
+				this.res.status.calledWith(400).should.equal(true);
+				return this.res.send.calledWith("contact_id should be a non-blank string").should.equal(true);
+			});
+		});
+	});
 
-	describe "getContacts", ->
-		beforeEach ->
-			@req.params =
-				user_id: @user_id
-			now = Date.now()
-			@contacts = {
-				"user-id-1": { n: 2, ts: new Date(now) }
-				"user-id-2": { n: 4, ts: new Date(now) }
+	return describe("getContacts", function() {
+		beforeEach(function() {
+			this.req.params =
+				{user_id: this.user_id};
+			const now = Date.now();
+			this.contacts = {
+				"user-id-1": { n: 2, ts: new Date(now) },
+				"user-id-2": { n: 4, ts: new Date(now) },
 				"user-id-3": { n: 2, ts: new Date(now - 1000) }
-			}
-			@ContactManager.getContacts = sinon.stub().callsArgWith(1, null, @contacts)
+			};
+			return this.ContactManager.getContacts = sinon.stub().callsArgWith(1, null, this.contacts);
+		});
 
-		describe "normally", ->
-			beforeEach ->
-				@HttpController.getContacts @req, @res, @next
+		describe("normally", function() {
+			beforeEach(function() {
+				return this.HttpController.getContacts(this.req, this.res, this.next);
+			});
 				
-			it "should look up the contacts in mongo", ->
-				@ContactManager.getContacts
-					.calledWith(@user_id)
-					.should.equal true
+			it("should look up the contacts in mongo", function() {
+				return this.ContactManager.getContacts
+					.calledWith(this.user_id)
+					.should.equal(true);
+			});
 			
-			it "should return a sorted list of contacts by count and timestamp", ->
-				@res.send
+			return it("should return a sorted list of contacts by count and timestamp", function() {
+				return this.res.send
 					.calledWith({
 						contact_ids: [
-							"user-id-2"
-							"user-id-1"
+							"user-id-2",
+							"user-id-1",
 							"user-id-3"
 						]
 					})
-					.should.equal true
+					.should.equal(true);
+			});
+		});
 		
-		describe "with more contacts than the limit", ->
-			beforeEach ->
-				@req.query =
-					limit: 2
-				@HttpController.getContacts @req, @res, @next
+		describe("with more contacts than the limit", function() {
+			beforeEach(function() {
+				this.req.query =
+					{limit: 2};
+				return this.HttpController.getContacts(this.req, this.res, this.next);
+			});
 
-			it "should return the most commonly used contacts up to the limit", ->
-				@res.send
+			return it("should return the most commonly used contacts up to the limit", function() {
+				return this.res.send
 					.calledWith({
 						contact_ids: [
-							"user-id-2"
+							"user-id-2",
 							"user-id-1"
 						]
 					})
-					.should.equal true
+					.should.equal(true);
+			});
+		});
 		
-		describe "without a contact list", ->
-			beforeEach ->
-				@ContactManager.getContacts = sinon.stub().callsArgWith(1, null, null)
-				@HttpController.getContacts @req, @res, @next
+		describe("without a contact list", function() {
+			beforeEach(function() {
+				this.ContactManager.getContacts = sinon.stub().callsArgWith(1, null, null);
+				return this.HttpController.getContacts(this.req, this.res, this.next);
+			});
 
-			it "should return an empty list", ->
-				@res.send
+			return it("should return an empty list", function() {
+				return this.res.send
 					.calledWith({
 						contact_ids: []
 					})
-					.should.equal true
+					.should.equal(true);
+			});
+		});
 		
-		describe "with a holding account", ->
-			it "should not return holding accounts"
+		return describe("with a holding account", () => it("should not return holding accounts"));
+	});
+});