Просмотр исходного кода

Merge pull request #20517 from overleaf/dp-overview-edit-actions

Don't allow tracked changes to be edited in the overview tab in new review panel

GitOrigin-RevId: 132771c4105096034bf58bc3d4a7ba23c3d088b7
David 2 лет назад
Родитель
Сommit
9d3841a46d

+ 3 - 2
services/web/frontend/js/features/review-panel-new/components/review-panel-change.tsx

@@ -20,7 +20,8 @@ export const ReviewPanelChange = memo<{
   change: Change<EditOperation>
   change: Change<EditOperation>
   aggregate?: Change<DeleteOperation>
   aggregate?: Change<DeleteOperation>
   top?: number
   top?: number
-}>(({ change, aggregate, top }) => {
+  editable?: boolean
+}>(({ change, aggregate, top, editable = true }) => {
   const { t } = useTranslation()
   const { t } = useTranslation()
   const { acceptChanges, rejectChanges } = useRangesActionsContext()
   const { acceptChanges, rejectChanges } = useRangesActionsContext()
   const permissions = usePermissionsContext()
   const permissions = usePermissionsContext()
@@ -56,7 +57,7 @@ export const ReviewPanelChange = memo<{
               {formatTimeBasedOnYear(change.metadata?.ts)}
               {formatTimeBasedOnYear(change.metadata?.ts)}
             </div>
             </div>
           </div>
           </div>
-          {permissions.write && (
+          {editable && permissions.write && (
             <div className="review-panel-entry-actions">
             <div className="review-panel-entry-actions">
               <Tooltip
               <Tooltip
                 id="accept-change"
                 id="accept-change"

+ 1 - 0
services/web/frontend/js/features/review-panel-new/components/review-panel-overview-file.tsx

@@ -81,6 +81,7 @@ export const ReviewPanelOverviewFile: FC<{
               key={change.id}
               key={change.id}
               change={change}
               change={change}
               aggregate={aggregates.get(change.id)}
               aggregate={aggregates.get(change.id)}
+              editable={false}
             />
             />
           ))}
           ))}