Ver código fonte

Merge pull request #12 from overleaf/spd-async-pool-empty-array

Don't try to delete files if none are found in a directory
Simon Detheridge 6 anos atrás
pai
commit
9f28adf96c
1 arquivos alterados com 9 adições e 3 exclusões
  1. 9 3
      libraries/object-persistor/src/GcsPersistor.js

+ 9 - 3
libraries/object-persistor/src/GcsPersistor.js

@@ -220,9 +220,15 @@ module.exports = class GcsPersistor extends AbstractPersistor {
         .bucket(bucketName)
         .bucket(bucketName)
         .getFiles({ directory: key })
         .getFiles({ directory: key })
 
 
-      await asyncPool(this.settings.deleteConcurrency, files, async (file) => {
-        await this.deleteObject(bucketName, file.name)
-      })
+      if (Array.isArray(files) && files.length > 0) {
+        await asyncPool(
+          this.settings.deleteConcurrency,
+          files,
+          async (file) => {
+            await this.deleteObject(bucketName, file.name)
+          }
+        )
+      }
     } catch (err) {
     } catch (err) {
       const error = PersistorHelper.wrapError(
       const error = PersistorHelper.wrapError(
         err,
         err,