Просмотр исходного кода

Merge pull request #2670 from overleaf/em-convert-doc-to-file-rev

Adjust the file rev when converting a doc to a file

GitOrigin-RevId: 6765bcac1fcd4f4db35f9ce88af1f201f5da509a
Eric Mc Sween 6 лет назад
Родитель
Сommit
9f3b2d2cdc

+ 1 - 1
services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js

@@ -1555,7 +1555,7 @@ const ProjectEntityUpdateHandler = {
                         }
                         }
                         FileStoreHandler.uploadFileFromDisk(
                         FileStoreHandler.uploadFileFromDisk(
                           projectId,
                           projectId,
-                          { name: doc.name },
+                          { name: doc.name, rev: rev + 1 },
                           fsPath,
                           fsPath,
                           (err, fileStoreUrl, fileRef) => {
                           (err, fileStoreUrl, fileRef) => {
                             if (err) {
                             if (err) {

+ 3 - 2
services/web/test/unit/src/Project/ProjectEntityUpdateHandlerTests.js

@@ -2073,6 +2073,7 @@ describe('ProjectEntityUpdateHandler', function() {
       this.tmpFilePath = '/tmp/file'
       this.tmpFilePath = '/tmp/file'
       this.fileStoreUrl = 'http://filestore/file'
       this.fileStoreUrl = 'http://filestore/file'
       this.folder = { _id: new ObjectId() }
       this.folder = { _id: new ObjectId() }
+      this.rev = 3
       this.ProjectLocator.findElement
       this.ProjectLocator.findElement
         .withArgs({
         .withArgs({
           project_id: this.project._id,
           project_id: this.project._id,
@@ -2089,7 +2090,7 @@ describe('ProjectEntityUpdateHandler', function() {
         .yields(null, this.file, this.docPath, this.folder)
         .yields(null, this.file, this.docPath, this.folder)
       this.DocstoreManager.getDoc
       this.DocstoreManager.getDoc
         .withArgs(this.project._id, this.doc._id)
         .withArgs(this.project._id, this.doc._id)
-        .yields(null, this.docLines)
+        .yields(null, this.docLines, this.rev)
       this.FileWriter.writeLinesToDisk.yields(null, this.tmpFilePath)
       this.FileWriter.writeLinesToDisk.yields(null, this.tmpFilePath)
       this.FileStoreHandler.uploadFileFromDisk.yields(
       this.FileStoreHandler.uploadFileFromDisk.yields(
         null,
         null,
@@ -2124,7 +2125,7 @@ describe('ProjectEntityUpdateHandler', function() {
           this.FileStoreHandler.uploadFileFromDisk
           this.FileStoreHandler.uploadFileFromDisk
         ).to.have.been.calledWith(
         ).to.have.been.calledWith(
           this.project._id,
           this.project._id,
-          { name: this.doc.name },
+          { name: this.doc.name, rev: this.rev + 1 },
           this.tmpFilePath
           this.tmpFilePath
         )
         )
       })
       })