Просмотр исходного кода

Analytics disabled via Features.js (#2296)

GitOrigin-RevId: b3649bf8e6ef4eb37dee38ca7c6709a282904388
Miguel Serrano 7 лет назад
Родитель
Сommit
9fa858bbd6

+ 7 - 0
services/web/app/src/Features/Analytics/AnalyticsController.js

@@ -3,9 +3,13 @@ const Errors = require('../Errors/Errors')
 const AuthenticationController = require('../Authentication/AuthenticationController')
 const InstitutionsAPI = require('../Institutions/InstitutionsAPI')
 const GeoIpLookup = require('../../infrastructure/GeoIpLookup')
+const Features = require('../../infrastructure/Features')
 
 module.exports = {
   updateEditingSession(req, res, next) {
+    if (!Features.hasFeature('analytics')) {
+      return res.send(204)
+    }
     const userId = AuthenticationController.getLoggedInUserId(req)
     const { projectId } = req.params
     let countryCode = null
@@ -28,6 +32,9 @@ module.exports = {
   },
 
   recordEvent(req, res, next) {
+    if (!Features.hasFeature('analytics')) {
+      return res.send(204)
+    }
     const userId =
       AuthenticationController.getLoggedInUserId(req) || req.sessionID
     AnalyticsManager.recordEvent(userId, req.params.event, req.body, error =>

+ 1 - 0
services/web/app/src/infrastructure/Features.js

@@ -41,6 +41,7 @@ module.exports = Features = {
       case 'templates-server-pro':
         return Settings.overleaf == null
       case 'affiliations':
+      case 'analytics':
         // Checking both properties is needed for the time being to allow
         // enabling the feature in web-api and disabling in Server Pro
         // see https://github.com/overleaf/web-internal/pull/2127