Browse Source

Fix doc names and sort order in resolved comments dropdown

James Allen 9 years ago
parent
commit
a42cc48be8

+ 1 - 1
services/web/app/views/project/editor/review-panel.jade

@@ -289,7 +289,7 @@ script(type='text/ng-template', id='resolvedCommentsDropdownTemplate')
 				ng-if="!isLoading"
 			)
 				resolved-comment-entry(
-					ng-repeat="thread in resolvedComments | orderBy:'-resolved_at'"
+					ng-repeat="thread in resolvedComments | orderBy:'resolved_at':true"
 					thread="thread"
 					on-unresolve="handleUnresolve(threadId);"
 					on-delete="handleDelete(entryId, threadId);"

+ 1 - 1
services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee

@@ -33,7 +33,7 @@ define [
 				scope.onDelete({ entryId, threadId })
 
 			getDocNameById = (docId) ->
-				doc = _.find(scope.docs, (doc) -> doc.doc.id = docId)
+				doc = _.find(scope.docs, (doc) -> doc.doc.id == docId)
 				if doc?
 					return doc.path
 				else