Przeglądaj źródła

Merge pull request #1629 from sharelatex/sk-censor-token-prefix

Censor `tokens.readAndWritePrefix` when building project model

GitOrigin-RevId: 0fe3fc2657aa191808ea282dfcd2ea5506e93fee
Shane Kilkelly 7 lat temu
rodzic
commit
a5ad2e48d4

+ 1 - 0
services/web/app/coffee/Features/TokenAccess/TokenAccessHandler.coffee

@@ -134,6 +134,7 @@ module.exports = TokenAccessHandler =
 				return
 			if privilegeLevel != PrivilegeLevels.READ_AND_WRITE
 				project.tokens.readAndWrite = ''
+				project.tokens.readAndWritePrefix = ''
 			if privilegeLevel != PrivilegeLevels.READ_ONLY
 				project.tokens.readOnly = ''
 

+ 2 - 1
services/web/test/unit/coffee/TokenAccess/TokenAccessHandlerTests.coffee

@@ -480,11 +480,12 @@ describe "TokenAccessHandler", ->
 
 	describe 'protectTokens', ->
 		beforeEach ->
-			@project = {tokens: {readAndWrite: 'rw', readOnly: 'ro'}}
+			@project = {tokens: {readAndWrite: 'rw', readOnly: 'ro', readAndWritePrefix: 'pre'}}
 
 		it 'should hide write token from read-only user', ->
 			@TokenAccessHandler.protectTokens(@project, 'readOnly')
 			expect(@project.tokens.readAndWrite).to.equal ''
+			expect(@project.tokens.readAndWritePrefix).to.equal ''
 			expect(@project.tokens.readOnly).to.equal 'ro'
 
 		it 'should hide read token from read-write user', ->