Merge pull request #20024 from overleaf/mf-plans-page-click

[web] Implement `plans-page-click` event on new plans page

GitOrigin-RevId: 1dbfc5faa433985c1ad81ba645cdb8f6f3a0b864

services/web/frontend/js/features/event-tracking/index.js

@@ -10,10 +10,13 @@ function setupEventTracking(el) {
   const trigger = el.getAttribute('event-tracking-trigger')
   const sendOnce = el.getAttribute('event-tracking-send-once')
   const element = el.getAttribute('event-tracking-element')
-  const segmentation = JSON.parse(el.getAttribute('event-segmentation') || '{}')
-  segmentation.page = window.location.pathname
 
   function submit() {
+    const segmentation = JSON.parse(
+      el.getAttribute('event-segmentation') || '{}'
+    )
+    segmentation.page = window.location.pathname
+
     if (element === 'checkbox') {
       segmentation.checkbox = el.checked ? 'checked' : 'unchecked'
     } else if (element === 'select') {

services/web/frontend/js/pages/user/subscription/plans-v2/plans-v2-main.js

@@ -56,7 +56,6 @@ function setUpSubscriptionTracking(linkEl) {
       'billing-period': period,
     }
 
-    eventTracking.sendMB('plans-page-start-trial') // deprecated by plans-page-click
     eventTracking.sendMB(eventTrackingKey, eventTrackingSegmentation)
   })
 }