Răsfoiți Sursa

Use 404 code when rejecting invalid project id

Shane Kilkelly 7 ani în urmă
părinte
comite
ac4f4082c8

+ 1 - 1
services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/server/Oauth2Filter.java

@@ -72,7 +72,7 @@ public class Oauth2Filter implements Filter {
         String requestUri = ((Request) servletRequest).getRequestURI();
         if (requestUri.startsWith("/project")) {
             Log.info("[{}] Invalid request URI", requestUri);
-            sendResponse(servletResponse,400, Arrays.asList(
+            sendResponse(servletResponse,404, Arrays.asList(
                     "Invalid Project ID (must not have a '/project' prefix)"
             ));
             return;

+ 1 - 1
services/git-bridge/src/test/java/uk/ac/ic/wlgitbridge/application/WLGitBridgeIntegrationTest.java

@@ -885,7 +885,7 @@ public class WLGitBridgeIntegrationTest {
         assertEquals(Arrays.asList(
             "Cloning into '1234abcd'...",
             "remote: Invalid Project ID (must not have a '/project' prefix)",
-            "fatal: unable to access 'http://127.0.0.1:33886/project/1234abcd/': The requested URL returned error: 400"
+            "fatal: repository 'http://127.0.0.1:33886/project/1234abcd/' not found"
         ), actual);
 
         wlgb.stop();