Просмотр исходного кода

Merge pull request #8389 from overleaf/ab-fix-analytics-enabled-flag

Skip persisting assignment when analyticsEnabled is turned off

GitOrigin-RevId: e22b2cc29a5741ad90743ebaf5eb2c91cca0a2f5
Alexandre Bourdin 4 лет назад
Родитель
Сommit
ad3eb0bfcc
1 измененных файлов с 6 добавлено и 4 удалено
  1. 6 4
      services/web/app/src/Features/SplitTests/SplitTestHandler.js

+ 6 - 4
services/web/app/src/Features/SplitTests/SplitTestHandler.js

@@ -192,10 +192,12 @@ async function _getAssignment(
       phase,
       versionNumber,
     }
-    if (sync === true) {
-      await _updateVariantAssignment(assignmentConfig)
-    } else {
-      _updateVariantAssignment(assignmentConfig)
+    if (currentVersion.analyticsEnabled) {
+      if (sync === true) {
+        await _updateVariantAssignment(assignmentConfig)
+      } else {
+        _updateVariantAssignment(assignmentConfig)
+      }
     }
     return _makeAssignment(splitTest, selectedVariantName, currentVersion)
   }