Merge pull request #2604 from overleaf/cmg-duplicate-modal-root

Stop duplicate file modal appearing when moving back to original folder - root edition

GitOrigin-RevId: 11fe3b2457190f8bada010a344143a66b8967f34

services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js

@@ -22,19 +22,24 @@ define(['base'], App =>
       } else {
         entities = [$(ui.draggable).scope().entity]
       }
+
+      const ids = rootFolder.children.map(entity => entity.id)
+
       for (let dropped_entity of Array.from(entities)) {
-        try {
-          ide.fileTreeManager.moveEntity(dropped_entity, rootFolder)
-        } catch (err) {
-          $modal.open({
-            templateUrl: 'duplicateFileModalTemplate',
-            controller: 'DuplicateFileModalController',
-            resolve: {
-              fileName() {
-                return dropped_entity.name
+        if (!ids.includes(dropped_entity.id)) {
+          try {
+            ide.fileTreeManager.moveEntity(dropped_entity, rootFolder)
+          } catch (err) {
+            $modal.open({
+              templateUrl: 'duplicateFileModalTemplate',
+              controller: 'DuplicateFileModalController',
+              resolve: {
+                fileName() {
+                  return dropped_entity.name
+                }
               }
-            }
-          })
+            })
+          }
         }
       }
       $scope.$digest()