Merge pull request #4186 from overleaf/ab-expired-sub-plan-code-prop

Keep subscription plan code user property when a subscription expires

GitOrigin-RevId: 195bfa440dc3fb020f4cbefe44f87bc975aade70

services/web/app/src/Features/Subscription/RecurlyEventHandler.js

@@ -78,7 +78,7 @@ function _sendSubscriptionExpiredEvent(eventData) {
     quantity,
     is_trial: isTrial,
   })
-  AnalyticsManager.setUserProperty(userId, 'subscription-plan-code', null)
+  AnalyticsManager.setUserProperty(userId, 'subscription-plan-code', planCode)
   AnalyticsManager.setUserProperty(userId, 'subscription-state', state)
   AnalyticsManager.setUserProperty(userId, 'subscription-is-trial', isTrial)
 }

services/web/test/unit/src/Subscription/RecurlyEventHandlerTests.js

@@ -188,6 +188,12 @@ describe('RecurlyEventHandler', function () {
         is_trial: true,
       }
     )
+    sinon.assert.calledWith(
+      this.AnalyticsManager.setUserProperty,
+      this.userId,
+      'subscription-plan-code',
+      this.planCode
+    )
     sinon.assert.calledWith(
       this.AnalyticsManager.setUserProperty,
       this.userId,