Explorar o código

Merge pull request #4169 from overleaf/jpa-pdf-caching-full-beta

[misc] change pdf caching split test for beta users to 50/50 roll out

GitOrigin-RevId: 3153448db82a9f0fa821da9d6cf5255e1feaaf28
Jakob Ackermann %!s(int64=5) %!d(string=hai) anos
pai
achega
c774ddd111

+ 1 - 1
services/web/app/src/Features/Project/ProjectController.js

@@ -715,7 +715,7 @@ const ProjectController = {
           if (!userId) return cb(null, '')
           SplitTestHandler.getTestSegmentation(
             userId,
-            'pdf_caching_beta',
+            'pdf_caching_beta_full',
             (err, segmentation) => {
               if (err) {
                 // Do not fail loading the editor.

+ 3 - 22
services/web/config/settings.defaults.js

@@ -345,35 +345,16 @@ module.exports = {
       ],
     },
     {
-      id: 'pdf_caching_beta',
+      id: 'pdf_caching_beta_full',
       active: process.env.SPLIT_TEST_PDF_CACHING_BETA_ACTIVE === 'true',
       variants: [
         {
           id: 'collect-metrics-only',
-          rolloutPercent: parseInt(
-            process.env
-              .SPLIT_TEST_PDF_CACHING_BETA_COLLECT_METRICS_ONLY_ROLLOUT_PERCENT ||
-              '0',
-            10
-          ),
+          rolloutPercent: 50,
         },
         {
           id: 'collect-metrics-and-enable-caching',
-          rolloutPercent: parseInt(
-            process.env
-              .SPLIT_TEST_PDF_CACHING_BETA_COLLECT_METRICS_AND_ENABLE_CACHING_ROLLOUT_PERCENT ||
-              '0',
-            10
-          ),
-        },
-        {
-          id: 'enable-caching-only',
-          rolloutPercent: parseInt(
-            process.env
-              .SPLIT_TEST_PDF_CACHING_BETA_ENABLE_CACHING_ONLY_ROLLOUT_PERCENT ||
-              '0',
-            10
-          ),
+          rolloutPercent: 50,
         },
       ],
     },

+ 2 - 2
services/web/frontend/js/ide/pdf/controllers/PdfJsMetrics.js

@@ -72,7 +72,7 @@ function submitCompileMetrics(metrics) {
     compileTimeServerE2E: timings.compileE2E,
   }
   sl_console.log('/event/compile-metrics', JSON.stringify(metrics))
-  sendMB('compile-metrics-v2', leanMetrics, SAMPLING_RATE)
+  sendMB('compile-metrics-v3', leanMetrics, SAMPLING_RATE)
 }
 
 function submitPDFBandwidth(metrics) {
@@ -84,5 +84,5 @@ function submitPDFBandwidth(metrics) {
     })
   })
   sl_console.log('/event/pdf-bandwidth', JSON.stringify(metrics))
-  sendMB('pdf-bandwidth-v2', metricsFlat, SAMPLING_RATE)
+  sendMB('pdf-bandwidth-v3', metricsFlat, SAMPLING_RATE)
 }