Sfoglia il codice sorgente

Allow all Unicode "letter" characters in PDF filename (#13071)

GitOrigin-RevId: 030d7326b33525a34bccff26e12103e9a8e1a3f3
Alf Eaton 3 anni fa
parent
commit
c8c17bca38

+ 1 - 3
services/web/app/src/Features/Compile/CompileController.js

@@ -371,9 +371,7 @@ module.exports = CompileController = {
   },
 
   _getSafeProjectName(project) {
-    const wordRegExp = /\W/g
-    const safeProjectName = project.name.replace(wordRegExp, '_')
-    return safeProjectName
+    return project.name.replace(/\P{L}/gu, '_')
   },
 
   deleteAuxFiles(req, res, next) {

+ 2 - 2
services/web/test/unit/src/Compile/CompileControllerTests.js

@@ -356,7 +356,7 @@ describe('CompileController', function () {
       this.req.params = { Project_id: this.projectId }
 
       this.req.query = { pdfng: true }
-      this.project = { name: 'test namè' }
+      this.project = { name: 'test namè;' }
       this.ProjectGetter.getProject = sinon
         .stub()
         .callsArgWith(2, null, this.project)
@@ -380,7 +380,7 @@ describe('CompileController', function () {
 
       it('should set the content-disposition header with a safe version of the project name', function () {
         this.res.setContentDisposition.should.be.calledWith('inline', {
-          filename: 'test_nam_.pdf',
+          filename: 'test_namè_.pdf',
         })
       })