Browse Source

Merge pull request #7074 from overleaf/tm-collaborator-to-standard-split-test

Add split test for 'Collaborator' to 'Standard' name change

GitOrigin-RevId: 549c5ac566f622f52218adc571a427e6241a53ee
Thomas 4 years ago
parent
commit
cc6a9519e2

+ 8 - 0
services/web/app/src/Features/Subscription/SubscriptionController.js

@@ -65,6 +65,13 @@ async function plansPage(req, res) {
   const newPlansPageVariant =
     assignment && assignment.variant === 'new-plans-page'
 
+  const standardPlanNameAssignment =
+    await SplitTestHandler.promises.getAssignment(req, 'standard-plan-name')
+
+  const useNewPlanName =
+    standardPlanNameAssignment &&
+    standardPlanNameAssignment.variant === 'new-plan-name'
+
   res.render('subscriptions/plans-marketing', {
     title: 'plans_and_pricing',
     plans,
@@ -76,6 +83,7 @@ async function plansPage(req, res) {
     groupPlanModalOptions,
     groupPlanModalDefaults,
     newPlansPageVariant,
+    useNewPlanName,
   })
 }
 

+ 4 - 1
services/web/app/views/subscriptions/_plans_page_mixins.pug

@@ -207,7 +207,10 @@ mixin allCardsAndControls(controlsRowSpaced, listLocation)
 							.best-value
 								strong #{translate('best_value')}
 							.card-header
-								h2 #{translate("collaborator")}
+								if (useNewPlanName)
+									h2 #{translate("standard")}
+								else
+									h2 #{translate("collaborator")}
 							h5.tagline #{translate("tagline_collaborator")}
 							.circle
 								+price_collaborator

+ 4 - 1
services/web/app/views/subscriptions/plans-marketing/_group_plan_modal.pug

@@ -39,7 +39,10 @@ div.modal.fade(tabindex="-1" role="dialog" data-ol-group-plan-modal)
 									for plan_code in groupPlanModalOptions.plan_codes
 										label.group-plan-option
 											input(type="radio" name="plan_code" checked=(plan_code.code === "collaborator") value=plan_code.code )
-											span #{plan_code.display}
+											if (useNewPlanName && plan_code.code === 'collaborator')
+												span Standard
+											else
+												span #{plan_code.display}
 								.form-group
 									label(for='size')
 										| Number of users

+ 8 - 2
services/web/app/views/subscriptions/plans-marketing/_mixins.pug

@@ -257,7 +257,10 @@ mixin allCardsAndControls(controlsRowSpaced, listLocation)
 								.best-value
 									strong #{translate('best_value')}
 								.card-header
-									h2 #{translate("collaborator")}
+									if (useNewPlanName)
+										h2 #{translate("standard")}
+									else
+										h2 #{translate("collaborator")}
 								h5.tagline #{translate("tagline_collaborator")}
 								.circle
 									+price_collaborator
@@ -316,7 +319,10 @@ mixin allCardsAndControlsForVariant()
 								.best-value
 									strong #{translate('best_value')}
 								.card-header
-									h2 #{translate("collaborator")}
+									if (useNewPlanName)
+										h2 #{translate("standard")}
+									else
+										h2 #{translate("collaborator")}
 								h5.tagline #{translate("tagline_collaborator")}
 								.circle
 									+price_collaborator

+ 5 - 1
services/web/app/views/subscriptions/plans-marketing/_tables.pug

@@ -5,7 +5,11 @@ mixin table_premium
 			th
 			th #{translate("free")}
 			th #{translate("personal")}
-			th #{translate("collaborator")}
+			th
+				if (useNewPlanName)
+					| #{translate("standard")}
+				else
+					| #{translate("collaborator")}
 				.outer.outer-top
 					.outer-content
 						.best-value

+ 1 - 0
services/web/locales/en.json

@@ -926,6 +926,7 @@
   "group_plans": "Group plans",
   "one_collaborator": "Only one collaborator",
   "collaborator": "Collaborator",
+  "standard": "Standard",
   "collabs_per_proj": "__collabcount__ collaborators per project",
   "full_doc_history": "Full document history",
   "sync_to_dropbox": "Sync to Dropbox",