Explorar el Código

Merge pull request #14796 from overleaf/rd-report-footer-recognition

Accessibility - indicate that the footer has navigational purpose

GitOrigin-RevId: 74edf40ac5bc6eb4ee67527b5718d65fcd77d5a6
Rebeka Dekany hace 3 años
padre
commit
d1d6687f6c
Se han modificado 2 ficheros con 2 adiciones y 1 borrados
  1. 1 1
      services/web/app/views/layout/fat-footer.pug
  2. 1 0
      services/web/locales/en.json

+ 1 - 1
services/web/app/views/layout/fat-footer.pug

@@ -1,7 +1,7 @@
 - var featuresPageVariant = splitTestVariants && splitTestVariants['features-page']
 - var featuresPageVariant = splitTestVariants && splitTestVariants['features-page']
 
 
 footer.fat-footer.hidden-print
 footer.fat-footer.hidden-print
-	.fat-footer-container
+	.fat-footer-container(role="navigation" aria-label=translate('footer_navigation'))
 		.fat-footer-sections(class=hideFatFooter ? 'hidden' : undefined)
 		.fat-footer-sections(class=hideFatFooter ? 'hidden' : undefined)
 			.footer-section#footer-brand
 			.footer-section#footer-brand
 				a(href='/', aria-label=settings.appName).footer-brand
 				a(href='/', aria-label=settings.appName).footer-brand

+ 1 - 0
services/web/locales/en.json

@@ -582,6 +582,7 @@
   "font_size": "Font Size",
   "font_size": "Font Size",
   "footer_about_us": "About us",
   "footer_about_us": "About us",
   "footer_contact_us": "Contact us",
   "footer_contact_us": "Contact us",
+  "footer_navigation": "Footer navigation",
   "footer_plans_and_pricing": "Plans & pricing",
   "footer_plans_and_pricing": "Plans & pricing",
   "for_american_express": "For <0>American Express</0>, the <1>4 digits</1> on the <2>front</2> of your card.",
   "for_american_express": "For <0>American Express</0>, the <1>4 digits</1> on the <2>front</2> of your card.",
   "for_enterprise": "For enterprise",
   "for_enterprise": "For enterprise",