Explorar o código

Don't be so verbose with client update errors

James Allen %!s(int64=12) %!d(string=hai) anos
pai
achega
d62dc7ca3a
Modificáronse 1 ficheiros con 3 adicións e 1 borrados
  1. 3 1
      services/real-time/app/coffee/WebsocketController.coffee

+ 3 - 1
services/real-time/app/coffee/WebsocketController.coffee

@@ -115,7 +115,9 @@ module.exports = WebsocketController =
 			logger.log {user_id, project_id, client_id: client.id, cursorData: cursorData}, "updating client position"
 			logger.log {user_id, project_id, client_id: client.id, cursorData: cursorData}, "updating client position"
 					
 					
 			AuthorizationManager.assertClientCanViewProject client, (error) ->
 			AuthorizationManager.assertClientCanViewProject client, (error) ->
-				return callback(error) if error?
+				if error?
+					logger.warn {client_id: client.id, project_id, user_id}, "silently ignoring unauthorized updateClientPosition. Client likely hasn't called joinProject yet."
+					callback()
 				cursorData.id      = client.id
 				cursorData.id      = client.id
 				cursorData.user_id = user_id if user_id?
 				cursorData.user_id = user_id if user_id?
 				cursorData.email   = email   if email?
 				cursorData.email   = email   if email?