Explorar o código

Switch redirectToOLFreeTrialUrl to calculate trial url

Sending unnecessary query params to OL seems like a footgun, so switch to
compromise that is more explicit but doesn't send unnecessary query params
Alasdair Smith %!s(int64=8) %!d(string=hai) anos
pai
achega
da2c0b3fea

+ 2 - 5
services/web/app/views/layout.pug

@@ -98,11 +98,8 @@ html(itemscope, itemtype='http://schema.org/Product')
 
 		- if (settings.overleaf && settings.overleaf.host)
 			script.
-				window.freeTrialBaseUrl = '!{settings.overleaf.host}/users/trial'
-		- else
-			script.
-				window.freeTrialBaseUrl = '/user/subscription/new'
-				
+				window.redirectToOLFreeTrialUrl = '!{settings.overleaf.host}/users/trial'
+
 	body
 		if(settings.recaptcha)
 			script(src="https://www.google.com/recaptcha/api.js?render=explicit")

+ 6 - 3
services/web/public/coffee/main/account-upgrade.coffee

@@ -11,9 +11,12 @@ define [
 			w = window.open()
 			go = () ->
 				ga?('send', 'event', 'subscription-funnel', 'upgraded-free-trial', source)
-				url = "#{window.freeTrialBaseUrl}?planCode=#{plan}&ssp=true"
-				if couponCode?
-					url = "#{url}&cc=#{couponCode}"
+				if window.redirectToOLFreeTrialUrl?
+					url = window.redirectToOLFreeTrialUrl
+				else
+					url = "/user/subscription/new?planCode=#{plan}&ssp=true"
+					if couponCode?
+						url = "#{url}&cc=#{couponCode}"
 				$scope.startedFreeTrial = true
 
 				switch source