Просмотр исходного кода

Merge pull request #5064 from overleaf/ab-analytics-smoke-check

Add null check for smoke test user in analytics manager

GitOrigin-RevId: 2ece12f1a674943577ecee272435df535225ec9e
Alexandre Bourdin 5 лет назад
Родитель
Сommit
dd018be499
1 измененных файлов с 5 добавлено и 1 удалено
  1. 5 1
      services/web/app/src/Features/Analytics/AnalyticsManager.js

+ 5 - 1
services/web/app/src/Features/Analytics/AnalyticsManager.js

@@ -178,7 +178,11 @@ function _setUserProperty({ analyticsId, propertyName, propertyValue }) {
 
 
 function _isSmokeTestUser(userId) {
 function _isSmokeTestUser(userId) {
   const smokeTestUserId = Settings.smokeTest && Settings.smokeTest.userId
   const smokeTestUserId = Settings.smokeTest && Settings.smokeTest.userId
-  return smokeTestUserId != null && userId.toString() === smokeTestUserId
+  return (
+    smokeTestUserId != null &&
+    userId != null &&
+    userId.toString() === smokeTestUserId
+  )
 }
 }
 
 
 function _isAnalyticsDisabled() {
 function _isAnalyticsDisabled() {