Просмотр исходного кода

Merge pull request #11355 from overleaf/em-delete-project-no-chunks

Fix crash when there are no chunks to delete

GitOrigin-RevId: 3cdb77da16fe2922888e40e469740579bc4a9b8b
Eric Mc Sween 3 лет назад
Родитель
Сommit
ddf14b0cdd
1 измененных файлов с 3 добавлено и 1 удалено
  1. 3 1
      services/history-v1/storage/lib/chunk_store/postgres.js

+ 3 - 1
services/history-v1/storage/lib/chunk_store/postgres.js

@@ -199,7 +199,6 @@ async function deleteChunk(projectId, chunkId) {
 async function deleteProjectChunks(projectId) {
   projectId = parseInt(projectId, 10)
   assert.integer(projectId, 'bad projectId')
-  assert.integer(projectId, 'bad projectId')
 
   knex.transaction(async tx => {
     await _deleteChunks(knex, { doc_id: projectId })
@@ -208,6 +207,9 @@ async function deleteProjectChunks(projectId) {
 
 async function _deleteChunks(tx, whereClause) {
   const rows = await tx('chunks').returning('*').where(whereClause).del()
+  if (rows.length === 0) {
+    return
+  }
 
   const oldChunks = rows.map(row => ({
     doc_id: row.doc_id,