Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions

Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b

services/web/.eslintrc

@@ -18,6 +18,8 @@
     }
   },
   "rules": {
+    "no-constant-binary-expression": "error",
+
     // do not allow importing of implicit dependencies.
     "import/no-extraneous-dependencies": "error",
 

services/web/frontend/js/features/source-editor/components/figure-modal/figure-modal.tsx

@@ -217,8 +217,8 @@ const FigureModalContent = () => {
                 '\\begin{figure}',
                 '\t\\centering',
                 `\t\\includegraphics${widthArgument}{${path}}`,
-                `\t${captionCommand}` || null,
-                `\t${labelCommand}` || null,
+                `\t${captionCommand}`,
+                `\t${labelCommand}`,
                 `\\end{figure}${suffix}`,
               ],
               view.state,