Make links more descriptive on the Account settings page (#25558)

GitOrigin-RevId: 21cb7c02f7a5678b4c385da5b842ad6a5303169b

services/web/frontend/extracted-translations.json

@@ -31,7 +31,6 @@
   "about_to_leave_project": "",
   "about_to_leave_projects": "",
   "about_to_trash_projects": "",
-  "about_writefull": "",
   "abstract": "",
   "accept_and_continue": "",
   "accept_change": "",
@@ -222,6 +221,7 @@
   "center": "",
   "change": "",
   "change_currency": "",
+  "change_email": "",
   "change_language": "",
   "change_or_cancel-cancel": "",
   "change_or_cancel-change": "",
@@ -670,6 +670,7 @@
   "github_workflow_files_delete_github_repo": "",
   "github_workflow_files_error": "",
   "give_feedback": "",
+  "give_feedback_about": "",
   "give_your_feedback": "",
   "go_next_page": "",
   "go_page": "",
@@ -903,7 +904,6 @@
   "learn_more_about_compile_timeouts": "",
   "learn_more_about_link_sharing": "",
   "learn_more_about_managed_users": "",
-  "learn_more_about_managing_email": "",
   "learn_more_about_other_causes_of_compile_timeouts": "",
   "leave": "",
   "leave_any_group_subscriptions": "",
@@ -1145,7 +1145,6 @@
   "other_causes_of_compile_timeouts": "",
   "other_logs_and_files": "",
   "other_output_files": "",
-  "our_help_page": "",
   "our_team_will_get_back_to_you_shortly": "",
   "our_values": "",
   "out_of_sync": "",

services/web/frontend/js/features/settings/components/emails-section.tsx

@@ -40,7 +40,6 @@ function EmailsSectionContent() {
             <a
               href="/learn/how-to/Managing_your_Overleaf_emails"
               target="_blank"
-              aria-label={t('learn_more_about_managing_email')}
             />,
           ]}
         />

services/web/frontend/js/features/settings/components/emails/institution-and-role.tsx

@@ -115,7 +115,7 @@ function InstitutionAndRole({ userEmailData }: InstitutionAndRoleProps) {
           >
             {!affiliation.department && !affiliation.role
               ? t('add_role_and_department')
-              : t('change')}
+              : t('change_email')}
           </OLButton>
         </div>
       ) : (

services/web/frontend/js/features/settings/components/linking/integration-widget.tsx

@@ -72,13 +72,8 @@ export function IntegrationLinkingWidget({
         </div>
         <p className="small">
           {description}{' '}
-          <a
-            href={helpPath}
-            target="_blank"
-            rel="noreferrer"
-            aria-label={t('learn_more_about', { integrationName: title })}
-          >
-            {t('learn_more')}
+          <a href={helpPath} target="_blank" rel="noreferrer">
+            {t('learn_more_about', { appName: title })}
           </a>
         </p>
         {hasFeature && statusIndicator}

services/web/frontend/js/features/settings/components/linking/sso-widget.tsx

@@ -74,13 +74,8 @@ export function SSOLinkingWidget({
         <p className="small">
           {description?.replace(/<[^>]+>/g, '')}{' '}
           {helpPath ? (
-            <a
-              href={helpPath}
-              target="_blank"
-              rel="noreferrer"
-              aria-label={t('learn_more_about', { integrationName: title })}
-            >
-              {t('learn_more')}
+            <a href={helpPath} target="_blank" rel="noreferrer">
+              {t('learn_more_about', { appName: title })}
             </a>
           ) : null}
         </p>

services/web/locales/en.json

@@ -34,7 +34,6 @@
   "about_to_leave_project": "You are about to leave this project.",
   "about_to_leave_projects": "You are about to leave the following projects:",
   "about_to_trash_projects": "You are about to trash the following projects:",
-  "about_writefull": "About Writefull",
   "abstract": "Abstract",
   "accept": "Accept",
   "accept_and_continue": "Accept and continue",
@@ -288,6 +287,7 @@
   "certificate": "Certificate",
   "change": "Change",
   "change_currency": "Change currency",
+  "change_email": "Change email",
   "change_language": "Change language",
   "change_or_cancel-cancel": "cancel",
   "change_or_cancel-change": "Change",
@@ -297,7 +297,7 @@
   "change_password_in_account_settings": "Change password in Account Settings",
   "change_plan": "Change plan",
   "change_primary_email": "Change primary email",
-  "change_primary_email_address_instructions": "To change your primary email, please add your new primary email address first (by clicking <0>Add another email</0>) and confirm it. Then click the <0>Make Primary</0> button. <1>Learn more</1> about managing your __appName__ emails.",
+  "change_primary_email_address_instructions": "To change your primary email, please add your new primary email address first (by clicking <0>Add another email</0>) and confirm it. Then click the <0>Make Primary</0> button. <1>Learn more about managing your __appName__ emails</1>.",
   "change_project_owner": "Change Project Owner",
   "change_the_ownership_of_your_personal_projects": "Change the ownership of your personal projects to the new account. <0>Find out how to change project owner.</0>",
   "change_to_group_plan": "Change to a group plan",
@@ -845,7 +845,7 @@
   "git_bridge_modal_use_previous_token": "If you’re prompted for a password, you can use a previously generated Git authentication token. Or you can generate a new one in Account Settings. For more support, read our <0>help page</0>.",
   "git_gitHub_dropbox_mendeley_papers_and_zotero_integrations": "Git, GitHub, Dropbox, Papers, Zotero, and Mendeley integrations",
   "git_integration": "Git Integration",
-  "git_integration_info": "With Git integration, you can clone your Overleaf projects with Git. For full instructions on how to do this, read <0>our help page</0>.",
+  "git_integration_info": "With Git integration, you can clone your Overleaf projects with Git. For full instructions on how to do this, <0>read our Git Integration help page</0>.",
   "github": "GitHub",
   "github_commit_message_placeholder": "Commit message for changes made in __appName__...",
   "github_credentials_expired": "Your GitHub authorization credentials have expired",
@@ -876,6 +876,7 @@
   "github_workflow_files_delete_github_repo": "The repository has been created on GitHub but linking was unsuccessful. You will have to delete GitHub repository or choose a new name.",
   "github_workflow_files_error": "The __appName__ GitHub sync service couldn’t sync GitHub Workflow files (in .github/workflows/). Please authorize __appName__ to edit your GitHub workflow files and try again.",
   "give_feedback": "Give feedback",
+  "give_feedback_about": "Give feedback about __appName__",
   "give_your_feedback": "give your feedback",
   "global": "global",
   "go_back_and_link_accts": "<a href=\"__link__\">Go back</a> and link your accounts",
@@ -1176,13 +1177,12 @@
   "ldap_create_admin_instructions": "Choose an email address for the first __appName__ admin account. This should correspond to an account in the LDAP system. You will then be asked to log in with this account.",
   "learn": "Learn",
   "learn_more": "Learn more",
-  "learn_more_about": "Learn more about __integrationName__",
+  "learn_more_about": "Learn more about __appName__",
   "learn_more_about_account": "<0>Learn more</0> about managing your __appName__ account.",
   "learn_more_about_compile_timeouts": "<0>Learn more</0> about compile timeouts.",
   "learn_more_about_emails": "<0>Learn more</0> about managing your __appName__ emails.",
   "learn_more_about_link_sharing": "Learn more about Link Sharing",
   "learn_more_about_managed_users": "Learn more about Managed Users.",
-  "learn_more_about_managing_email": "Learn more about managing your __appName__ emails.",
   "learn_more_about_other_causes_of_compile_timeouts": "<0>Learn more</0> about other causes of compile timeouts and how to fix them.",
   "leave": "Leave",
   "leave_any_group_subscriptions": "Leave any group subscriptions other than the one that will be managing your account. <0>Leave them from the Subscription page.</0>",
@@ -1511,7 +1511,6 @@
   "other_output_files": "Download other output files",
   "other_sessions": "Other Sessions",
   "other_ways_to_log_in": "Other ways to log in",
-  "our_help_page": "Our help page",
   "our_team_will_get_back_to_you_shortly": "Our team will get back to you shortly.",
   "our_values": "Our values",
   "out_of_sync": "Out of sync",

services/web/test/frontend/features/settings/components/emails/emails-section.test.tsx

@@ -40,7 +40,9 @@ describe('<EmailsSection />', function () {
 
     screen.getByText(/add additional email addresses/i)
     screen.getByText(/to change your primary email/i)
-    screen.getByLabelText('Learn more about managing your Overleaf emails.')
+    screen.getByRole('link', {
+      name: /learn more about managing your Overleaf emails/i,
+    })
   })
 
   it('renders a loading message when loading', async function () {