Просмотр исходного кода

Filter out read-only users from TC users list.

Paulo Reis 9 лет назад
Родитель
Сommit
e421b6550a

+ 1 - 1
services/web/app/views/project/editor/review-panel.pug

@@ -77,7 +77,7 @@
 					on-toggle="toggleTrackChangesForUser(isOn, project.owner._id);"
 					disabled="reviewPanel.trackChangesOnForEveryone || !project.features.trackChanges || !permissions.write"
 				)
-			li.rp-tc-state-item(ng-repeat="member in project.members")
+			li.rp-tc-state-item(ng-repeat="member in project.members | filter:{ privileges: 'readAndWrite' }")
 				span.rp-tc-state-item-name(
 					ng-class="{ 'rp-tc-state-item-name-disabled' : reviewPanel.trackChangesOnForEveryone}"
 					style="color: hsl({{ users[member._id].hue }}, 70%, 40%);"

+ 0 - 7
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee

@@ -613,13 +613,6 @@ define [
 					data.on_for[userId] = userState.value
 			data._csrf = window.csrfToken
 			$http.post "/project/#{$scope.project_id}/track_changes", data
-		
-		# setTrackChangesState = (state) ->
-		# 	if $scope.project.features.trackChanges
-		# 		applyClientTrackChangesStateToServer()
-		# 		event_tracking.sendMB "rp-trackchanges-toggle", { state }
-		# 	else
-		# 		$scope.openTrackChangesUpgradeModal()
 
 		applyTrackChangesStateToClient = (state) ->
 			if typeof state is "boolean"