Forráskód Böngészése

added null checks into email sender for from address

Henry Oswald 12 éve
szülő
commit
e433eca157

+ 5 - 1
services/web/app/coffee/Features/Email/EmailSender.coffee

@@ -4,6 +4,10 @@ Settings = require('settings-sharelatex')
 metrics = require("../../infrastructure/Metrics")
 metrics = require("../../infrastructure/Metrics")
 ses = require('node-ses')
 ses = require('node-ses')
 
 
+if Settings.email? and Settings.email.fromAddress?
+	defaultFromAddress = ""
+else 
+	defaultFromAddress = Settings.email.fromAddress
 
 
 if Settings.email?.ses? and Settings.email.ses?.key? and Settings.email.ses?.key != "" and Settings.email.ses?.secret? and Settings.email.ses?.secret != ""
 if Settings.email?.ses? and Settings.email.ses?.key? and Settings.email.ses?.key != "" and Settings.email.ses?.secret? and Settings.email.ses?.secret != ""
 	client = ses.createClient({ key: Settings.email.ses.key, secret: Settings.email.ses.secret });
 	client = ses.createClient({ key: Settings.email.ses.key, secret: Settings.email.ses.secret });
@@ -21,7 +25,7 @@ module.exports =
 		metrics.inc "email"
 		metrics.inc "email"
 		options = 
 		options = 
 			to: options.to
 			to: options.to
-			from: Settings.email.fromAddress
+			from: defaultFromAddress
 			subject: options.subject
 			subject: options.subject
 			message: options.html
 			message: options.html
 			replyTo: options.replyTo || Settings.email.replyToAddress
 			replyTo: options.replyTo || Settings.email.replyToAddress