Merge pull request #27742 from overleaf/rh-odc-rm-skip

Remove skip button from ODC form

GitOrigin-RevId: b3974e041ab7fa5f28c2d5eb5176510616d50127

services/web/frontend/extracted-translations.json

@@ -1618,7 +1618,6 @@
   "sign_up": "",
   "simple_search_mode": "",
   "single_sign_on_sso": "",
-  "skip": "",
   "something_not_right": "",
   "something_went_wrong": "",
   "something_went_wrong_canceling_your_subscription": "",

services/web/frontend/js/utils/meta.ts

@@ -245,7 +245,6 @@ export interface Meta {
   'ol-showTemplatesServerPro': boolean
   'ol-showUSGovBanner': boolean
   'ol-showUpgradePrompt': boolean
-  'ol-skipUrl': string
   'ol-splitTestInfo': { [name: string]: SplitTestInfo }
   'ol-splitTestName': string
   'ol-splitTestVariants': { [name: string]: string }

services/web/test/acceptance/src/ProjectInviteTests.mjs

@@ -5,7 +5,6 @@ import settings from '@overleaf/settings'
 import CollaboratorsEmailHandler from '../../../app/src/Features/Collaborators/CollaboratorsEmailHandler.mjs'
 import CollaboratorsInviteHelper from '../../../app/src/Features/Collaborators/CollaboratorsInviteHelper.js'
 import Features from '../../../app/src/infrastructure/Features.js'
-import cheerio from 'cheerio'
 import sinon from 'sinon'
 
 let generateTokenSpy
@@ -261,11 +260,6 @@ const expectRegistrationRedirectToInvite = (user, link, callback) => {
       user.request.get('/registration/onboarding', (err, response) => {
         if (err) return callback(err)
         expect(response.statusCode).to.equal(200)
-        const dom = cheerio.load(response.body)
-        const skipUrl = dom('meta[name="ol-skipUrl"]')[0].attribs.content
-        expect(new URL(skipUrl, settings.siteUrl).href).to.equal(
-          new URL(link, settings.siteUrl).href
-        )
         callback()
       })
     } else {