Просмотр исходного кода

Amend per several review comments

- Removed unused vars
- Label the metric with the bucket name
Michael Mazour 8 лет назад
Родитель
Сommit
ece650741a
1 измененных файлов с 1 добавлено и 7 удалено
  1. 1 7
      services/filestore/app/coffee/BucketController.coffee

+ 1 - 7
services/filestore/app/coffee/BucketController.coffee

@@ -1,14 +1,9 @@
-PersistorManager = require("./PersistorManager")
 settings = require("settings-sharelatex")
 settings = require("settings-sharelatex")
 logger = require("logger-sharelatex")
 logger = require("logger-sharelatex")
 FileHandler = require("./FileHandler")
 FileHandler = require("./FileHandler")
 metrics = require("metrics-sharelatex")
 metrics = require("metrics-sharelatex")
-parseRange = require('range-parser')
 Errors = require('./Errors')
 Errors = require('./Errors')
 
 
-oneDayInSeconds = 60 * 60 * 24
-maxSizeInBytes = 1024 * 1024 * 1024 # 1GB
-
 module.exports = BucketController =
 module.exports = BucketController =
 
 
 	getFile: (req, res)->
 	getFile: (req, res)->
@@ -21,7 +16,7 @@ module.exports = BucketController =
 			bucket: bucket,
 			bucket: bucket,
 			credentials: credentials
 			credentials: credentials
 		}
 		}
-		metrics.inc "getFile"
+		metrics.inc "#{bucket}.getFile"
 		logger.log key:key, bucket:bucket, "receiving request to get file from bucket"
 		logger.log key:key, bucket:bucket, "receiving request to get file from bucket"
 		FileHandler.getFile bucket, key, options, (err, fileStream)->
 		FileHandler.getFile bucket, key, options, (err, fileStream)->
 			if err?
 			if err?
@@ -33,4 +28,3 @@ module.exports = BucketController =
 			else
 			else
 				logger.log key:key, bucket:bucket, format:format, style:style, "sending bucket file to response"
 				logger.log key:key, bucket:bucket, format:format, style:style, "sending bucket file to response"
 				fileStream.pipe res
 				fileStream.pipe res
-