Просмотр исходного кода

Don't allow project names to be blank

James Allen 10 лет назад
Родитель
Сommit
f21aa0dd94

+ 5 - 3
services/web/public/coffee/ide/settings/controllers/ProjectNameController.coffee

@@ -1,6 +1,7 @@
 define [
 	"base"
 ], (App) ->
+	MAX_PROJECT_NAME_LENGTH = 150
 	App.controller "ProjectNameController", ["$scope", "settings", "ide", ($scope, settings, ide) ->
 		$scope.state =
 			renaming: false
@@ -12,11 +13,12 @@ define [
 			$scope.$emit "project:rename:start"
 
 		$scope.finishRenaming = () ->
+			$scope.state.renaming = false
 			newName = $scope.inputs.name
-			if newName.length < 150
-				$scope.project.name = newName
+			if !newName? or newName.length == 0 or newName.length > MAX_PROJECT_NAME_LENGTH
+				return
+			$scope.project.name = newName
 			settings.saveProjectSettings({name: $scope.project.name})
-			$scope.state.renaming = false
 
 		ide.socket.on "projectNameUpdated", (name) ->
 			$scope.$apply () ->

+ 4 - 2
services/web/public/coffee/main/project-list/project-list.coffee

@@ -257,9 +257,11 @@ define [
 			modalInstance.result.then (project_id) ->
 				window.location = "/project/#{project_id}"
 
+		MAX_PROJECT_NAME_LENGTH = 150
 		$scope.renameProject = (project, newName) ->
-			if newName.length < 150
-				project.name = newName
+			if !newName? or newName.length == 0 or newName.length > MAX_PROJECT_NAME_LENGTH
+				return
+			project.name = newName
 			queuedHttp.post "/project/#{project.id}/rename", {
 				newProjectName: project.name
 				_csrf: window.csrfToken