Просмотр исходного кода

Decaf cleanup: remove default callbacks

Eric Mc Sween 6 лет назад
Родитель
Сommit
f2c67b66fa
1 измененных файлов с 0 добавлено и 24 удалено
  1. 0 24
      services/document-updater/app/js/ProjectManager.js

+ 0 - 24
services/document-updater/app/js/ProjectManager.js

@@ -22,9 +22,6 @@ const Errors = require('./Errors')
 
 
 module.exports = ProjectManager = {
 module.exports = ProjectManager = {
   flushProjectWithLocks(project_id, _callback) {
   flushProjectWithLocks(project_id, _callback) {
-    if (_callback == null) {
-      _callback = function (error) {}
-    }
     const timer = new Metrics.Timer('projectManager.flushProjectWithLocks')
     const timer = new Metrics.Timer('projectManager.flushProjectWithLocks')
     const callback = function (...args) {
     const callback = function (...args) {
       timer.done()
       timer.done()
@@ -77,9 +74,6 @@ module.exports = ProjectManager = {
   },
   },
 
 
   flushAndDeleteProjectWithLocks(project_id, options, _callback) {
   flushAndDeleteProjectWithLocks(project_id, options, _callback) {
-    if (_callback == null) {
-      _callback = function (error) {}
-    }
     const timer = new Metrics.Timer(
     const timer = new Metrics.Timer(
       'projectManager.flushAndDeleteProjectWithLocks'
       'projectManager.flushAndDeleteProjectWithLocks'
     )
     )
@@ -137,9 +131,6 @@ module.exports = ProjectManager = {
   },
   },
 
 
   queueFlushAndDeleteProject(project_id, callback) {
   queueFlushAndDeleteProject(project_id, callback) {
-    if (callback == null) {
-      callback = function (error) {}
-    }
     RedisManager.queueFlushAndDeleteProject(project_id, function (error) {
     RedisManager.queueFlushAndDeleteProject(project_id, function (error) {
       if (error != null) {
       if (error != null) {
         logger.error(
         logger.error(
@@ -154,9 +145,6 @@ module.exports = ProjectManager = {
   },
   },
 
 
   getProjectDocsTimestamps(project_id, callback) {
   getProjectDocsTimestamps(project_id, callback) {
-    if (callback == null) {
-      callback = function (error) {}
-    }
     RedisManager.getDocIdsInProject(project_id, function (error, doc_ids) {
     RedisManager.getDocIdsInProject(project_id, function (error, doc_ids) {
       if (error != null) {
       if (error != null) {
         return callback(error)
         return callback(error)
@@ -179,12 +167,6 @@ module.exports = ProjectManager = {
     excludeVersions,
     excludeVersions,
     _callback
     _callback
   ) {
   ) {
-    if (excludeVersions == null) {
-      excludeVersions = {}
-    }
-    if (_callback == null) {
-      _callback = function (error, docs) {}
-    }
     const timer = new Metrics.Timer(
     const timer = new Metrics.Timer(
       'projectManager.getProjectDocsAndFlushIfOld'
       'projectManager.getProjectDocsAndFlushIfOld'
     )
     )
@@ -253,9 +235,6 @@ module.exports = ProjectManager = {
   },
   },
 
 
   clearProjectState(project_id, callback) {
   clearProjectState(project_id, callback) {
-    if (callback == null) {
-      callback = function (error) {}
-    }
     RedisManager.clearProjectState(project_id, callback)
     RedisManager.clearProjectState(project_id, callback)
   },
   },
 
 
@@ -268,9 +247,6 @@ module.exports = ProjectManager = {
     version,
     version,
     _callback
     _callback
   ) {
   ) {
-    if (_callback == null) {
-      _callback = function (error) {}
-    }
     const timer = new Metrics.Timer('projectManager.updateProject')
     const timer = new Metrics.Timer('projectManager.updateProject')
     const callback = function (...args) {
     const callback = function (...args) {
       timer.done()
       timer.done()