Procházet zdrojové kódy

Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115

[web] Use getAttribute rather than accessing Element.role

GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
Jessica Lawshe před 2 roky
rodič
revize
f5ac5b0ed3

+ 2 - 2
services/web/frontend/js/features/source-editor/extensions/spelling/context-menu.ts

@@ -189,7 +189,7 @@ const createSpellingSuggestionList = (word: Word, view: EditorView) => {
 
         // get next option
         let nextElement = selectedButton.parentElement?.nextElementSibling
-        if (nextElement?.role !== 'option') {
+        if (nextElement?.getAttribute('role') !== 'option') {
           nextElement = nextElement?.nextElementSibling
         }
         nextElement?.querySelector('button')?.focus()
@@ -211,7 +211,7 @@ const createSpellingSuggestionList = (word: Word, view: EditorView) => {
         // get previous option
         let previousElement =
           selectedButton.parentElement?.previousElementSibling
-        if (previousElement?.role !== 'option') {
+        if (previousElement?.getAttribute('role') !== 'option') {
           previousElement = previousElement?.previousElementSibling
         }
         previousElement?.querySelector('button')?.focus()