Merge pull request #730 from sharelatex/sk-handle-orphaned-mendeley-linked-files

Add a new error type to LinkedFiles: FileCannotRefreshError

services/web/app/coffee/Features/LinkedFiles/LinkedFilesController.coffee

@@ -17,7 +17,8 @@ LinkedFilesHandler = require './LinkedFilesHandler'
 	SourceFileNotFoundError,
 	NotOriginalImporterError,
 	FeatureNotAvailableError,
-	RemoteServiceError
+	RemoteServiceError,
+	FileCannotRefreshError
 } = require './LinkedFilesErrors'
 Modules = require '../../infrastructure/Modules'
 
@@ -138,6 +139,10 @@ module.exports = LinkedFilesController = {
 				"The remote service produced an error"
 			)
 
+		else if error instanceof FileCannotRefreshError
+			res.status(400).send(
+				"This file cannot be refreshed"
+			)
 
 		else
 			next(error)

services/web/app/coffee/Features/LinkedFiles/LinkedFilesErrors.coffee

@@ -94,6 +94,14 @@ RemoteServiceError = (message) ->
 RemoteServiceError.prototype.__proto__ = Error.prototype
 
 
+FileCannotRefreshError = (message) ->
+	error = new Error(message)
+	error.name = 'RemoteService'
+	error.__proto__ = FileCannotRefreshError.prototype
+	return error
+FileCannotRefreshError.prototype.__proto__ = Error.prototype
+
+
 module.exports = {
 
 	UrlFetchFailedError,
@@ -107,5 +115,6 @@ module.exports = {
 	SourceFileNotFoundError,
 	NotOriginalImporterError,
 	FeatureNotAvailableError,
-	RemoteServiceError
+	RemoteServiceError,
+	FileCannotRefreshError
 }