Просмотр исходного кода

Remove old unused track changes notice

Alasdair Smith 9 лет назад
Родитель
Сommit
f85880ba38

+ 1 - 21
services/web/app/coffee/Features/Project/ProjectController.coffee

@@ -234,25 +234,6 @@ module.exports = ProjectController =
 				#don't need to wait for this to complete
 				ProjectUpdateHandler.markAsOpened project_id, ->
 				cb()
-			showPerUserTCNotice: (cb) ->
-				cb = underscore.once(cb)
-				if !user_id?
-					return cb()
-				timestamp = user_id.toString().substring(0,8)
-				userSignupDate = new Date( parseInt( timestamp, 16 ) * 1000 )
-				if userSignupDate > new Date("2017-08-09")
-					# Don't show for users who registered after it was released
-					return cb(null, false)
-				timeout = setTimeout cb, 500
-				AnalyticsManager.getLastOccurance user_id, "shown-per-user-tc-notice", (error, event) ->
-					clearTimeout timeout
-					if error?
-						return cb(null, false)
-					else if event?
-						return cb(null, false)
-					else
-						logger.log { user_id, event }, "per user track changes notice not shown yet to this user"
-						return cb(null, true)
 			isTokenMember: (cb) ->
 				cb = underscore.once(cb)
 				if !user_id?
@@ -312,7 +293,7 @@ module.exports = ProjectController =
 			project = results.project
 			user = results.user
 			subscription = results.subscription
-			{ showPerUserTCNotice, showAutoCompileOnboarding } = results
+			{ showAutoCompileOnboarding } = results
 
 			daysSinceLastUpdated =  (new Date() - project.lastUpdated) / 86400000
 			logger.log project_id:project_id, daysSinceLastUpdated:daysSinceLastUpdated, "got db results for loading editor"
@@ -364,7 +345,6 @@ module.exports = ProjectController =
 						syntaxValidation: user.ace.syntaxValidation
 					}
 					trackChangesState: project.track_changes
-					showPerUserTCNotice: !!showPerUserTCNotice
 					autoCompileEnabled: !!showAutoCompileOnboarding?.enabled
 					showAutoCompileOnboarding: !!showAutoCompileOnboarding?.showOnboarding
 					privilegeLevel: privilegeLevel

+ 0 - 1
services/web/app/views/project/editor.pug

@@ -120,7 +120,6 @@ block requirejs
 		window.isTokenMember = #{!!isTokenMember};
 		window.maxDocLength = #{maxDocLength};
 		window.trackChangesState = data.trackChangesState;
-		window.showPerUserTCNotice = #{!!showPerUserTCNotice};
 		window.autoCompileEnabled = #{!!autoCompileEnabled};
 		window.showAutoCompileOnboarding = #{!!showAutoCompileOnboarding}
 		window.showLinkSharingOnboarding = #{!!showLinkSharingOnboarding}

+ 0 - 11
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee

@@ -43,7 +43,6 @@ define [
 			# A count of user-facing selected changes. An aggregated change (insertion + deletion) will count
 			# as only one.
 			nVisibleSelectedChanges: 0
-			showPerUserTCNotice: window.showPerUserTCNotice
 
 		window.addEventListener "beforeunload", () ->
 			collapsedStates = {}
@@ -598,8 +597,6 @@ define [
 
 		$scope.toggleFullTCStateCollapse = () ->
 			if $scope.project.features.trackChanges
-				if $scope.reviewPanel.showPerUserTCNotice
-					$scope.openPerUserTCNoticeModal()
 				$scope.reviewPanel.fullTCStateCollapsed = !$scope.reviewPanel.fullTCStateCollapsed
 			else
 				$scope.openTrackChangesUpgradeModal()
@@ -802,11 +799,3 @@ define [
 				controller: "TrackChangesUpgradeModalController"
 				scope: $scope.$new()
 			}
-
-		$scope.openPerUserTCNoticeModal = () ->
-			$scope.reviewPanel.showPerUserTCNotice = false
-			$modal.open({
-				templateUrl: "perUserTCNoticeModalTemplate"
-			}).result.finally () ->
-				event_tracking.sendMB "shown-per-user-tc-notice"
-