UserSessionsManagerTests.coffee 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576
  1. sinon = require('sinon')
  2. chai = require('chai')
  3. should = chai.should()
  4. expect = chai.expect
  5. modulePath = "../../../../app/js/Features/User/UserSessionsManager.js"
  6. SandboxedModule = require('sandboxed-module')
  7. Async = require('async')
  8. describe 'UserSessionsManager', ->
  9. beforeEach ->
  10. @user =
  11. _id: "abcd"
  12. email: "user@example.com"
  13. @sessionId = 'some_session_id'
  14. @rclient =
  15. multi: sinon.stub()
  16. exec: sinon.stub()
  17. get: sinon.stub()
  18. del: sinon.stub()
  19. sadd: sinon.stub()
  20. srem: sinon.stub()
  21. smembers: sinon.stub()
  22. mget: sinon.stub()
  23. expire: sinon.stub()
  24. @rclient.multi.returns(@rclient)
  25. @rclient.get.returns(@rclient)
  26. @rclient.del.returns(@rclient)
  27. @rclient.sadd.returns(@rclient)
  28. @rclient.srem.returns(@rclient)
  29. @rclient.smembers.returns(@rclient)
  30. @rclient.expire.returns(@rclient)
  31. @rclient.exec.callsArgWith(0, null)
  32. @UserSessionsRedis =
  33. client: () => @rclient
  34. sessionSetKey: (user) => "UserSessions:{#{user._id}}"
  35. @logger =
  36. err: sinon.stub()
  37. error: sinon.stub()
  38. log: sinon.stub()
  39. @settings =
  40. redis:
  41. web: {}
  42. @UserSessionsManager = SandboxedModule.require modulePath, requires:
  43. "logger-sharelatex": @logger
  44. "settings-sharelatex": @settings
  45. './UserSessionsRedis': @UserSessionsRedis
  46. 'async': Async
  47. describe '_sessionKey', ->
  48. it 'should build the correct key', ->
  49. result = @UserSessionsManager._sessionKey(@sessionId)
  50. result.should.equal 'sess:some_session_id'
  51. describe 'trackSession', ->
  52. beforeEach ->
  53. @call = (callback) =>
  54. @UserSessionsManager.trackSession @user, @sessionId, callback
  55. @rclient.exec.callsArgWith(0, null)
  56. @_checkSessions = sinon.stub(@UserSessionsManager, '_checkSessions').returns(null)
  57. afterEach ->
  58. @_checkSessions.restore()
  59. it 'should not produce an error', (done) ->
  60. @call (err) =>
  61. expect(err).to.not.be.instanceof Error
  62. done()
  63. it 'should call the appropriate redis methods', (done) ->
  64. @call (err) =>
  65. @rclient.multi.callCount.should.equal 1
  66. @rclient.sadd.callCount.should.equal 1
  67. @rclient.expire.callCount.should.equal 1
  68. @rclient.exec.callCount.should.equal 1
  69. done()
  70. it 'should call _checkSessions', (done) ->
  71. @call (err) =>
  72. @_checkSessions.callCount.should.equal 1
  73. done()
  74. describe 'when rclient produces an error', ->
  75. beforeEach ->
  76. @rclient.exec.callsArgWith(0, new Error('woops'))
  77. it 'should produce an error', (done) ->
  78. @call (err) =>
  79. expect(err).to.be.instanceof Error
  80. done()
  81. it 'should not call _checkSessions', (done) ->
  82. @call (err) =>
  83. @_checkSessions.callCount.should.equal 0
  84. done()
  85. describe 'when no user is supplied', ->
  86. beforeEach ->
  87. @call = (callback) =>
  88. @UserSessionsManager.trackSession null, @sessionId, callback
  89. it 'should not produce an error', (done) ->
  90. @call (err) =>
  91. expect(err).to.not.be.instanceof Error
  92. expect(err).to.equal null
  93. done()
  94. it 'should not call the appropriate redis methods', (done) ->
  95. @call (err) =>
  96. @rclient.multi.callCount.should.equal 0
  97. @rclient.sadd.callCount.should.equal 0
  98. @rclient.expire.callCount.should.equal 0
  99. @rclient.exec.callCount.should.equal 0
  100. done()
  101. it 'should not call _checkSessions', (done) ->
  102. @call (err) =>
  103. @_checkSessions.callCount.should.equal 0
  104. done()
  105. describe 'when no sessionId is supplied', ->
  106. beforeEach ->
  107. @call = (callback) =>
  108. @UserSessionsManager.trackSession @user, null, callback
  109. it 'should not produce an error', (done) ->
  110. @call (err) =>
  111. expect(err).to.not.be.instanceof Error
  112. expect(err).to.equal null
  113. done()
  114. it 'should not call the appropriate redis methods', (done) ->
  115. @call (err) =>
  116. @rclient.multi.callCount.should.equal 0
  117. @rclient.sadd.callCount.should.equal 0
  118. @rclient.expire.callCount.should.equal 0
  119. @rclient.exec.callCount.should.equal 0
  120. done()
  121. it 'should not call _checkSessions', (done) ->
  122. @call (err) =>
  123. @_checkSessions.callCount.should.equal 0
  124. done()
  125. describe 'untrackSession', ->
  126. beforeEach ->
  127. @call = (callback) =>
  128. @UserSessionsManager.untrackSession @user, @sessionId, callback
  129. @rclient.exec.callsArgWith(0, null)
  130. @_checkSessions = sinon.stub(@UserSessionsManager, '_checkSessions').returns(null)
  131. afterEach ->
  132. @_checkSessions.restore()
  133. it 'should not produce an error', (done) ->
  134. @call (err) =>
  135. expect(err).to.not.be.instanceof Error
  136. expect(err).to.equal undefined
  137. done()
  138. it 'should call the appropriate redis methods', (done) ->
  139. @call (err) =>
  140. @rclient.multi.callCount.should.equal 1
  141. @rclient.srem.callCount.should.equal 1
  142. @rclient.expire.callCount.should.equal 1
  143. @rclient.exec.callCount.should.equal 1
  144. done()
  145. it 'should call _checkSessions', (done) ->
  146. @call (err) =>
  147. @_checkSessions.callCount.should.equal 1
  148. done()
  149. describe 'when rclient produces an error', ->
  150. beforeEach ->
  151. @rclient.exec.callsArgWith(0, new Error('woops'))
  152. it 'should produce an error', (done) ->
  153. @call (err) =>
  154. expect(err).to.be.instanceof Error
  155. done()
  156. it 'should not call _checkSessions', (done) ->
  157. @call (err) =>
  158. @_checkSessions.callCount.should.equal 0
  159. done()
  160. describe 'when no user is supplied', ->
  161. beforeEach ->
  162. @call = (callback) =>
  163. @UserSessionsManager.untrackSession null, @sessionId, callback
  164. it 'should not produce an error', (done) ->
  165. @call (err) =>
  166. expect(err).to.not.be.instanceof Error
  167. expect(err).to.equal null
  168. done()
  169. it 'should not call the appropriate redis methods', (done) ->
  170. @call (err) =>
  171. @rclient.multi.callCount.should.equal 0
  172. @rclient.srem.callCount.should.equal 0
  173. @rclient.expire.callCount.should.equal 0
  174. @rclient.exec.callCount.should.equal 0
  175. done()
  176. it 'should not call _checkSessions', (done) ->
  177. @call (err) =>
  178. @_checkSessions.callCount.should.equal 0
  179. done()
  180. describe 'when no sessionId is supplied', ->
  181. beforeEach ->
  182. @call = (callback) =>
  183. @UserSessionsManager.untrackSession @user, null, callback
  184. it 'should not produce an error', (done) ->
  185. @call (err) =>
  186. expect(err).to.not.be.instanceof Error
  187. expect(err).to.equal null
  188. done()
  189. it 'should not call the appropriate redis methods', (done) ->
  190. @call (err) =>
  191. @rclient.multi.callCount.should.equal 0
  192. @rclient.srem.callCount.should.equal 0
  193. @rclient.expire.callCount.should.equal 0
  194. @rclient.exec.callCount.should.equal 0
  195. done()
  196. it 'should not call _checkSessions', (done) ->
  197. @call (err) =>
  198. @_checkSessions.callCount.should.equal 0
  199. done()
  200. describe 'revokeAllUserSessions', ->
  201. beforeEach ->
  202. @sessionKeys = ['sess:one', 'sess:two']
  203. @retain = []
  204. @rclient.smembers.callsArgWith(1, null, @sessionKeys)
  205. @rclient.del = sinon.stub().callsArgWith(1, null)
  206. @rclient.srem = sinon.stub().callsArgWith(2, null)
  207. @call = (callback) =>
  208. @UserSessionsManager.revokeAllUserSessions @user, @retain, callback
  209. it 'should not produce an error', (done) ->
  210. @call (err) =>
  211. expect(err).to.not.be.instanceof Error
  212. expect(err).to.equal null
  213. done()
  214. it 'should call the appropriate redis methods', (done) ->
  215. @call (err) =>
  216. @rclient.smembers.callCount.should.equal 1
  217. @rclient.del.callCount.should.equal 2
  218. expect(@rclient.del.firstCall.args[0]).to.deep.equal @sessionKeys[0]
  219. expect(@rclient.del.secondCall.args[0]).to.deep.equal @sessionKeys[1]
  220. @rclient.srem.callCount.should.equal 1
  221. expect(@rclient.srem.firstCall.args[1]).to.deep.equal @sessionKeys
  222. done()
  223. describe 'when a session is retained', ->
  224. beforeEach ->
  225. @sessionKeys = ['sess:one', 'sess:two', 'sess:three', 'sess:four']
  226. @retain = ['two']
  227. @rclient.smembers.callsArgWith(1, null, @sessionKeys)
  228. @rclient.del = sinon.stub().callsArgWith(1, null)
  229. @call = (callback) =>
  230. @UserSessionsManager.revokeAllUserSessions @user, @retain, callback
  231. it 'should not produce an error', (done) ->
  232. @call (err) =>
  233. expect(err).to.not.be.instanceof Error
  234. expect(err).to.equal null
  235. done()
  236. it 'should call the appropriate redis methods', (done) ->
  237. @call (err) =>
  238. @rclient.smembers.callCount.should.equal 1
  239. @rclient.del.callCount.should.equal @sessionKeys.length - 1
  240. @rclient.srem.callCount.should.equal 1
  241. done()
  242. it 'should remove all sessions except for the retained one', (done) ->
  243. @call (err) =>
  244. expect(@rclient.del.firstCall.args[0]).to.deep.equal('sess:one')
  245. expect(@rclient.del.secondCall.args[0]).to.deep.equal('sess:three')
  246. expect(@rclient.del.thirdCall.args[0]).to.deep.equal('sess:four')
  247. expect(@rclient.srem.firstCall.args[1]).to.deep.equal(['sess:one', 'sess:three', 'sess:four'])
  248. done()
  249. describe 'when rclient produces an error', ->
  250. beforeEach ->
  251. @rclient.del = sinon.stub().callsArgWith(1, new Error('woops'))
  252. it 'should produce an error', (done) ->
  253. @call (err) =>
  254. expect(err).to.be.instanceof Error
  255. done()
  256. it 'should not call rclient.srem', (done) ->
  257. @call (err) =>
  258. @rclient.srem.callCount.should.equal 0
  259. done()
  260. describe 'when no user is supplied', ->
  261. beforeEach ->
  262. @call = (callback) =>
  263. @UserSessionsManager.revokeAllUserSessions null, @retain, callback
  264. it 'should not produce an error', (done) ->
  265. @call (err) =>
  266. expect(err).to.not.be.instanceof Error
  267. expect(err).to.equal null
  268. done()
  269. it 'should not call the appropriate redis methods', (done) ->
  270. @call (err) =>
  271. @rclient.smembers.callCount.should.equal 0
  272. @rclient.del.callCount.should.equal 0
  273. @rclient.srem.callCount.should.equal 0
  274. done()
  275. describe 'when there are no keys to delete', ->
  276. beforeEach ->
  277. @rclient.smembers.callsArgWith(1, null, [])
  278. it 'should not produce an error', (done) ->
  279. @call (err) =>
  280. expect(err).to.not.be.instanceof Error
  281. expect(err).to.equal null
  282. done()
  283. it 'should not do the delete operation', (done) ->
  284. @call (err) =>
  285. @rclient.smembers.callCount.should.equal 1
  286. @rclient.del.callCount.should.equal 0
  287. @rclient.srem.callCount.should.equal 0
  288. done()
  289. describe 'touch', ->
  290. beforeEach ->
  291. @rclient.expire.callsArgWith(2, null)
  292. @call = (callback) =>
  293. @UserSessionsManager.touch @user, callback
  294. it 'should not produce an error', (done) ->
  295. @call (err) =>
  296. expect(err).to.not.be.instanceof Error
  297. expect(err).to.equal null
  298. done()
  299. it 'should call rclient.expire', (done) ->
  300. @call (err) =>
  301. @rclient.expire.callCount.should.equal 1
  302. done()
  303. describe 'when rclient produces an error', ->
  304. beforeEach ->
  305. @rclient.expire.callsArgWith(2, new Error('woops'))
  306. it 'should produce an error', (done) ->
  307. @call (err) =>
  308. expect(err).to.be.instanceof Error
  309. done()
  310. describe 'when no user is supplied', ->
  311. beforeEach ->
  312. @call = (callback) =>
  313. @UserSessionsManager.touch null, callback
  314. it 'should not produce an error', (done) ->
  315. @call (err) =>
  316. expect(err).to.not.be.instanceof Error
  317. expect(err).to.equal null
  318. done()
  319. it 'should not call expire', (done) ->
  320. @call (err) =>
  321. @rclient.expire.callCount.should.equal 0
  322. done()
  323. describe 'getAllUserSessions', ->
  324. beforeEach ->
  325. @sessionKeys = ['sess:one', 'sess:two', 'sess:three']
  326. @sessions = [
  327. '{"user": {"ip_address": "a", "session_created": "b"}}',
  328. '{"passport": {"user": {"ip_address": "c", "session_created": "d"}}}'
  329. ]
  330. @exclude = ['two']
  331. @rclient.smembers.callsArgWith(1, null, @sessionKeys)
  332. @rclient.get = sinon.stub()
  333. @rclient.get.onCall(0).callsArgWith(1, null, @sessions[0])
  334. @rclient.get.onCall(1).callsArgWith(1, null, @sessions[1])
  335. @call = (callback) =>
  336. @UserSessionsManager.getAllUserSessions @user, @exclude, callback
  337. it 'should not produce an error', (done) ->
  338. @call (err, sessions) =>
  339. expect(err).to.equal null
  340. done()
  341. it 'should get sessions', (done) ->
  342. @call (err, sessions) =>
  343. expect(sessions).to.deep.equal [
  344. { ip_address: 'a', session_created: 'b' },
  345. { ip_address: 'c', session_created: 'd' }
  346. ]
  347. done()
  348. it 'should have called rclient.smembers', (done) ->
  349. @call (err, sessions) =>
  350. @rclient.smembers.callCount.should.equal 1
  351. done()
  352. it 'should have called rclient.get', (done) ->
  353. @call (err, sessions) =>
  354. @rclient.get.callCount.should.equal @sessionKeys.length - 1
  355. done()
  356. describe 'when there are no other sessions', ->
  357. beforeEach ->
  358. @sessionKeys = ['sess:two']
  359. @rclient.smembers.callsArgWith(1, null, @sessionKeys)
  360. it 'should not produce an error', (done) ->
  361. @call (err, sessions) =>
  362. expect(err).to.equal null
  363. done()
  364. it 'should produce an empty list of sessions', (done) ->
  365. @call (err, sessions) =>
  366. expect(sessions).to.deep.equal []
  367. done()
  368. it 'should have called rclient.smembers', (done) ->
  369. @call (err, sessions) =>
  370. @rclient.smembers.callCount.should.equal 1
  371. done()
  372. it 'should not have called rclient.mget', (done) ->
  373. @call (err, sessions) =>
  374. @rclient.mget.callCount.should.equal 0
  375. done()
  376. describe 'when smembers produces an error', ->
  377. beforeEach ->
  378. @rclient.smembers.callsArgWith(1, new Error('woops'))
  379. it 'should produce an error', (done) ->
  380. @call (err, sessions) =>
  381. expect(err).to.not.equal null
  382. expect(err).to.be.instanceof Error
  383. done()
  384. it 'should not have called rclient.mget', (done) ->
  385. @call (err, sessions) =>
  386. @rclient.mget.callCount.should.equal 0
  387. done()
  388. describe 'when get produces an error', ->
  389. beforeEach ->
  390. @rclient.get = sinon.stub().callsArgWith(1, new Error('woops'))
  391. it 'should produce an error', (done) ->
  392. @call (err, sessions) =>
  393. expect(err).to.not.equal null
  394. expect(err).to.be.instanceof Error
  395. done()
  396. describe '_checkSessions', ->
  397. beforeEach ->
  398. @call = (callback) =>
  399. @UserSessionsManager._checkSessions @user, callback
  400. @sessionKeys = ['one', 'two']
  401. @rclient.smembers.callsArgWith(1, null, @sessionKeys)
  402. @rclient.get.callsArgWith(1, null, 'some-value')
  403. @rclient.srem.callsArgWith(2, null, {})
  404. it 'should not produce an error', (done) ->
  405. @call (err) =>
  406. expect(err).to.not.be.instanceof Error
  407. expect(err).to.equal undefined
  408. done()
  409. it 'should call the appropriate redis methods', (done) ->
  410. @call (err) =>
  411. @rclient.smembers.callCount.should.equal 1
  412. @rclient.get.callCount.should.equal 2
  413. @rclient.srem.callCount.should.equal 0
  414. done()
  415. describe 'when one of the keys is not present in redis', ->
  416. beforeEach ->
  417. @rclient.get.onCall(0).callsArgWith(1, null, 'some-val')
  418. @rclient.get.onCall(1).callsArgWith(1, null, null)
  419. it 'should not produce an error', (done) ->
  420. @call (err) =>
  421. expect(err).to.not.be.instanceof Error
  422. expect(err).to.equal undefined
  423. done()
  424. it 'should remove that key from the set', (done) ->
  425. @call (err) =>
  426. @rclient.smembers.callCount.should.equal 1
  427. @rclient.get.callCount.should.equal 2
  428. @rclient.srem.callCount.should.equal 1
  429. @rclient.srem.firstCall.args[1].should.equal 'two'
  430. done()
  431. describe 'when no user is supplied', ->
  432. beforeEach ->
  433. @call = (callback) =>
  434. @UserSessionsManager._checkSessions null, callback
  435. it 'should not produce an error', (done) ->
  436. @call (err) =>
  437. expect(err).to.not.be.instanceof Error
  438. expect(err).to.equal null
  439. done()
  440. it 'should not call redis methods', (done) ->
  441. @call (err) =>
  442. @rclient.smembers.callCount.should.equal 0
  443. @rclient.get.callCount.should.equal 0
  444. done()
  445. describe 'when one of the get operations produces an error', ->
  446. beforeEach ->
  447. @rclient.get.onCall(0).callsArgWith(1, new Error('woops'), null)
  448. @rclient.get.onCall(1).callsArgWith(1, null, null)
  449. it 'should produce an error', (done) ->
  450. @call (err) =>
  451. expect(err).to.be.instanceof Error
  452. done()
  453. it 'should call the right redis methods, bailing out early', (done) ->
  454. @call (err) =>
  455. @rclient.smembers.callCount.should.equal 1
  456. @rclient.get.callCount.should.equal 1
  457. @rclient.srem.callCount.should.equal 0
  458. done()