| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543 |
- import async from 'async'
- import nock from 'nock'
- import { expect } from 'chai'
- import request from 'request'
- import assert from 'node:assert'
- import mongodb from 'mongodb-legacy'
- import logger from '@overleaf/logger'
- import Settings from '@overleaf/settings'
- import * as ProjectHistoryClient from './helpers/ProjectHistoryClient.js'
- import * as ProjectHistoryApp from './helpers/ProjectHistoryApp.js'
- import sinon from 'sinon'
- import { getFailure } from './helpers/ProjectHistoryClient.js'
- const { ObjectId } = mongodb
- const EMPTY_FILE_HASH = 'e69de29bb2d1d6434b8b29ae775ad8c2e48c5391'
- const MockHistoryStore = () => nock('http://127.0.0.1:3100')
- const MockFileStore = () => nock('http://127.0.0.1:3009')
- const MockWeb = () => nock('http://127.0.0.1:3000')
- describe('Syncing with web and doc-updater', function () {
- const historyId = new ObjectId().toString()
- let loggerWarn, loggerError
- beforeEach(function () {
- loggerWarn = sinon.spy(logger, 'warn')
- loggerError = sinon.spy(logger, 'error')
- })
- afterEach(function () {
- loggerWarn.restore()
- loggerError.restore()
- })
- beforeEach(function (done) {
- this.timestamp = new Date()
- ProjectHistoryApp.ensureRunning(error => {
- if (error) {
- throw error
- }
- this.project_id = new ObjectId().toString()
- this.doc_id = new ObjectId().toString()
- this.file_id = new ObjectId().toString()
- MockHistoryStore().post('/api/projects').reply(200, {
- projectId: historyId,
- })
- MockWeb()
- .get(`/project/${this.project_id}/details`)
- .reply(200, {
- name: 'Test Project',
- overleaf: {
- history: {
- id: historyId,
- },
- },
- })
- ProjectHistoryClient.initializeProject(historyId, done)
- })
- })
- afterEach(function () {
- nock.cleanAll()
- })
- describe('resyncing project history', function () {
- describe('without project-history enabled', function () {
- beforeEach(function () {
- MockWeb().post(`/project/${this.project_id}/history/resync`).reply(404)
- })
- it('404s if project-history is not enabled', function (done) {
- request.post(
- {
- url: `http://127.0.0.1:3054/project/${this.project_id}/resync`,
- },
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- expect(res.statusCode).to.equal(404)
- done()
- }
- )
- })
- })
- describe('with project-history enabled', function () {
- beforeEach(function () {
- MockWeb().post(`/project/${this.project_id}/history/resync`).reply(204)
- })
- describe('when a doc is missing', function () {
- it('should send add doc updates to the history store', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedDoc: { hash: EMPTY_FILE_HASH, stringLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- MockHistoryStore()
- .get(`/api/projects/${historyId}/blobs/${EMPTY_FILE_HASH}`)
- .reply(200, '')
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${EMPTY_FILE_HASH}`, '')
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'main.tex',
- file: {
- hash: EMPTY_FILE_HASH,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [
- { path: '/main.tex', doc: this.doc_id },
- { path: '/persistedDoc', doc: 'other-doc-id' },
- ],
- files: [],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- return done(error)
- }
- assert(
- createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- })
- describe('when a file is missing', function () {
- it('should send add file updates to the history store', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(404)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- url: `http://127.0.0.1:3009/project/${this.project_id}/file/${this.file_id}`,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!loggerWarn.called, 'no warning logged on 404')
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- it('should skip HEAD on blob without hash', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/undefined`)
- .reply(500)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- url: `http://127.0.0.1:3009/project/${this.project_id}/file/${this.file_id}`,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!loggerWarn.called, 'no warning logged on 404')
- assert(
- !headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- it('should record error when checking blob fails with 500', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(500)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- url: `http://127.0.0.1:3009/project/${this.project_id}/file/${this.file_id}`,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(
- this.project_id,
- {
- allowErrors: true,
- },
- (err, res) => {
- if (err) return cb(err)
- assert(res.statusCode === 500, 'resync should have failed')
- cb()
- }
- )
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- loggerError.calledWithMatch(
- sinon.match.any,
- 'error checking whether blob exists'
- ),
- 'error logged on 500'
- )
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- !createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- !addFile.isDone(),
- `/api/projects/${historyId}/changes should have been skipped`
- )
- done()
- }
- )
- })
- it('should skip blob write when blob exists', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(200)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- url: `http://127.0.0.1:3009/project/${this.project_id}/file/${this.file_id}`,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!loggerWarn.called, 'no warning logged on 404')
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- !createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- it('should add file w/o url', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(200)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- createdBlob: true,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!loggerWarn.called, 'no warning logged on 404')
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- !createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- describe('with filestore disabled', function () {
- before(function () {
- Settings.apis.filestore.enabled = false
- })
- after(function () {
- Settings.apis.filestore.enabled = true
- })
- it('should record error when blob is missing', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- persistedFile: { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .times(3) // three retries
- .reply(404)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- url: `http://127.0.0.1:3009/project/${this.project_id}/file/${this.file_id}`,
- },
- { path: '/persistedFile' },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(
- this.project_id,
- update,
- cb
- )
- },
- cb => {
- ProjectHistoryClient.flushProject(
- this.project_id,
- {
- allowErrors: true,
- },
- (err, res) => {
- if (err) return cb(err)
- assert(
- res.statusCode === 500,
- 'resync should have failed'
- )
- cb()
- }
- )
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- loggerError.calledWithMatch(
- sinon.match.any,
- 'blocking filestore read'
- ),
- 'error logged on 500'
- )
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- !createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- !addFile.isDone(),
- `/api/projects/${historyId}/changes should have been skipped`
- )
- done()
- }
- )
- })
- })
- })
- describe('when a file hash mismatches', function () {
- it('should remove and re-add file w/o url', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- 'test.png': { hash: EMPTY_FILE_HASH, byteLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const fileContents = Buffer.from([1, 2, 3])
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockFileStore()
- .get(`/project/${this.project_id}/file/${this.file_id}`)
- .reply(200, fileContents)
- const headBlob = MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(200)
- const createBlob = MockHistoryStore()
- .put(`/api/projects/${historyId}/blobs/${fileHash}`, fileContents)
- .reply(201)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- newPathname: '',
- },
- ],
- origin: { kind: 'test-origin' },
- },
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- createdBlob: true,
- },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!loggerWarn.called, 'no warning logged on 404')
- assert(
- headBlob.isDone(),
- 'HEAD /api/projects/:historyId/blobs/:hash should have been called'
- )
- assert(
- !createBlob.isDone(),
- '/api/projects/:historyId/blobs/:hash should have been skipped'
- )
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- })
- describe("when a file exists which shouldn't", function () {
- it('should send remove file updates to the history store', function (done) {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- docToKeep: { hash: EMPTY_FILE_HASH, stringLength: 0 },
- docToDelete: { hash: EMPTY_FILE_HASH, stringLength: 0 },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- MockHistoryStore()
- .get(`/api/projects/${historyId}/blobs/${EMPTY_FILE_HASH}`)
- .reply(200, '')
- .get(`/api/projects/${historyId}/blobs/${EMPTY_FILE_HASH}`)
- .reply(200, '') // blob is requested once for each file
- const deleteFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'docToDelete',
- newPathname: '',
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [{ path: 'docToKeep' }],
- files: [],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- deleteFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- })
- describe("when a doc's contents is not up to date", function () {
- beforeEach(function () {
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- 'main.tex': {
- hash: '0a207c060e61f3b88eaee0a8cd0696f46fb155eb',
- stringLength: 3,
- },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- MockHistoryStore()
- .get(
- `/api/projects/${historyId}/blobs/0a207c060e61f3b88eaee0a8cd0696f46fb155eb`
- )
- .reply(200, 'a\nb')
- })
- it('should send test updates to the history store', function (done) {
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'main.tex',
- textOperation: [3, '\nc'],
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [{ path: '/main.tex' }],
- files: [],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- const update = {
- path: '/main.tex',
- projectHistoryId: historyId,
- resyncDocContent: {
- content: 'a\nb\nc',
- },
- doc: this.doc_id,
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- it('should strip non-BMP characters in updates before sending to the history store', function (done) {
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'main.tex',
- textOperation: [3, '\n\uFFFD\uFFFDc'],
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [{ path: '/main.tex' }],
- files: [],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- const update = {
- path: '/main.tex',
- projectHistoryId: historyId,
- resyncDocContent: {
- content: 'a\nb\n\uD800\uDC00c',
- },
- doc: this.doc_id,
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- it('should fix comments in the history store', function (done) {
- const commentId = 'comment-id'
- const addComment = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'main.tex',
- commentId,
- ranges: [{ pos: 1, length: 10 }],
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructure: {
- docs: [{ path: '/main.tex' }],
- files: [],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- const update = {
- path: '/main.tex',
- projectHistoryId: historyId,
- resyncDocContent: {
- content: 'a\nb',
- ranges: {
- comments: [
- {
- id: commentId,
- op: {
- c: 'a',
- p: 0,
- hpos: 1,
- hlen: 10,
- t: commentId,
- },
- meta: {
- user_id: 'user-id',
- ts: this.timestamp,
- },
- },
- ],
- },
- },
- doc: this.doc_id,
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- return done(error)
- }
- assert(
- addComment.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- done()
- }
- )
- })
- })
- describe('resyncProjectStructureOnly', function () {
- it('should handle structure only updates', function (done) {
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- 'main.tex': {
- hash: '0a207c060e61f3b88eaee0a8cd0696f46fb155eb',
- stringLength: 3,
- },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const docContentRequest = MockHistoryStore()
- .get(
- `/api/projects/${historyId}/blobs/0a207c060e61f3b88eaee0a8cd0696f46fb155eb`
- )
- .reply(200, 'a\nb')
- MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(200)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`, body => {
- expect(body).to.deep.equal([
- {
- v2Authors: [],
- authors: [],
- timestamp: this.timestamp.toJSON(),
- operations: [
- {
- pathname: 'test.png',
- file: {
- hash: fileHash,
- },
- },
- ],
- origin: { kind: 'test-origin' },
- },
- ])
- return true
- })
- .query({ end_version: 0 })
- .reply(204)
- // allow a 2nd resync
- MockWeb()
- .post(`/project/${this.project_id}/history/resync`)
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructureOnly: true,
- resyncProjectStructure: {
- docs: [{ path: '/main.tex' }],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- createdBlob: true,
- },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(this.project_id, cb)
- },
- cb => {
- // fails when previous resync did not finish
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(
- addFile.isDone(),
- `/api/projects/${historyId}/changes should have been called`
- )
- assert(
- !docContentRequest.isDone(),
- 'should not have requested doc content'
- )
- done()
- }
- )
- })
- it('should reject partial resync on docs', function (done) {
- const fileHash = 'aed2973e4b8a7ff1b30ff5c4751e5a2b38989e74'
- MockHistoryStore()
- .get(`/api/projects/${historyId}/latest/history`)
- .reply(200, {
- chunk: {
- history: {
- snapshot: {
- files: {
- 'main.tex': {
- hash: '0a207c060e61f3b88eaee0a8cd0696f46fb155eb',
- stringLength: 3,
- },
- },
- },
- changes: [],
- },
- startVersion: 0,
- },
- })
- const docContentRequest = MockHistoryStore()
- .get(
- `/api/projects/${historyId}/blobs/0a207c060e61f3b88eaee0a8cd0696f46fb155eb`
- )
- .reply(200, 'a\nb')
- MockHistoryStore()
- .head(`/api/projects/${historyId}/blobs/${fileHash}`)
- .reply(200)
- const addFile = MockHistoryStore()
- .post(`/api/projects/${historyId}/legacy_changes`)
- .query({ end_version: 0 })
- .reply(204)
- // allow a 2nd resync
- MockWeb()
- .post(`/project/${this.project_id}/history/resync`)
- .reply(204)
- async.series(
- [
- cb => {
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- cb => {
- const update = {
- projectHistoryId: historyId,
- resyncProjectStructureOnly: true,
- resyncProjectStructure: {
- docs: [{ path: '/main-renamed.tex' }],
- files: [
- {
- file: this.file_id,
- path: '/test.png',
- _hash: fileHash,
- createdBlob: true,
- },
- ],
- },
- meta: {
- ts: this.timestamp,
- },
- }
- ProjectHistoryClient.pushRawUpdate(this.project_id, update, cb)
- },
- cb => {
- ProjectHistoryClient.flushProject(
- this.project_id,
- { allowErrors: true },
- (err, res) => {
- if (err) return cb(err)
- expect(res.statusCode).to.equal(500)
- expect(loggerError).to.have.been.calledWith(
- sinon.match({
- err: {
- name: 'NeedFullProjectStructureResyncError',
- message: 'aborting partial resync: touched doc',
- },
- })
- )
- getFailure(this.project_id, (err, failure) => {
- if (err) return cb(err)
- expect(failure).to.include({
- error:
- 'NeedFullProjectStructureResyncError: aborting partial resync: touched doc',
- })
- cb()
- })
- }
- )
- },
- cb => {
- // fails when previous resync did not finish
- ProjectHistoryClient.resyncHistory(this.project_id, cb)
- },
- ],
- error => {
- if (error) {
- throw error
- }
- assert(!addFile.isDone(), 'should not have persisted changes')
- assert(
- !docContentRequest.isDone(),
- 'should not have requested doc content'
- )
- done()
- }
- )
- })
- })
- })
- })
- })
|