| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365 |
- const sinon = require('sinon')
- const { expect } = require('chai')
- const modulePath = '../../../../app/js/DocumentManager.js'
- const SandboxedModule = require('sandboxed-module')
- const Errors = require('../../../../app/js/Errors')
- const tk = require('timekeeper')
- describe('DocumentManager', function () {
- beforeEach(function () {
- tk.freeze(new Date())
- this.Metrics = {
- Timer: class Timer {},
- inc: sinon.stub(),
- }
- this.Metrics.Timer.prototype.done = sinon.stub()
- this.RedisManager = {
- promises: {
- clearUnflushedTime: sinon.stub().resolves(),
- getDoc: sinon.stub(),
- getPreviousDocOps: sinon.stub(),
- putDocInMemory: sinon.stub().resolves(),
- removeDocFromMemory: sinon.stub().resolves(),
- renameDoc: sinon.stub().resolves(),
- updateCommentState: sinon.stub().resolves(),
- updateDocument: sinon.stub().resolves(),
- },
- }
- this.ProjectHistoryRedisManager = {
- promises: {
- queueOps: sinon.stub().resolves(),
- queueResyncDocContent: sinon.stub().resolves(),
- },
- }
- this.PersistenceManager = {
- promises: {
- getDoc: sinon.stub(),
- setDoc: sinon.stub().resolves(),
- },
- }
- this.HistoryManager = {
- flushProjectChangesAsync: sinon.stub(),
- }
- this.DiffCodec = {
- diffAsShareJsOp: sinon.stub(),
- }
- this.UpdateManager = {
- promises: {
- applyUpdate: sinon.stub().resolves(),
- },
- }
- this.HistoryOTUpdateManager = {
- applyUpdate: sinon.stub().resolves(),
- }
- this.RangesManager = {
- acceptChanges: sinon.stub(),
- deleteComment: sinon.stub(),
- }
- this.Settings = {
- max_doc_length: 2 * 1024 * 1024, // 2mb
- }
- this.DocumentManager = SandboxedModule.require(modulePath, {
- requires: {
- './RedisManager': this.RedisManager,
- './ProjectHistoryRedisManager': this.ProjectHistoryRedisManager,
- './PersistenceManager': this.PersistenceManager,
- './HistoryManager': this.HistoryManager,
- './Metrics': this.Metrics,
- './DiffCodec': this.DiffCodec,
- './UpdateManager': this.UpdateManager,
- './HistoryOTUpdateManager': this.HistoryOTUpdateManager,
- './RangesManager': this.RangesManager,
- './Errors': Errors,
- '@overleaf/settings': this.Settings,
- },
- })
- this.project_id = 'project-id-123'
- this.projectHistoryId = 'history-id-123'
- this.doc_id = 'doc-id-123'
- this.user_id = 1234
- this.lines = ['one', 'two', 'three']
- this.version = 42
- this.ranges = { comments: 'mock', entries: 'mock' }
- this.resolvedCommentIds = ['comment-1']
- this.pathname = '/a/b/c.tex'
- this.unflushedTime = Date.now()
- this.lastUpdatedAt = Date.now()
- this.lastUpdatedBy = 'last-author-id'
- this.source = 'external-source'
- this.historyRangesSupport = false
- })
- afterEach(function () {
- tk.reset()
- })
- describe('flushAndDeleteDoc', function () {
- describe('successfully', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- await this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- {}
- )
- })
- it('should flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should remove the doc from redis', function () {
- this.RedisManager.promises.removeDocFromMemory
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when a flush error occurs', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon
- .stub()
- .rejects(new Error('boom!'))
- await expect(
- this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- {}
- )
- ).to.be.rejected
- })
- it('should not remove the doc from redis', function () {
- this.RedisManager.promises.removeDocFromMemory.called.should.equal(
- false
- )
- })
- describe('when ignoring flush errors', function () {
- it('should remove the doc from redis', async function () {
- await this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- { ignoreFlushErrors: true }
- )
- this.RedisManager.promises.removeDocFromMemory.called.should.equal(
- true
- )
- })
- })
- })
- })
- describe('flushDocIfLoaded', function () {
- describe('when the doc is in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- lastUpdatedAt: this.lastUpdatedAt,
- lastUpdatedBy: this.lastUpdatedBy,
- })
- await this.DocumentManager.promises.flushDocIfLoaded(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should write the doc lines to the persistence layer', function () {
- this.PersistenceManager.promises.setDoc.should.have.been.calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- this.ranges,
- this.lastUpdatedAt,
- this.lastUpdatedBy
- )
- })
- })
- describe('when the document is not in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: null,
- version: null,
- ranges: null,
- })
- await this.DocumentManager.promises.flushDocIfLoaded(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not write anything to the persistence layer', function () {
- this.PersistenceManager.promises.setDoc.called.should.equal(false)
- })
- })
- })
- describe('getDocAndRecentOps', function () {
- describe('with a previous version specified', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- type: 'sharejs-text-ot',
- })
- this.RedisManager.promises.getPreviousDocOps.resolves(this.ops)
- this.result = await this.DocumentManager.promises.getDocAndRecentOps(
- this.project_id,
- this.doc_id,
- this.fromVersion
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should get the doc ops', function () {
- this.RedisManager.promises.getPreviousDocOps
- .calledWith(this.doc_id, this.fromVersion, this.version)
- .should.equal(true)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ops: this.ops,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- type: 'sharejs-text-ot',
- })
- })
- })
- describe('with no previous version specified', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- type: 'sharejs-text-ot',
- })
- this.RedisManager.promises.getPreviousDocOps.resolves(this.ops)
- this.result = await this.DocumentManager.promises.getDocAndRecentOps(
- this.project_id,
- this.doc_id,
- -1
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not need to get the doc ops', function () {
- this.RedisManager.promises.getPreviousDocOps.called.should.equal(false)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ops: [],
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- type: 'sharejs-text-ot',
- })
- })
- })
- })
- describe('getDoc', function () {
- describe('when the doc exists in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- lastUpdatedAt: this.lastUpdatedAt,
- lastUpdatedBy: this.lastUpdatedBy,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.result = await this.DocumentManager.promises.getDoc(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from Redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: true,
- historyRangesSupport: this.historyRangesSupport,
- type: 'sharejs-text-ot',
- })
- })
- })
- describe('when the doc does not exist in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: null,
- version: null,
- ranges: null,
- pathname: null,
- projectHistoryId: null,
- })
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.result = await this.DocumentManager.promises.getDoc(
- this.project_id,
- this.doc_id
- )
- })
- it('should try to get the doc from Redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should get the doc from the PersistenceManager', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should set the doc in Redis', function () {
- this.RedisManager.promises.putDocInMemory
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- this.ranges,
- this.resolvedCommentIds,
- this.pathname,
- this.projectHistoryId,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- it('should return doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: null,
- alreadyLoaded: false,
- historyRangesSupport: this.historyRangesSupport,
- type: 'sharejs-text-ot',
- })
- })
- })
- })
- describe('setDoc', function () {
- describe('with plain tex lines', function () {
- beforeEach(function () {
- this.beforeLines = ['before', 'lines']
- this.afterLines = ['after', 'lines']
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: true,
- })
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- this.DocumentManager.promises.flushAndDeleteDoc = sinon
- .stub()
- .resolves()
- })
- describe('when not loaded but with the same content', function () {
- beforeEach(async function () {
- this.DiffCodec.diffAsShareJsOp.returns([])
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: false,
- })
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.beforeLines,
- this.source,
- this.user_id,
- false,
- true
- )
- })
- it('should not apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate.called.should.equal(false)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'noop',
- method: 'evict',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush and delete the doc from redis', function () {
- this.DocumentManager.promises.flushAndDeleteDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when already loaded with the same content', function () {
- beforeEach(async function () {
- this.DiffCodec.diffAsShareJsOp.returns([])
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.beforeLines,
- this.source,
- this.user_id,
- false,
- true
- )
- })
- it('should not apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate.called.should.equal(false)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'noop',
- method: 'flush',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush the doc to Mongo', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when already loaded', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- false,
- true
- )
- })
- it('should get the current doc lines', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return a diff of the old and new lines', function () {
- this.DiffCodec.diffAsShareJsOp
- .calledWith(this.beforeLines, this.afterLines)
- .should.equal(true)
- })
- it('should apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate
- .calledWith(this.project_id, this.doc_id, {
- doc: this.doc_id,
- v: this.version,
- op: this.ops,
- meta: {
- type: 'external',
- source: this.source,
- user_id: this.user_id,
- },
- })
- .should.equal(true)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'diff',
- method: 'flush',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush the doc to Mongo', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the project history', function () {
- this.HistoryManager.flushProjectChangesAsync.called.should.equal(
- false
- )
- })
- })
- describe('when not already loaded', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- pathname: this.pathname,
- unflushedTime: null,
- alreadyLoaded: false,
- })
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- false,
- true
- )
- })
- it('should flush and delete the doc from the doc updater', function () {
- this.DocumentManager.promises.flushAndDeleteDoc
- .calledWith(this.project_id, this.doc_id, {})
- .should.equal(true)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'diff',
- method: 'evict',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should not flush the project history', function () {
- this.HistoryManager.flushProjectChangesAsync
- .calledWithExactly(this.project_id)
- .should.equal(true)
- })
- })
- describe('without new lines', function () {
- beforeEach(async function () {
- await expect(
- this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- null,
- this.source,
- this.user_id,
- false,
- true
- )
- ).to.be.rejectedWith('No lines were provided to setDoc')
- })
- it('should not try to get the doc lines', function () {
- this.DocumentManager.promises.getDoc.called.should.equal(false)
- })
- })
- describe('with the undoing flag', function () {
- beforeEach(async function () {
- // Copy ops so we don't interfere with other tests
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- true,
- true
- )
- })
- it('should set the undo flag on each op', function () {
- this.ops.map(op => op.u.should.equal(true))
- })
- })
- describe('with the external flag', function () {
- beforeEach(async function () {
- this.undoing = false
- // Copy ops so we don't interfere with other tests
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- this.undoing,
- true
- )
- })
- it('should add the external type to update metadata', function () {
- this.UpdateManager.promises.applyUpdate
- .calledWith(this.project_id, this.doc_id, {
- doc: this.doc_id,
- v: this.version,
- op: this.ops,
- meta: {
- type: 'external',
- source: this.source,
- user_id: this.user_id,
- },
- })
- .should.equal(true)
- })
- })
- describe('without the external flag', function () {
- beforeEach(async function () {
- this.undoing = false
- // Copy ops so we don't interfere with other tests
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- this.undoing,
- false
- )
- })
- it('should not add the external type to update metadata', function () {
- this.UpdateManager.promises.applyUpdate
- .calledWith(this.project_id, this.doc_id, {
- doc: this.doc_id,
- v: this.version,
- op: this.ops,
- meta: {
- source: this.source,
- user_id: this.user_id,
- },
- })
- .should.equal(true)
- })
- })
- })
- })
- describe('acceptChanges', function () {
- beforeEach(function () {
- this.change_id = 'mock-change-id'
- this.change_ids = [
- 'mock-change-id-1',
- 'mock-change-id-2',
- 'mock-change-id-3',
- 'mock-change-id-4',
- ]
- this.version = 34
- this.lines = ['original', 'lines']
- this.ranges = { entries: 'mock', comments: 'mock' }
- this.updated_ranges = { entries: 'updated', comments: 'updated' }
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- })
- this.RangesManager.acceptChanges.returns(this.updated_ranges)
- })
- describe('successfully with a single change', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.change_id]
- )
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should apply the accept change to the ranges', function () {
- this.RangesManager.acceptChanges.should.have.been.calledWith(
- this.project_id,
- this.doc_id,
- [this.change_id],
- this.ranges
- )
- })
- it('should save the updated ranges', function () {
- this.RedisManager.promises.updateDocument
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- [],
- this.updated_ranges,
- {}
- )
- .should.equal(true)
- })
- })
- describe('successfully with multiple changes', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- this.change_ids
- )
- })
- it('should apply the accept change to the ranges', function () {
- this.RangesManager.acceptChanges
- .calledWith(
- this.project_id,
- this.doc_id,
- this.change_ids,
- this.ranges
- )
- .should.equal(true)
- })
- })
- describe('when the doc is not found', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon
- .stub()
- .resolves({ lines: null, version: null, ranges: null })
- await expect(
- this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.change_id]
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- it('should not save anything', function () {
- this.RedisManager.promises.updateDocument.called.should.equal(false)
- })
- })
- })
- describe('getComment', function () {
- beforeEach(function () {
- this.ranges.comments = [
- {
- id: 'mock-comment-id-1',
- },
- {
- id: 'mock-comment-id-2',
- },
- ]
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- })
- })
- describe('when comment exists', function () {
- beforeEach(async function () {
- await expect(
- this.DocumentManager.promises.getComment(
- this.project_id,
- this.doc_id,
- 'mock-comment-id-1'
- )
- ).to.eventually.deep.equal({
- comment: { id: 'mock-comment-id-1' },
- })
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when comment doesnt exists', function () {
- beforeEach(async function () {
- await expect(
- this.DocumentManager.promises.getComment(
- this.project_id,
- this.doc_id,
- 'mock-comment-id-x'
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when the doc is not found', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon
- .stub()
- .resolves({ lines: null, version: null, ranges: null })
- await expect(
- this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.change_id]
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- })
- })
- describe('deleteComment', function () {
- beforeEach(function () {
- this.comment_id = 'mock-comment-id'
- this.version = 34
- this.lines = ['original', 'lines']
- this.ranges = { comments: ['one', 'two', 'three'] }
- this.resolvedCommentIds = ['comment1']
- this.updated_ranges = { comments: ['one', 'three'] }
- this.historyRangesSupport = true
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: Date.now() - 1e9,
- alreadyLoaded: true,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.RangesManager.deleteComment.returns(this.updated_ranges)
- })
- describe('successfully', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.deleteComment(
- this.project_id,
- this.doc_id,
- this.comment_id,
- this.user_id
- )
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should delete the comment from the ranges', function () {
- this.RangesManager.deleteComment
- .calledWith(this.comment_id, this.ranges)
- .should.equal(true)
- })
- it('should save the updated ranges', function () {
- this.RedisManager.promises.updateDocument
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- [],
- this.updated_ranges,
- {}
- )
- .should.equal(true)
- })
- it('should unset the comment resolved state', function () {
- this.RedisManager.promises.updateCommentState.should.have.been.calledWith(
- this.doc_id,
- this.comment_id,
- false
- )
- })
- it('should queue the delete comment operation', function () {
- this.ProjectHistoryRedisManager.promises.queueOps.should.have.been.calledWith(
- this.project_id,
- JSON.stringify({
- pathname: this.pathname,
- deleteComment: this.comment_id,
- meta: {
- ts: new Date(),
- user_id: this.user_id,
- },
- })
- )
- })
- })
- describe('when the doc is not found', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon
- .stub()
- .resolves({ lines: null, version: null, ranges: null })
- await expect(
- this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.comment_id]
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- it('should not save anything', function () {
- this.RedisManager.promises.updateDocument.called.should.equal(false)
- })
- })
- })
- describe('getDocAndFlushIfOld', function () {
- beforeEach(function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- })
- describe('when the doc is in Redis', function () {
- describe('and has changes to be flushed', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- projectHistoryId: this.projectHistoryId,
- pathname: this.pathname,
- unflushedTime: Date.now() - 1e9,
- alreadyLoaded: true,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- describe("and has only changes that don't need to be flushed", function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- unflushedTime: Date.now() - 100,
- alreadyLoaded: true,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded.called.should.equal(
- false
- )
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- })
- describe('when the doc is not in Redis', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- alreadyLoaded: false,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded.called.should.equal(
- false
- )
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- })
- describe('renameDoc', function () {
- beforeEach(function () {
- this.update = 'some-update'
- })
- describe('successfully', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.renameDoc(
- this.project_id,
- this.doc_id,
- this.user_id,
- this.update,
- this.projectHistoryId
- )
- })
- it('should rename the document', function () {
- this.RedisManager.promises.renameDoc
- .calledWith(
- this.project_id,
- this.doc_id,
- this.user_id,
- this.update,
- this.projectHistoryId
- )
- .should.equal(true)
- })
- })
- })
- describe('resyncDocContents', function () {
- describe('when doc is loaded in redis', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('gets the doc contents from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('queues a resync doc content update', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- this.ranges,
- this.resolvedCommentIds,
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- describe('when doc is not loaded in redis', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({})
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('tries to get the doc contents from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('gets the doc contents from web', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id, { peek: true })
- .should.equal(true)
- })
- it('queues a resync doc content update', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- this.ranges,
- this.resolvedCommentIds,
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- describe('when a doc has no ranges in docstore', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({})
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: undefined,
- resolvedCommentIds: [],
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('gets the doc contents from web', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id, { peek: true })
- .should.equal(true)
- })
- it('queues a resync doc content update with an empty ranges object', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- {},
- [],
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- })
- describe('appendToDoc', function () {
- describe('sucessfully', function () {
- beforeEach(async function () {
- this.lines = ['one', 'two', 'three']
- this.DocumentManager.promises.setDoc = sinon
- .stub()
- .resolves({ rev: '123' })
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- })
- this.result = await this.DocumentManager.promises.appendToDoc(
- this.project_id,
- this.doc_id,
- ['four', 'five', 'six'],
- this.source,
- this.user_id
- )
- })
- it('should call setDoc with concatenated lines', function () {
- this.DocumentManager.promises.setDoc
- .calledWith(
- this.project_id,
- this.doc_id,
- ['one', 'two', 'three', 'four', 'five', 'six'],
- this.source,
- this.user_id,
- false,
- false
- )
- .should.equal(true)
- })
- it('should return output from setDoc', function () {
- this.result.should.deep.equal({ rev: '123' })
- })
- })
- describe('when doc would become too big', function () {
- beforeEach(async function () {
- this.Settings.max_doc_length = 100
- this.lines = ['one', 'two', 'three']
- this.DocumentManager.promises.setDoc = sinon
- .stub()
- .resolves({ rev: '123' })
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- })
- })
- it('should fail with FileTooLarge error', async function () {
- expect(
- this.DocumentManager.promises.appendToDoc(
- this.project_id,
- this.doc_id,
- ['x'.repeat(1000)],
- this.source,
- this.user_id
- )
- ).to.eventually.be.rejectedWith(Errors.FileTooLargeError)
- })
- })
- })
- })
|