| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289 |
- const SandboxedModule = require('sandboxed-module')
- const sinon = require('sinon')
- const { expect } = require('chai')
- const { ObjectId } = require('mongodb-legacy')
- const MockRequest = require('../helpers/MockRequest')
- const MockResponse = require('../helpers/MockResponse')
- const PrivilegeLevels = require('../../../../app/src/Features/Authorization/PrivilegeLevels')
- const MODULE_PATH =
- '../../../../app/src/Features/TokenAccess/TokenAccessController'
- describe('TokenAccessController', function () {
- beforeEach(function () {
- this.token = 'abc123'
- this.user = { _id: new ObjectId() }
- this.project = {
- _id: new ObjectId(),
- name: 'test',
- tokenAccessReadAndWrite_refs: [],
- tokenAccessReadOnly_refs: [],
- }
- this.req = new MockRequest()
- this.res = new MockResponse()
- this.next = sinon.stub().returns()
- this.Settings = {
- siteUrl: 'https://www.dev-overleaf.com',
- adminPrivilegeAvailable: false,
- adminUrl: 'https://admin.dev-overleaf.com',
- adminDomains: ['overleaf.com'],
- }
- this.TokenAccessHandler = {
- TOKEN_TYPES: {
- READ_ONLY: 'readOnly',
- READ_AND_WRITE: 'readAndWrite',
- },
- isReadAndWriteToken: sinon.stub().returns(true),
- isReadOnlyToken: sinon.stub().returns(true),
- tokenAccessEnabledForProject: sinon.stub().returns(true),
- checkTokenHashPrefix: sinon.stub(),
- makeTokenUrl: sinon.stub().returns('/'),
- grantSessionTokenAccess: sinon.stub(),
- promises: {
- addReadAndWriteUserToProject: sinon.stub().resolves(),
- addReadOnlyUserToProject: sinon.stub().resolves(),
- getProjectByToken: sinon.stub().resolves(this.project),
- getV1DocPublishedInfo: sinon.stub().resolves({ allow: true }),
- getV1DocInfo: sinon.stub(),
- removeReadAndWriteUserFromProject: sinon.stub().resolves(),
- moveReadAndWriteUserToReadOnly: sinon.stub().resolves(),
- },
- }
- this.SessionManager = {
- getLoggedInUserId: sinon.stub().returns(this.user._id),
- getSessionUser: sinon.stub().returns(this.user._id),
- }
- this.AuthenticationController = {
- setRedirectInSession: sinon.stub(),
- }
- this.AuthorizationManager = {
- promises: {
- getPrivilegeLevelForProject: sinon
- .stub()
- .resolves(PrivilegeLevels.NONE),
- },
- }
- this.AuthorizationMiddleware = {}
- this.ProjectAuditLogHandler = {
- promises: {
- addEntry: sinon.stub().resolves(),
- },
- }
- this.SplitTestHandler = {
- promises: {
- getAssignment: sinon.stub().resolves({ variant: 'default' }),
- getAssignmentForUser: sinon.stub().resolves({ variant: 'default' }),
- },
- }
- this.CollaboratorsHandler = {
- promises: {
- addUserIdToProject: sinon.stub().resolves(),
- setCollaboratorPrivilegeLevel: sinon.stub().resolves(),
- },
- }
- this.CollaboratorsGetter = {
- promises: {
- userIsReadWriteTokenMember: sinon.stub().resolves(),
- isUserInvitedReadWriteMemberOfProject: sinon.stub().resolves(),
- isUserInvitedMemberOfProject: sinon.stub().resolves(),
- },
- }
- this.EditorRealTimeController = { emitToRoom: sinon.stub() }
- this.ProjectGetter = {
- promises: {
- getProject: sinon.stub().resolves(this.project),
- },
- }
- this.AnalyticsManager = {
- recordEventForSession: sinon.stub(),
- recordEventForUserInBackground: sinon.stub(),
- }
- this.UserGetter = {
- promises: {
- getUser: sinon.stub().callsFake(async (userId, filter) => {
- if (userId === this.userId) {
- return this.user
- } else {
- return null
- }
- }),
- },
- }
- this.LimitationsManager = {
- promises: {
- canAcceptEditCollaboratorInvite: sinon.stub().resolves(),
- },
- }
- this.TokenAccessController = SandboxedModule.require(MODULE_PATH, {
- requires: {
- '@overleaf/settings': this.Settings,
- './TokenAccessHandler': this.TokenAccessHandler,
- '../Authentication/AuthenticationController':
- this.AuthenticationController,
- '../Authentication/SessionManager': this.SessionManager,
- '../Authorization/AuthorizationManager': this.AuthorizationManager,
- '../Authorization/AuthorizationMiddleware':
- this.AuthorizationMiddleware,
- '../Project/ProjectAuditLogHandler': this.ProjectAuditLogHandler,
- '../SplitTests/SplitTestHandler': this.SplitTestHandler,
- '../Errors/Errors': (this.Errors = { NotFoundError: sinon.stub() }),
- '../Collaborators/CollaboratorsHandler': this.CollaboratorsHandler,
- '../Collaborators/CollaboratorsGetter': this.CollaboratorsGetter,
- '../Editor/EditorRealTimeController': this.EditorRealTimeController,
- '../Project/ProjectGetter': this.ProjectGetter,
- '../Helpers/AsyncFormHelper': (this.AsyncFormHelper = {
- redirect: sinon.stub(),
- }),
- '../Analytics/AnalyticsManager': this.AnalyticsManager,
- '../User/UserGetter': this.UserGetter,
- '../Subscription/LimitationsManager': this.LimitationsManager,
- },
- })
- })
- describe('grantTokenAccessReadAndWrite', function () {
- describe('normal case', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('grants read and write access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadAndWriteUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'join-via-token',
- this.user._id,
- this.req.ip,
- { privileges: 'readAndWrite' }
- )
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when project owner in link-sharing-warning split test', function () {
- beforeEach(function () {
- this.SplitTestHandler.promises.getAssignmentForUser.callsFake(
- async (userId, test) => {
- if (test === 'link-sharing-warning') {
- return { variant: 'active' }
- }
- }
- )
- })
- it('tells the ui to show the link-sharing-warning variant', async function () {
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- await this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- {
- json: content => {
- expect(content).to.deep.equal({
- requireAccept: {
- linkSharingChanges: true,
- projectName: this.project.name,
- },
- })
- },
- }
- )
- })
- describe('normal case', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('adds the user as a read and write invited member', function () {
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_AND_WRITE
- )
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'accept-via-link-sharing',
- this.user._id,
- this.req.ip,
- { privileges: 'readAndWrite' }
- )
- })
- it('records a project-joined event for the user', function () {
- expect(
- this.AnalyticsManager.recordEventForUserInBackground
- ).to.have.been.calledWith(this.user._id, 'project-joined', {
- mode: 'read-write',
- projectId: this.project._id.toString(),
- })
- })
- it('emits a project membership changed event', function () {
- expect(
- this.EditorRealTimeController.emitToRoom
- ).to.have.been.calledWith(
- this.project._id,
- 'project:membership:changed',
- { members: true }
- )
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when the project owner is in the link-sharing-enforcement split test', function () {
- beforeEach(function () {
- this.SplitTestHandler.promises.getAssignmentForUser.callsFake(
- async (userId, test) => {
- if (test === 'link-sharing-warning') {
- return { variant: 'active' }
- } else if (test === 'link-sharing-enforcement') {
- return { variant: 'active' }
- }
- }
- )
- })
- describe('normal case (edit slot available)', function () {
- beforeEach(function (done) {
- this.LimitationsManager.promises.canAcceptEditCollaboratorInvite.resolves(
- true
- )
- this.req.params = { token: this.token }
- this.req.body = {
- confirmedByUser: true,
- tokenHashPrefix: '#prefix',
- }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('adds the user as a read and write invited member', function () {
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_AND_WRITE
- )
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'accept-via-link-sharing',
- this.user._id,
- this.req.ip,
- { privileges: 'readAndWrite' }
- )
- })
- it('records a project-joined event for the user', function () {
- expect(
- this.AnalyticsManager.recordEventForUserInBackground
- ).to.have.been.calledWith(this.user._id, 'project-joined', {
- mode: 'read-write',
- projectId: this.project._id.toString(),
- })
- })
- it('emits a project membership changed event', function () {
- expect(
- this.EditorRealTimeController.emitToRoom
- ).to.have.been.calledWith(
- this.project._id,
- 'project:membership:changed',
- { members: true }
- )
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when there are no edit collaborator slots available', function () {
- beforeEach(function (done) {
- this.LimitationsManager.promises.canAcceptEditCollaboratorInvite.resolves(
- false
- )
- this.req.params = { token: this.token }
- this.req.body = {
- confirmedByUser: true,
- tokenHashPrefix: '#prefix',
- }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('adds the user as a read only invited member instead (pendingEditor)', function () {
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_ONLY,
- { pendingEditor: true }
- )
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'accept-via-link-sharing',
- this.user._id,
- this.req.ip,
- { privileges: 'readOnly', pendingEditor: true }
- )
- })
- it('records a project-joined event for the user', function () {
- expect(
- this.AnalyticsManager.recordEventForUserInBackground
- ).to.have.been.calledWith(this.user._id, 'project-joined', {
- mode: 'read-only',
- projectId: this.project._id.toString(),
- pendingEditor: true,
- })
- })
- it('emits a project membership changed event', function () {
- expect(
- this.EditorRealTimeController.emitToRoom
- ).to.have.been.calledWith(
- this.project._id,
- 'project:membership:changed',
- { members: true }
- )
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- })
- })
- describe('when the access was already granted', function () {
- beforeEach(function (done) {
- this.project.tokenAccessReadAndWrite_refs.push(this.user._id)
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it("doesn't write a project audit log", function () {
- expect(this.ProjectAuditLogHandler.promises.addEntry).to.not.have.been
- .called
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('hash prefix missing in request', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('grants read and write access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadAndWriteUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('checks the hash prefix', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('user is owner of project', function () {
- beforeEach(function (done) {
- this.AuthorizationManager.promises.getPrivilegeLevelForProject.returns(
- PrivilegeLevels.OWNER
- )
- this.req.params = { token: this.token }
- this.req.body = {}
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('checks token hash and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'user already has higher or same privilege',
- }
- )
- })
- })
- describe('when user is not logged in', function () {
- beforeEach(function () {
- this.SessionManager.getLoggedInUserId.returns(null)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- })
- describe('ANONYMOUS_READ_AND_WRITE_ENABLED is undefined', function () {
- beforeEach(function (done) {
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to restricted', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: '/restricted',
- anonWriteAccessDenied: true,
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- null,
- {
- action: 'denied anonymous read-and-write token access',
- }
- )
- })
- it('saves redirect URL with URL fragment', function () {
- expect(
- this.AuthenticationController.setRedirectInSession.lastCall.args[1]
- ).to.equal('/#prefix')
- })
- })
- describe('ANONYMOUS_READ_AND_WRITE_ENABLED is true', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.ANONYMOUS_READ_AND_WRITE_ENABLED = true
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to project', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: `/project/${this.project._id}`,
- grantAnonymousAccess: 'readAndWrite',
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- null,
- {
- projectId: this.project._id,
- action: 'granting read-write anonymous access',
- }
- )
- })
- })
- })
- describe('when Overleaf SaaS', function () {
- beforeEach(function () {
- this.Settings.overleaf = {}
- })
- describe('when token is for v1 project', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.TokenAccessHandler.promises.getV1DocInfo.resolves({
- exists: true,
- has_owner: true,
- })
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('returns v1 import data', function () {
- expect(this.res.json).to.have.been.calledWith({
- v1Import: {
- status: 'canDownloadZip',
- projectId: this.token,
- hasOwner: true,
- name: 'Untitled',
- brandInfo: undefined,
- },
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: 'import v1',
- }
- )
- })
- })
- describe('when token is not for a v1 or v2 project', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.TokenAccessHandler.promises.getV1DocInfo.resolves({
- exists: false,
- })
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('returns 404', function () {
- expect(this.res.sendStatus).to.have.been.calledWith(404)
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: '404',
- }
- )
- })
- })
- })
- describe('not Overleaf SaaS', function () {
- beforeEach(function () {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- })
- it('passes Errors.NotFoundError to next when project not found and still checks token hash', function (done) {
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: '404',
- }
- )
- done()
- }
- )
- })
- })
- describe('when user is admin', function () {
- const admin = { _id: new ObjectId(), isAdmin: true }
- beforeEach(function () {
- this.SessionManager.getLoggedInUserId.returns(admin._id)
- this.SessionManager.getSessionUser.returns(admin)
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- })
- it('redirects if project owner is non-admin', function () {
- this.UserGetter.promises.getUserConfirmedEmails = sinon
- .stub()
- .resolves([{ email: 'test@not-overleaf.com' }])
- this.res.callback = () => {
- expect(this.res.json).to.have.been.calledWith({
- redirect: `${this.Settings.adminUrl}/#prefix`,
- })
- }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res
- )
- })
- it('grants access if project owner is an internal staff', function () {
- const internalStaff = { _id: new ObjectId(), isAdmin: true }
- const projectFromInternalStaff = {
- _id: new ObjectId(),
- name: 'test',
- tokenAccessReadAndWrite_refs: [],
- tokenAccessReadOnly_refs: [],
- owner_ref: internalStaff._id,
- }
- this.UserGetter.promises.getUser = sinon.stub().resolves(internalStaff)
- this.UserGetter.promises.getUserConfirmedEmails = sinon
- .stub()
- .resolves([{ email: 'test@overleaf.com' }])
- this.TokenAccessHandler.promises.getProjectByToken = sinon
- .stub()
- .resolves(projectFromInternalStaff)
- this.res.callback = () => {
- expect(
- this.TokenAccessHandler.promises.addReadAndWriteUserToProject
- ).to.have.been.calledWith(admin._id, projectFromInternalStaff._id)
- }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res
- )
- })
- })
- it('passes Errors.NotFoundError to next when token access is not enabled but still checks token hash', function (done) {
- this.TokenAccessHandler.tokenAccessEnabledForProject.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'token access not enabled',
- }
- )
- done()
- }
- )
- })
- it('returns 400 when not using a read write token', function () {
- this.TokenAccessHandler.isReadAndWriteToken.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res
- )
- expect(this.res.sendStatus).to.have.been.calledWith(400)
- })
- })
- describe('grantTokenAccessReadOnly', function () {
- describe('normal case', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('grants read-only access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadOnlyUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'join-via-token',
- this.user._id,
- this.req.ip,
- { privileges: 'readOnly' }
- )
- })
- it('checks if hash prefix matches', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readOnly',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when the access was already granted', function () {
- beforeEach(function (done) {
- this.project.tokenAccessReadOnly_refs.push(this.user._id)
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it("doesn't write a project audit log", function () {
- expect(this.ProjectAuditLogHandler.promises.addEntry).to.not.have.been
- .called
- })
- it('still checks if hash prefix matches', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readOnly',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- it('returns 400 when not using a read only token', function () {
- this.TokenAccessHandler.isReadOnlyToken.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadOnly(this.req, this.res)
- expect(this.res.sendStatus).to.have.been.calledWith(400)
- })
- describe('anonymous users', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.SessionManager.getLoggedInUserId.returns(null)
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('allows anonymous users and checks the token hash', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: `/project/${this.project._id}`,
- grantAnonymousAccess: 'readOnly',
- })
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(this.token, undefined, 'readOnly', null, {
- projectId: this.project._id,
- action: 'granting read-only anonymous access',
- })
- })
- })
- describe('user is owner of project', function () {
- beforeEach(function (done) {
- this.AuthorizationManager.promises.getPrivilegeLevelForProject.returns(
- PrivilegeLevels.OWNER
- )
- this.req.params = { token: this.token }
- this.req.body = {}
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('checks token hash and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readOnly',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'user already has higher or same privilege',
- }
- )
- })
- })
- it('passes Errors.NotFoundError to next when token access is not enabled but still checks token hash', function (done) {
- this.TokenAccessHandler.tokenAccessEnabledForProject.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readOnly',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'token access not enabled',
- }
- )
- done()
- }
- )
- })
- })
- describe('ensureUserCanUseSharingUpdatesConsentPage', function () {
- beforeEach(function () {
- this.req.params = { Project_id: this.project._id }
- })
- describe('when not in link sharing changes test', function () {
- beforeEach(function (done) {
- this.AsyncFormHelper.redirect = sinon.stub().callsFake(() => done())
- this.TokenAccessController.ensureUserCanUseSharingUpdatesConsentPage(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to the project/editor', function () {
- expect(this.AsyncFormHelper.redirect).to.have.been.calledWith(
- this.req,
- this.res,
- `/project/${this.project._id}`
- )
- })
- })
- describe('when link sharing changes test active', function () {
- beforeEach(function () {
- this.SplitTestHandler.promises.getAssignmentForUser.resolves({
- variant: 'active',
- })
- })
- describe('when user is not an invited editor and is a read write token member', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedReadWriteMemberOfProject.resolves(
- false
- )
- this.CollaboratorsGetter.promises.userIsReadWriteTokenMember.resolves(
- true
- )
- this.next.callsFake(() => done())
- this.TokenAccessController.ensureUserCanUseSharingUpdatesConsentPage(
- this.req,
- this.res,
- this.next
- )
- })
- it('calls next', function () {
- expect(
- this.CollaboratorsGetter.promises
- .isUserInvitedReadWriteMemberOfProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(
- this.CollaboratorsGetter.promises.userIsReadWriteTokenMember
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(this.next).to.have.been.calledOnce
- expect(this.next.firstCall.args[0]).to.not.exist
- })
- })
- describe('when user is already an invited editor', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedReadWriteMemberOfProject.resolves(
- true
- )
- this.AsyncFormHelper.redirect = sinon.stub().callsFake(() => done())
- this.TokenAccessController.ensureUserCanUseSharingUpdatesConsentPage(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to the project/editor', function () {
- expect(this.AsyncFormHelper.redirect).to.have.been.calledWith(
- this.req,
- this.res,
- `/project/${this.project._id}`
- )
- })
- })
- describe('when user not a read write token member', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.userIsReadWriteTokenMember.resolves(
- false
- )
- this.AsyncFormHelper.redirect = sinon.stub().callsFake(() => done())
- this.TokenAccessController.ensureUserCanUseSharingUpdatesConsentPage(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to the project/editor', function () {
- expect(this.AsyncFormHelper.redirect).to.have.been.calledWith(
- this.req,
- this.res,
- `/project/${this.project._id}`
- )
- })
- })
- })
- })
- describe('moveReadWriteToCollaborators', function () {
- beforeEach(function () {
- this.req.params = { Project_id: this.project._id }
- })
- describe('read only invited viewer gaining edit access via link sharing', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedMemberOfProject.resolves(
- true
- )
- this.res.callback = done
- this.TokenAccessController.moveReadWriteToCollaborators(
- this.req,
- this.res,
- done
- )
- })
- it('sets the privilege level to read and write for the invited viewer', function () {
- expect(
- this.CollaboratorsHandler.promises.setCollaboratorPrivilegeLevel
- ).to.have.been.calledWith(
- this.project._id,
- this.user._id,
- PrivilegeLevels.READ_AND_WRITE
- )
- expect(this.res.sendStatus).to.have.been.calledWith(204)
- })
- })
- describe('previously joined token access user moving to named collaborator', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedMemberOfProject.resolves(
- false
- )
- this.res.callback = done
- this.TokenAccessController.moveReadWriteToCollaborators(
- this.req,
- this.res,
- done
- )
- })
- it('sets the privilege level to read and write for the invited viewer', function () {
- expect(
- this.TokenAccessHandler.promises.removeReadAndWriteUserFromProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_AND_WRITE
- )
- expect(this.res.sendStatus).to.have.been.calledWith(204)
- })
- })
- describe('when link-sharing-enforcement test is active', function () {
- beforeEach(function () {
- this.SplitTestHandler.promises.getAssignmentForUser.resolves({
- variant: 'active',
- })
- })
- describe('when there are collaborator slots available', function () {
- beforeEach(function () {
- this.LimitationsManager.promises.canAcceptEditCollaboratorInvite.resolves(
- true
- )
- })
- describe('previously joined token access user moving to named collaborator', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedMemberOfProject.resolves(
- false
- )
- this.res.callback = done
- this.TokenAccessController.moveReadWriteToCollaborators(
- this.req,
- this.res,
- done
- )
- })
- it('sets the privilege level to read and write for the invited viewer', function () {
- expect(
- this.TokenAccessHandler.promises.removeReadAndWriteUserFromProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_AND_WRITE
- )
- expect(this.res.sendStatus).to.have.been.calledWith(204)
- })
- })
- })
- describe('when there are no edit collaborator slots available', function () {
- beforeEach(function () {
- this.LimitationsManager.promises.canAcceptEditCollaboratorInvite.resolves(
- false
- )
- })
- describe('previously joined token access user moving to named collaborator', function () {
- beforeEach(function (done) {
- this.CollaboratorsGetter.promises.isUserInvitedMemberOfProject.resolves(
- false
- )
- this.res.callback = done
- this.TokenAccessController.moveReadWriteToCollaborators(
- this.req,
- this.res,
- done
- )
- })
- it('sets the privilege level to read only for the invited viewer (pendingEditor)', function () {
- expect(
- this.TokenAccessHandler.promises.removeReadAndWriteUserFromProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(
- this.CollaboratorsHandler.promises.addUserIdToProject
- ).to.have.been.calledWith(
- this.project._id,
- undefined,
- this.user._id,
- PrivilegeLevels.READ_ONLY,
- { pendingEditor: true }
- )
- expect(this.res.sendStatus).to.have.been.calledWith(204)
- })
- })
- })
- })
- })
- describe('moveReadWriteToReadOnly', function () {
- beforeEach(function () {
- this.req.params = { Project_id: this.project._id }
- })
- describe('previously joined token access user moving to anonymous viewer', function () {
- beforeEach(function (done) {
- this.res.callback = done
- this.TokenAccessController.moveReadWriteToReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('removes them from read write token access refs and adds them to read only token access refs', function () {
- expect(
- this.TokenAccessHandler.promises.moveReadAndWriteUserToReadOnly
- ).to.have.been.calledWith(this.user._id, this.project._id)
- expect(this.res.sendStatus).to.have.been.calledWith(204)
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'readonly-via-sharing-updates',
- this.user._id,
- this.req.ip
- )
- })
- })
- })
- })
|