| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750 |
- import { vi, expect, describe, beforeEach, afterEach, it } from 'vitest'
- /* eslint-disable
- no-return-assign,
- no-throw-literal,
- no-unused-vars,
- */
- // TODO: This file was created by bulk-decaffeinate.
- // Fix any style issues and re-enable lint.
- /*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
- import sinon from 'sinon'
- import tk from 'timekeeper'
- import Errors from '../../../app/js/Errors.js'
- const modulePath = '../../../app/js/WebsocketController.js'
- const { UpdateTooLargeError } = Errors
- describe('WebsocketController', function () {
- beforeEach(async function (ctx) {
- tk.freeze(new Date())
- ctx.project_id = 'project-id-123'
- ctx.user = {
- _id: (ctx.user_id = 'user-id-123'),
- first_name: 'James',
- last_name: 'Allen',
- email: 'james@example.com',
- signUpDate: new Date('2014-01-01'),
- loginCount: 42,
- }
- ctx.callback = sinon.stub()
- ctx.client = {
- disconnected: false,
- id: (ctx.client_id = 'mock-client-id-123'),
- publicId: `other-id-${Math.random()}`,
- ol_context: {},
- joinLeaveEpoch: 0,
- join: sinon.stub(),
- leave: sinon.stub(),
- }
- vi.doMock('../../../app/js/WebApiManager', () => ({
- default: (ctx.WebApiManager = {}),
- }))
- vi.doMock('../../../app/js/AuthorizationManager', () => ({
- default: (ctx.AuthorizationManager = {}),
- }))
- vi.doMock('../../../app/js/DocumentUpdaterManager', () => ({
- default: (ctx.DocumentUpdaterManager = {}),
- }))
- vi.doMock('../../../app/js/ConnectedUsersManager', () => ({
- default: (ctx.ConnectedUsersManager = {}),
- }))
- vi.doMock('../../../app/js/WebsocketLoadBalancer', () => ({
- default: (ctx.WebsocketLoadBalancer = {}),
- }))
- vi.doMock('@overleaf/metrics', () => ({
- default: (ctx.metrics = {
- inc: sinon.stub(),
- set: sinon.stub(),
- }),
- }))
- vi.doMock('../../../app/js/RoomManager', () => ({
- default: (ctx.RoomManager = {}),
- }))
- ctx.WebsocketController = (await import(modulePath)).default
- })
- afterEach(function () {
- return tk.reset()
- })
- describe('joinProject', function () {
- describe('when authorised', function () {
- beforeEach(function (ctx) {
- ctx.client.id = 'mock-client-id'
- ctx.project = {
- name: 'Test Project',
- owner: {
- _id: (ctx.owner_id = 'mock-owner-id-123'),
- },
- }
- ctx.privilegeLevel = 'owner'
- ctx.ConnectedUsersManager.updateUserPosition = sinon
- .stub()
- .callsArgAsync(4)
- ctx.isRestrictedUser = true
- ctx.isTokenMember = true
- ctx.isInvitedMember = true
- ctx.WebApiManager.joinProject = sinon
- .stub()
- .callsArgWith(2, null, ctx.project, ctx.privilegeLevel, {
- isRestrictedUser: ctx.isRestrictedUser,
- isTokenMember: ctx.isTokenMember,
- isInvitedMember: ctx.isInvitedMember,
- })
- ctx.RoomManager.joinProject = sinon.stub().callsArg(2)
- return ctx.WebsocketController.joinProject(
- ctx.client,
- ctx.user,
- ctx.project_id,
- ctx.callback
- )
- })
- it('should load the project from web', function (ctx) {
- return ctx.WebApiManager.joinProject
- .calledWith(ctx.project_id, ctx.user)
- .should.equal(true)
- })
- it('should join the project room', function (ctx) {
- return ctx.RoomManager.joinProject
- .calledWith(ctx.client, ctx.project_id)
- .should.equal(true)
- })
- it('should set the privilege level on the client', function (ctx) {
- return ctx.client.ol_context.privilege_level.should.equal(
- ctx.privilegeLevel
- )
- })
- it("should set the user's id on the client", function (ctx) {
- return ctx.client.ol_context.user_id.should.equal(ctx.user._id)
- })
- it("should set the user's email on the client", function (ctx) {
- return ctx.client.ol_context.email.should.equal(ctx.user.email)
- })
- it("should set the user's first_name on the client", function (ctx) {
- return ctx.client.ol_context.first_name.should.equal(
- ctx.user.first_name
- )
- })
- it("should set the user's last_name on the client", function (ctx) {
- return ctx.client.ol_context.last_name.should.equal(ctx.user.last_name)
- })
- it("should set the user's sign up date on the client", function (ctx) {
- return ctx.client.ol_context.signup_date.should.equal(
- ctx.user.signUpDate
- )
- })
- it("should set the user's login_count on the client", function (ctx) {
- return ctx.client.ol_context.login_count.should.equal(
- ctx.user.loginCount
- )
- })
- it('should set the connected time on the client', function (ctx) {
- return ctx.client.ol_context.connected_time.should.equal(new Date())
- })
- it('should set the project_id on the client', function (ctx) {
- return ctx.client.ol_context.project_id.should.equal(ctx.project_id)
- })
- it('should set the project owner id on the client', function (ctx) {
- return ctx.client.ol_context.owner_id.should.equal(ctx.owner_id)
- })
- it('should set the is_restricted_user flag on the client', function (ctx) {
- return ctx.client.ol_context.is_restricted_user.should.equal(
- ctx.isRestrictedUser
- )
- })
- it('should set the is_token_member flag on the client', function (ctx) {
- ctx.client.ol_context.is_token_member.should.equal(ctx.isTokenMember)
- })
- it('should set the is_invited_member flag on the client', function (ctx) {
- ctx.client.ol_context.is_invited_member.should.equal(
- ctx.isInvitedMember
- )
- })
- it('should call the callback with the project, privilegeLevel and protocolVersion', function (ctx) {
- return ctx.callback
- .calledWith(
- null,
- ctx.project,
- ctx.privilegeLevel,
- ctx.WebsocketController.PROTOCOL_VERSION
- )
- .should.equal(true)
- })
- it('should mark the user as connected in ConnectedUsersManager', function (ctx) {
- return ctx.ConnectedUsersManager.updateUserPosition
- .calledWith(ctx.project_id, ctx.client.publicId, ctx.user, null)
- .should.equal(true)
- })
- return it('should increment the join-project metric', function (ctx) {
- return ctx.metrics.inc
- .calledWith('editor.join-project')
- .should.equal(true)
- })
- })
- describe('when not authorized', function () {
- beforeEach(function (ctx) {
- ctx.WebApiManager.joinProject = sinon
- .stub()
- .callsArgWith(2, null, null, null)
- return ctx.WebsocketController.joinProject(
- ctx.client,
- ctx.user,
- ctx.project_id,
- ctx.callback
- )
- })
- it('should return an error', function (ctx) {
- return ctx.callback
- .calledWith(sinon.match({ message: 'not authorized' }))
- .should.equal(true)
- })
- return it('should not log an error', function (ctx) {
- return ctx.logger.error.called.should.equal(false)
- })
- })
- describe('when the subscribe failed', function () {
- beforeEach(function (ctx) {
- ctx.client.id = 'mock-client-id'
- ctx.project = {
- name: 'Test Project',
- owner: {
- _id: (ctx.owner_id = 'mock-owner-id-123'),
- },
- }
- ctx.privilegeLevel = 'owner'
- ctx.ConnectedUsersManager.updateUserPosition = sinon
- .stub()
- .callsArgAsync(4)
- ctx.isRestrictedUser = true
- ctx.isTokenMember = true
- ctx.isInvitedMember = true
- ctx.WebApiManager.joinProject = sinon
- .stub()
- .callsArgWith(2, null, ctx.project, ctx.privilegeLevel, {
- isRestrictedUser: ctx.isRestrictedUser,
- isTokenMember: ctx.isTokenMember,
- isInvitedMember: ctx.isInvitedMember,
- })
- ctx.RoomManager.joinProject = sinon
- .stub()
- .callsArgWith(2, new Error('subscribe failed'))
- return ctx.WebsocketController.joinProject(
- ctx.client,
- ctx.user,
- ctx.project_id,
- ctx.callback
- )
- })
- return it('should return an error', function (ctx) {
- ctx.callback
- .calledWith(sinon.match({ message: 'subscribe failed' }))
- .should.equal(true)
- return ctx.callback.args[0][0].message.should.equal('subscribe failed')
- })
- })
- describe('when the client has disconnected', function () {
- beforeEach(function (ctx) {
- ctx.client.disconnected = true
- ctx.WebApiManager.joinProject = sinon.stub().callsArg(2)
- return ctx.WebsocketController.joinProject(
- ctx.client,
- ctx.user,
- ctx.project_id,
- ctx.callback
- )
- })
- it('should not call WebApiManager.joinProject', function (ctx) {
- return expect(ctx.WebApiManager.joinProject.called).to.equal(false)
- })
- it('should call the callback with no details', function (ctx) {
- return expect(ctx.callback.args[0]).to.deep.equal([])
- })
- return it('should increment the editor.join-project.disconnected metric with a status', function (ctx) {
- return expect(
- ctx.metrics.inc.calledWith('editor.join-project.disconnected', 1, {
- status: 'immediately',
- })
- ).to.equal(true)
- })
- })
- return describe('when the client disconnects while WebApiManager.joinProject is running', function () {
- beforeEach(function (ctx) {
- ctx.WebApiManager.joinProject = (project, user, cb) => {
- ctx.client.disconnected = true
- return cb(null, ctx.project, ctx.privilegeLevel, {
- isRestrictedUser: ctx.isRestrictedUser,
- isTokenMember: ctx.isTokenMember,
- isInvitedMember: ctx.isInvitedMember,
- })
- }
- return ctx.WebsocketController.joinProject(
- ctx.client,
- ctx.user,
- ctx.project_id,
- ctx.callback
- )
- })
- it('should call the callback with no details', function (ctx) {
- return expect(ctx.callback.args[0]).to.deep.equal([])
- })
- return it('should increment the editor.join-project.disconnected metric with a status', function (ctx) {
- return expect(
- ctx.metrics.inc.calledWith('editor.join-project.disconnected', 1, {
- status: 'after-web-api-call',
- })
- ).to.equal(true)
- })
- })
- })
- describe('leaveProject', function () {
- beforeEach(function (ctx) {
- ctx.DocumentUpdaterManager.flushProjectToMongoAndDelete = sinon
- .stub()
- .callsArg(1)
- ctx.ConnectedUsersManager.markUserAsDisconnected = sinon
- .stub()
- .callsArg(2)
- ctx.WebsocketLoadBalancer.emitToRoom = sinon.stub()
- ctx.RoomManager.leaveProjectAndDocs = sinon.stub()
- ctx.clientsInRoom = []
- ctx.io = {
- sockets: {
- clients: roomId => {
- if (roomId !== ctx.project_id) {
- throw 'expected room_id to be project_id'
- }
- return ctx.clientsInRoom
- },
- },
- }
- ctx.client.ol_context.project_id = ctx.project_id
- ctx.client.ol_context.user_id = ctx.user_id
- ctx.WebsocketController.FLUSH_IF_EMPTY_DELAY = 0
- tk.reset()
- }) // Allow setTimeout to work.
- describe('when the client did not joined a project yet', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {}
- ctx.WebsocketController.leaveProject(ctx.io, ctx.client, err => {
- if (err) return reject(err)
- resolve()
- })
- })
- })
- it('should bail out when calling leaveProject', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom.called.should.equal(false)
- ctx.RoomManager.leaveProjectAndDocs.called.should.equal(false)
- ctx.ConnectedUsersManager.markUserAsDisconnected.called.should.equal(
- false
- )
- })
- it('should not inc any metric', function (ctx) {
- ctx.metrics.inc.called.should.equal(false)
- })
- })
- describe('when the project is empty', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.clientsInRoom = []
- ctx.WebsocketController.leaveProject(ctx.io, ctx.client, err => {
- if (err) return reject(err)
- resolve()
- })
- })
- })
- it('should end clientTracking.clientDisconnected to the project room', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientDisconnected',
- ctx.client.publicId
- )
- .should.equal(true)
- })
- it('should mark the user as disconnected', function (ctx) {
- ctx.ConnectedUsersManager.markUserAsDisconnected
- .calledWith(ctx.project_id, ctx.client.publicId)
- .should.equal(true)
- })
- it('should flush the project in the document updater', function (ctx) {
- ctx.DocumentUpdaterManager.flushProjectToMongoAndDelete
- .calledWith(ctx.project_id)
- .should.equal(true)
- })
- it('should increment the leave-project metric', function (ctx) {
- ctx.metrics.inc.calledWith('editor.leave-project').should.equal(true)
- })
- it('should track the disconnection in RoomManager', function (ctx) {
- ctx.RoomManager.leaveProjectAndDocs
- .calledWith(ctx.client)
- .should.equal(true)
- })
- })
- describe('when the project is not empty', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.clientsInRoom = ['mock-remaining-client']
- ctx.io = {
- sockets: {
- clients: roomId => {
- if (roomId !== ctx.project_id) {
- throw 'expected room_id to be project_id'
- }
- return ctx.clientsInRoom
- },
- },
- }
- ctx.WebsocketController.leaveProject(ctx.io, ctx.client, err => {
- if (err) return reject(err)
- resolve()
- })
- })
- })
- it('should not flush the project in the document updater', function (ctx) {
- ctx.DocumentUpdaterManager.flushProjectToMongoAndDelete.called.should.equal(
- false
- )
- })
- })
- describe('when client has not authenticated', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context.user_id = null
- ctx.client.ol_context.project_id = null
- ctx.WebsocketController.leaveProject(ctx.io, ctx.client, err => {
- if (err) return reject(err)
- resolve()
- })
- })
- })
- it('should not end clientTracking.clientDisconnected to the project room', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientDisconnected',
- ctx.client.publicId
- )
- .should.equal(false)
- })
- it('should not mark the user as disconnected', function (ctx) {
- ctx.ConnectedUsersManager.markUserAsDisconnected
- .calledWith(ctx.project_id, ctx.client.publicId)
- .should.equal(false)
- })
- it('should not flush the project in the document updater', function (ctx) {
- ctx.DocumentUpdaterManager.flushProjectToMongoAndDelete
- .calledWith(ctx.project_id)
- .should.equal(false)
- })
- it('should not increment the leave-project metric', function (ctx) {
- ctx.metrics.inc.calledWith('editor.leave-project').should.equal(false)
- })
- })
- describe('when client has not joined a project', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context.user_id = ctx.user_id
- ctx.client.ol_context.project_id = null
- ctx.WebsocketController.leaveProject(ctx.io, ctx.client, err => {
- if (err) return reject(err)
- resolve()
- })
- })
- })
- it('should not end clientTracking.clientDisconnected to the project room', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientDisconnected',
- ctx.client.publicId
- )
- .should.equal(false)
- })
- it('should not mark the user as disconnected', function (ctx) {
- ctx.ConnectedUsersManager.markUserAsDisconnected
- .calledWith(ctx.project_id, ctx.client.publicId)
- .should.equal(false)
- })
- it('should not flush the project in the document updater', function (ctx) {
- ctx.DocumentUpdaterManager.flushProjectToMongoAndDelete
- .calledWith(ctx.project_id)
- .should.equal(false)
- })
- it('should not increment the leave-project metric', function (ctx) {
- ctx.metrics.inc.calledWith('editor.leave-project').should.equal(false)
- })
- })
- })
- describe('joinDoc', function () {
- beforeEach(function (ctx) {
- ctx.doc_id = 'doc-id-123'
- ctx.doc_lines = ['doc', 'lines']
- ctx.version = 42
- ctx.ops = ['mock', 'ops']
- ctx.ranges = { mock: 'ranges' }
- ctx.options = {}
- ctx.client.ol_context.project_id = ctx.project_id
- ctx.client.ol_context.is_restricted_user = false
- ctx.AuthorizationManager.addAccessToDoc = sinon.stub().yields()
- ctx.AuthorizationManager.assertClientCanViewProject = sinon
- .stub()
- .callsArgWith(1, null)
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc = sinon
- .stub()
- .callsArgWith(2, null)
- ctx.DocumentUpdaterManager.getDocument = sinon
- .stub()
- .callsArgWith(3, null, ctx.doc_lines, ctx.version, ctx.ranges, ctx.ops)
- ctx.RoomManager.joinDoc = sinon.stub().callsArg(2)
- })
- describe('works', function () {
- beforeEach(function (ctx) {
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should inc the joinLeaveEpoch', function (ctx) {
- expect(ctx.client.joinLeaveEpoch).to.equal(1)
- })
- it('should check that the client is authorized to view the project', function (ctx) {
- ctx.AuthorizationManager.assertClientCanViewProject
- .calledWith(ctx.client)
- .should.equal(true)
- })
- it('should get the document from the DocumentUpdaterManager with fromVersion', function (ctx) {
- ctx.DocumentUpdaterManager.getDocument
- .calledWith(ctx.project_id, ctx.doc_id, -1)
- .should.equal(true)
- })
- it('should add permissions for the client to access the doc', function (ctx) {
- ctx.AuthorizationManager.addAccessToDoc
- .calledWith(ctx.client, ctx.doc_id)
- .should.equal(true)
- })
- it('should join the client to room for the doc_id', function (ctx) {
- ctx.RoomManager.joinDoc
- .calledWith(ctx.client, ctx.doc_id)
- .should.equal(true)
- })
- it('should call the callback with the lines, version, ranges and ops', function (ctx) {
- ctx.callback
- .calledWith(null, ctx.doc_lines, ctx.version, ctx.ops, ctx.ranges)
- .should.equal(true)
- })
- it('should increment the join-doc metric', function (ctx) {
- ctx.metrics.inc.calledWith('editor.join-doc').should.equal(true)
- })
- })
- describe('with a fromVersion', function () {
- beforeEach(function (ctx) {
- ctx.fromVersion = 40
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- ctx.fromVersion,
- ctx.options,
- ctx.callback
- )
- })
- it('should get the document from the DocumentUpdaterManager with fromVersion', function (ctx) {
- ctx.DocumentUpdaterManager.getDocument
- .calledWith(ctx.project_id, ctx.doc_id, ctx.fromVersion)
- .should.equal(true)
- })
- })
- describe('with doclines that need escaping', function () {
- beforeEach(function (ctx) {
- ctx.doc_lines.push(['räksmörgås'])
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should call the callback with the escaped lines', function (ctx) {
- const escapedLines = ctx.callback.args[0][1]
- const escapedWord = escapedLines.pop()
- escapedWord.should.equal('räksmörgås')
- // Check that unescaping works
- decodeURIComponent(escape(escapedWord)).should.equal('räksmörgås')
- })
- })
- describe('with comments that need encoding', function () {
- beforeEach(function (ctx) {
- ctx.ranges.comments = [{ op: { c: 'räksmörgås' } }]
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- { encodeRanges: true },
- ctx.callback
- )
- })
- it('should call the callback with the encoded comment', function (ctx) {
- const encodedComments = ctx.callback.args[0][4]
- const encodedComment = encodedComments.comments.pop()
- const encodedCommentText = encodedComment.op.c
- encodedCommentText.should.equal('räksmörgås')
- })
- })
- describe('with changes that need encoding', function () {
- it('should call the callback with the encoded insert change', function (ctx) {
- ctx.ranges.changes = [{ op: { i: 'räksmörgås' } }]
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- { encodeRanges: true },
- ctx.callback
- )
- const encodedChanges = ctx.callback.args[0][4]
- const encodedChange = encodedChanges.changes.pop()
- const encodedChangeText = encodedChange.op.i
- encodedChangeText.should.equal('räksmörgås')
- })
- it('should call the callback with the encoded delete change', function (ctx) {
- ctx.ranges.changes = [{ op: { d: 'räksmörgås' } }]
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- { encodeRanges: true },
- ctx.callback
- )
- const encodedChanges = ctx.callback.args[0][4]
- const encodedChange = encodedChanges.changes.pop()
- const encodedChangeText = encodedChange.op.d
- encodedChangeText.should.equal('räksmörgås')
- })
- })
- describe('when not authorized', function () {
- beforeEach(function (ctx) {
- ctx.AuthorizationManager.assertClientCanViewProject = sinon
- .stub()
- .callsArgWith(1, (ctx.err = new Error('not authorized')))
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should call the callback with an error', function (ctx) {
- ctx.callback
- .calledWith(sinon.match({ message: 'not authorized' }))
- .should.equal(true)
- })
- it('should not call the DocumentUpdaterManager', function (ctx) {
- ctx.DocumentUpdaterManager.getDocument.called.should.equal(false)
- })
- })
- describe('with a restricted client', function () {
- beforeEach(function (ctx) {
- ctx.ranges.comments = [{ op: { a: 1 } }, { op: { a: 2 } }]
- ctx.client.ol_context.is_restricted_user = true
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should overwrite ranges.comments with an empty list', function (ctx) {
- const ranges = ctx.callback.args[0][4]
- expect(ranges.comments).to.deep.equal([])
- })
- })
- describe('when the client has disconnected', function () {
- beforeEach(function (ctx) {
- ctx.client.disconnected = true
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should increment the editor.join-doc.disconnected metric with a status', function (ctx) {
- expect(
- ctx.metrics.inc.calledWith('editor.join-doc.disconnected', 1, {
- status: 'immediately',
- })
- ).to.equal(true)
- })
- it('should not get the document', function (ctx) {
- expect(ctx.DocumentUpdaterManager.getDocument.called).to.equal(false)
- })
- })
- describe('when the client disconnects while auth checks are running', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(
- new Error()
- )
- ctx.DocumentUpdaterManager.checkDocument = (projectId, docId, cb) => {
- ctx.client.disconnected = true
- cb()
- }
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- (...args) => {
- ctx.callback(...args)
- resolve()
- }
- )
- })
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.called).to.equal(true)
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should increment the editor.join-doc.disconnected metric with a status', function (ctx) {
- expect(
- ctx.metrics.inc.calledWith('editor.join-doc.disconnected', 1, {
- status: 'after-client-auth-check',
- })
- ).to.equal(true)
- })
- it('should not get the document', function (ctx) {
- expect(ctx.DocumentUpdaterManager.getDocument.called).to.equal(false)
- })
- })
- describe('when the client starts a parallel joinDoc request', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(
- new Error()
- )
- ctx.DocumentUpdaterManager.checkDocument = (projectId, docId, cb) => {
- ctx.DocumentUpdaterManager.checkDocument = sinon.stub().yields()
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- {},
- () => {}
- )
- cb()
- }
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- (...args) => {
- ctx.callback(...args)
- // make sure the other joinDoc request completed
- setTimeout(resolve, 5)
- }
- )
- })
- })
- it('should call the callback with an error', function (ctx) {
- expect(ctx.callback.called).to.equal(true)
- expect(ctx.callback.args[0][0].message).to.equal(
- 'joinLeaveEpoch mismatch'
- )
- })
- it('should get the document once (the parallel request wins)', function (ctx) {
- expect(ctx.DocumentUpdaterManager.getDocument.callCount).to.equal(1)
- })
- })
- describe('when the client starts a parallel leaveDoc request', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.RoomManager.leaveDoc = sinon.stub()
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(
- new Error()
- )
- ctx.DocumentUpdaterManager.checkDocument = (projectId, docId, cb) => {
- ctx.WebsocketController.leaveDoc(ctx.client, ctx.doc_id, () => {})
- cb()
- }
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- (...args) => {
- ctx.callback(...args)
- resolve()
- }
- )
- })
- })
- it('should call the callback with an error', function (ctx) {
- expect(ctx.callback.called).to.equal(true)
- expect(ctx.callback.args[0][0].message).to.equal(
- 'joinLeaveEpoch mismatch'
- )
- })
- it('should not get the document', function (ctx) {
- expect(ctx.DocumentUpdaterManager.getDocument.called).to.equal(false)
- })
- })
- describe('when the client disconnects while RoomManager.joinDoc is running', function () {
- beforeEach(function (ctx) {
- ctx.RoomManager.joinDoc = (client, docId, cb) => {
- ctx.client.disconnected = true
- cb()
- }
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should increment the editor.join-doc.disconnected metric with a status', function (ctx) {
- expect(
- ctx.metrics.inc.calledWith('editor.join-doc.disconnected', 1, {
- status: 'after-joining-room',
- })
- ).to.equal(true)
- })
- it('should not get the document', function (ctx) {
- expect(ctx.DocumentUpdaterManager.getDocument.called).to.equal(false)
- })
- })
- describe('when the client disconnects while DocumentUpdaterManager.getDocument is running', function () {
- beforeEach(function (ctx) {
- ctx.DocumentUpdaterManager.getDocument = (
- projectId,
- docId,
- fromVersion,
- callback
- ) => {
- ctx.client.disconnected = true
- callback(null, ctx.doc_lines, ctx.version, ctx.ranges, ctx.ops)
- }
- ctx.WebsocketController.joinDoc(
- ctx.client,
- ctx.doc_id,
- -1,
- ctx.options,
- ctx.callback
- )
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should increment the editor.join-doc.disconnected metric with a status', function (ctx) {
- expect(
- ctx.metrics.inc.calledWith('editor.join-doc.disconnected', 1, {
- status: 'after-doc-updater-call',
- })
- ).to.equal(true)
- })
- })
- })
- describe('leaveDoc', function () {
- beforeEach(function (ctx) {
- ctx.doc_id = 'doc-id-123'
- ctx.client.ol_context.project_id = ctx.project_id
- ctx.RoomManager.leaveDoc = sinon.stub()
- ctx.WebsocketController.leaveDoc(ctx.client, ctx.doc_id, ctx.callback)
- })
- it('should inc the joinLeaveEpoch', function (ctx) {
- expect(ctx.client.joinLeaveEpoch).to.equal(1)
- })
- it('should remove the client from the doc_id room', function (ctx) {
- ctx.RoomManager.leaveDoc
- .calledWith(ctx.client, ctx.doc_id)
- .should.equal(true)
- })
- it('should call the callback', function (ctx) {
- ctx.callback.called.should.equal(true)
- })
- it('should increment the leave-doc metric', function (ctx) {
- ctx.metrics.inc.calledWith('editor.leave-doc').should.equal(true)
- })
- })
- describe('getConnectedUsers', function () {
- beforeEach(function (ctx) {
- ctx.client.ol_context.project_id = ctx.project_id
- ctx.users = ['mock', 'users']
- ctx.WebsocketLoadBalancer.emitToRoom = sinon.stub()
- ctx.ConnectedUsersManager.getConnectedUsers = sinon
- .stub()
- .callsArgWith(1, null, ctx.users)
- })
- describe('when authorized', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanViewProject = sinon
- .stub()
- .callsArgWith(1, null)
- ctx.WebsocketController.getConnectedUsers(ctx.client, (...args) => {
- ctx.callback(...Array.from(args || []))
- resolve()
- })
- })
- })
- it('should check that the client is authorized to view the project', function (ctx) {
- ctx.AuthorizationManager.assertClientCanViewProject
- .calledWith(ctx.client)
- .should.equal(true)
- })
- it('should broadcast a request to update the client list', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(ctx.project_id, 'clientTracking.refresh')
- .should.equal(true)
- })
- it('should get the connected users for the project', function (ctx) {
- ctx.ConnectedUsersManager.getConnectedUsers
- .calledWith(ctx.project_id)
- .should.equal(true)
- })
- it('should the users', function (ctx) {
- ctx.callback.calledWith(null, ctx.users).should.equal(true)
- })
- it('should increment the get-connected-users metric', function (ctx) {
- ctx.metrics.inc
- .calledWith('editor.get-connected-users')
- .should.equal(true)
- })
- })
- describe('when not authorized', function () {
- beforeEach(function (ctx) {
- ctx.AuthorizationManager.assertClientCanViewProject = sinon
- .stub()
- .callsArgWith(1, (ctx.err = new Error('not authorized')))
- ctx.WebsocketController.getConnectedUsers(ctx.client, ctx.callback)
- })
- it('should not get the connected users for the project', function (ctx) {
- ctx.ConnectedUsersManager.getConnectedUsers.called.should.equal(false)
- })
- it('should return an error', function (ctx) {
- ctx.callback.calledWith(ctx.err).should.equal(true)
- })
- })
- describe('when restricted user', function () {
- beforeEach(function (ctx) {
- ctx.client.ol_context.is_restricted_user = true
- ctx.AuthorizationManager.assertClientCanViewProject = sinon
- .stub()
- .callsArgWith(1, null)
- ctx.WebsocketController.getConnectedUsers(ctx.client, ctx.callback)
- })
- it('should return an empty array of users', function (ctx) {
- ctx.callback.calledWith(null, []).should.equal(true)
- })
- it('should not get the connected users for the project', function (ctx) {
- ctx.ConnectedUsersManager.getConnectedUsers.called.should.equal(false)
- })
- })
- describe('when the client has disconnected', function () {
- beforeEach(function (ctx) {
- ctx.client.disconnected = true
- ctx.AuthorizationManager.assertClientCanViewProject = sinon.stub()
- ctx.WebsocketController.getConnectedUsers(ctx.client, ctx.callback)
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should not check permissions', function (ctx) {
- expect(
- ctx.AuthorizationManager.assertClientCanViewProject.called
- ).to.equal(false)
- })
- })
- })
- describe('updateClientPosition', function () {
- beforeEach(function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom = sinon.stub()
- ctx.ConnectedUsersManager.updateUserPosition = sinon
- .stub()
- .callsArgAsync(4)
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc = sinon
- .stub()
- .callsArgWith(2, null)
- ctx.update = {
- doc_id: (ctx.doc_id = 'doc-id-123'),
- row: (ctx.row = 42),
- column: (ctx.column = 37),
- }
- })
- describe('with a logged in user', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {
- project_id: ctx.project_id,
- first_name: (ctx.first_name = 'Douglas'),
- last_name: (ctx.last_name = 'Adams'),
- email: (ctx.email = 'joe@example.com'),
- user_id: (ctx.user_id = 'user-id-123'),
- }
- ctx.populatedCursorData = {
- doc_id: ctx.doc_id,
- id: ctx.client.publicId,
- name: `${ctx.first_name} ${ctx.last_name}`,
- row: ctx.row,
- column: ctx.column,
- email: ctx.email,
- user_id: ctx.user_id,
- }
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- err => {
- if (err) return reject(err)
- resolve()
- }
- )
- })
- })
- it("should send the update to the project room with the user's name", function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientUpdated',
- ctx.populatedCursorData
- )
- .should.equal(true)
- })
- it('should send the cursor data to the connected user manager', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.ConnectedUsersManager.updateUserPosition
- .calledWith(
- ctx.project_id,
- ctx.client.publicId,
- {
- _id: ctx.user_id,
- email: ctx.email,
- first_name: ctx.first_name,
- last_name: ctx.last_name,
- },
- {
- row: ctx.row,
- column: ctx.column,
- doc_id: ctx.doc_id,
- }
- )
- .should.equal(true)
- resolve()
- })
- })
- it('should increment the update-client-position metric at 0.1 frequency', function (ctx) {
- ctx.metrics.inc
- .calledWith('editor.update-client-position', 0.1)
- .should.equal(true)
- })
- })
- describe('with a logged in user who has no last_name set', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {
- project_id: ctx.project_id,
- first_name: (ctx.first_name = 'Douglas'),
- last_name: undefined,
- email: (ctx.email = 'joe@example.com'),
- user_id: (ctx.user_id = 'user-id-123'),
- }
- ctx.populatedCursorData = {
- doc_id: ctx.doc_id,
- id: ctx.client.publicId,
- name: `${ctx.first_name}`,
- row: ctx.row,
- column: ctx.column,
- email: ctx.email,
- user_id: ctx.user_id,
- }
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- err => {
- if (err) return reject(err)
- resolve()
- }
- )
- })
- })
- it("should send the update to the project room with the user's name", function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientUpdated',
- ctx.populatedCursorData
- )
- .should.equal(true)
- })
- it('should send the cursor data to the connected user manager', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.ConnectedUsersManager.updateUserPosition
- .calledWith(
- ctx.project_id,
- ctx.client.publicId,
- {
- _id: ctx.user_id,
- email: ctx.email,
- first_name: ctx.first_name,
- last_name: undefined,
- },
- {
- row: ctx.row,
- column: ctx.column,
- doc_id: ctx.doc_id,
- }
- )
- .should.equal(true)
- resolve()
- })
- })
- it('should increment the update-client-position metric at 0.1 frequency', function (ctx) {
- ctx.metrics.inc
- .calledWith('editor.update-client-position', 0.1)
- .should.equal(true)
- })
- })
- describe('with a logged in user who has no first_name set', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {
- project_id: ctx.project_id,
- first_name: undefined,
- last_name: (ctx.last_name = 'Adams'),
- email: (ctx.email = 'joe@example.com'),
- user_id: (ctx.user_id = 'user-id-123'),
- }
- ctx.populatedCursorData = {
- doc_id: ctx.doc_id,
- id: ctx.client.publicId,
- name: `${ctx.last_name}`,
- row: ctx.row,
- column: ctx.column,
- email: ctx.email,
- user_id: ctx.user_id,
- }
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- err => {
- if (err) return reject(err)
- resolve()
- }
- )
- })
- })
- it("should send the update to the project room with the user's name", function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(
- ctx.project_id,
- 'clientTracking.clientUpdated',
- ctx.populatedCursorData
- )
- .should.equal(true)
- })
- it('should send the cursor data to the connected user manager', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.ConnectedUsersManager.updateUserPosition
- .calledWith(
- ctx.project_id,
- ctx.client.publicId,
- {
- _id: ctx.user_id,
- email: ctx.email,
- first_name: undefined,
- last_name: ctx.last_name,
- },
- {
- row: ctx.row,
- column: ctx.column,
- doc_id: ctx.doc_id,
- }
- )
- .should.equal(true)
- resolve()
- })
- })
- it('should increment the update-client-position metric at 0.1 frequency', function (ctx) {
- ctx.metrics.inc
- .calledWith('editor.update-client-position', 0.1)
- .should.equal(true)
- })
- })
- describe('with a logged in user who has no names set', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {
- project_id: ctx.project_id,
- first_name: undefined,
- last_name: undefined,
- email: (ctx.email = 'joe@example.com'),
- user_id: (ctx.user_id = 'user-id-123'),
- }
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- err => {
- if (err) return reject(err)
- resolve()
- }
- )
- })
- })
- it('should send the update to the project name with no name', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(ctx.project_id, 'clientTracking.clientUpdated', {
- doc_id: ctx.doc_id,
- id: ctx.client.publicId,
- user_id: ctx.user_id,
- name: '',
- row: ctx.row,
- column: ctx.column,
- email: ctx.email,
- })
- .should.equal(true)
- })
- })
- describe('with an anonymous user', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.ol_context = {
- project_id: ctx.project_id,
- }
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- err => {
- if (err) return reject(err)
- resolve()
- }
- )
- })
- })
- it('should send the update to the project room with no name', function (ctx) {
- ctx.WebsocketLoadBalancer.emitToRoom
- .calledWith(ctx.project_id, 'clientTracking.clientUpdated', {
- doc_id: ctx.doc_id,
- id: ctx.client.publicId,
- name: '',
- row: ctx.row,
- column: ctx.column,
- })
- .should.equal(true)
- })
- it('should not send cursor data to the connected user manager', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.ConnectedUsersManager.updateUserPosition.called.should.equal(
- false
- )
- resolve()
- })
- })
- })
- describe('when the client has disconnected', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.disconnected = true
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc =
- sinon.stub()
- ctx.WebsocketController.updateClientPosition(
- ctx.client,
- ctx.update,
- (...args) => {
- ctx.callback(...args)
- if (args[0]) return reject(args[0])
- resolve()
- }
- )
- })
- })
- it('should call the callback with no details', function (ctx) {
- expect(ctx.callback.args[0]).to.deep.equal([])
- })
- it('should not check permissions', function (ctx) {
- expect(
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.called
- ).to.equal(false)
- })
- })
- })
- describe('applyOtUpdate', function () {
- beforeEach(function (ctx) {
- ctx.update = { op: { p: 12, t: 'foo' } }
- ctx.client.ol_context.user_id = ctx.user_id
- ctx.client.ol_context.project_id = ctx.project_id
- ctx.WebsocketController._assertClientCanApplyUpdate = sinon
- .stub()
- .yields()
- ctx.DocumentUpdaterManager.queueChange = sinon.stub().callsArg(3)
- })
- describe('succesfully', function () {
- beforeEach(function (ctx) {
- ctx.WebsocketController.applyOtUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.update,
- ctx.callback
- )
- })
- it('should set the source of the update to the client id', function (ctx) {
- ctx.update.meta.source.should.equal(ctx.client.publicId)
- })
- it('should set the user_id of the update to the user id', function (ctx) {
- ctx.update.meta.user_id.should.equal(ctx.user_id)
- })
- it('should queue the update', function (ctx) {
- ctx.DocumentUpdaterManager.queueChange
- .calledWith(ctx.project_id, ctx.doc_id, ctx.update)
- .should.equal(true)
- })
- it('should call the callback', function (ctx) {
- ctx.callback.called.should.equal(true)
- })
- it('should increment the doc updates', function (ctx) {
- ctx.metrics.inc.calledWith('editor.doc-update').should.equal(true)
- })
- })
- describe('unsuccessfully', function () {
- beforeEach(function (ctx) {
- ctx.client.disconnect = sinon.stub()
- ctx.DocumentUpdaterManager.queueChange = sinon
- .stub()
- .callsArgWith(3, (ctx.error = new Error('Something went wrong')))
- ctx.WebsocketController.applyOtUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.update,
- ctx.callback
- )
- })
- it('should disconnect the client', function (ctx) {
- ctx.client.disconnect.called.should.equal(true)
- })
- it('should not log an error', function (ctx) {
- ctx.logger.error.called.should.equal(false)
- })
- it('should call the callback with the error', function (ctx) {
- ctx.callback.calledWith(ctx.error).should.equal(true)
- })
- })
- describe('when not authorized', function () {
- beforeEach(function (ctx) {
- ctx.client.disconnect = sinon.stub()
- ctx.WebsocketController._assertClientCanApplyUpdate = sinon
- .stub()
- .yields((ctx.error = new Error('not authorized')))
- ctx.WebsocketController.applyOtUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.update,
- ctx.callback
- )
- })
- // This happens in a setTimeout to allow the client a chance to receive the error first.
- // I'm not sure how to unit test, but it is acceptance tested.
- // it "should disconnect the client", ->
- // @client.disconnect.called.should.equal true
- it('should not log a warning', function (ctx) {
- ctx.logger.warn.called.should.equal(false)
- })
- it('should call the callback with the error', function (ctx) {
- ctx.callback.calledWith(ctx.error).should.equal(true)
- })
- })
- describe('update_too_large', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.disconnect = sinon.stub()
- ctx.client.emit = sinon.stub()
- ctx.client.ol_context.user_id = ctx.user_id
- ctx.client.ol_context.project_id = ctx.project_id
- const error = new UpdateTooLargeError(7372835)
- ctx.DocumentUpdaterManager.queueChange = sinon
- .stub()
- .callsArgWith(3, error)
- ctx.WebsocketController.applyOtUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.update,
- ctx.callback
- )
- setTimeout(() => resolve(), 1)
- })
- })
- it('should call the callback with no error', function (ctx) {
- ctx.callback.called.should.equal(true)
- ctx.callback.args[0].should.deep.equal([])
- })
- it('should log a warning with the size and context', function (ctx) {
- ctx.logger.warn.called.should.equal(true)
- ctx.logger.warn.args[0].should.deep.equal([
- {
- userId: ctx.user_id,
- projectId: ctx.project_id,
- docId: ctx.doc_id,
- updateSize: 7372835,
- },
- 'update is too large',
- ])
- })
- describe('after 100ms', function () {
- beforeEach(async function () {
- await new Promise(resolve => {
- setTimeout(resolve, 100)
- })
- })
- it('should send an otUpdateError the client', function (ctx) {
- ctx.client.emit.calledWith('otUpdateError').should.equal(true)
- })
- it('should disconnect the client', function (ctx) {
- ctx.client.disconnect.called.should.equal(true)
- })
- })
- describe('when the client disconnects during the next 100ms', function () {
- beforeEach(async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.client.disconnected = true
- setTimeout(resolve, 100)
- })
- })
- it('should not send an otUpdateError the client', function (ctx) {
- ctx.client.emit.calledWith('otUpdateError').should.equal(false)
- })
- it('should not disconnect the client', function (ctx) {
- ctx.client.disconnect.called.should.equal(false)
- })
- it('should increment the editor.doc-update.disconnected metric with a status', function (ctx) {
- expect(
- ctx.metrics.inc.calledWith('editor.doc-update.disconnected', 1, {
- status: 'at-otUpdateError',
- })
- ).to.equal(true)
- })
- })
- })
- })
- describe('_assertClientCanApplyUpdate', function () {
- beforeEach(function (ctx) {
- ctx.edit_update = {
- op: [
- { i: 'foo', p: 42 },
- { c: 'bar', p: 132 },
- ],
- } // comments may still be in an edit op
- ctx.comment_update = { op: [{ c: 'bar', p: 132 }] }
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc = sinon.stub()
- ctx.AuthorizationManager.assertClientCanReviewProjectAndDoc = sinon.stub()
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc = sinon.stub()
- })
- describe('with a read-write client', function () {
- it('should return successfully', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(null)
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.edit_update,
- error => {
- expect(error).to.be.null
- resolve()
- }
- )
- })
- })
- })
- describe('with a read-only client and an edit op', function () {
- it('should return an error', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(null)
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.edit_update,
- error => {
- expect(error.message).to.equal('not authorized')
- resolve()
- }
- )
- })
- })
- })
- describe('with a read-only client and a comment op', function () {
- it('should return successfully', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(null)
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.comment_update,
- error => {
- expect(error).to.be.null
- resolve()
- }
- )
- })
- })
- })
- describe('with a totally unauthorized client', function () {
- it('should return an error', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- ctx.comment_update,
- error => {
- expect(error.message).to.equal('not authorized')
- resolve()
- }
- )
- })
- })
- })
- describe('with a review client', function () {
- it('op with tc should succeed', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(null)
- ctx.AuthorizationManager.assertClientCanReviewProjectAndDoc.yields(
- null
- )
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- { op: [{ p: 10, i: 'a' }], meta: { tc: '123456' } },
- error => {
- expect(error).to.be.null
- resolve()
- }
- )
- })
- })
- it('op without tc should fail', async function (ctx) {
- await new Promise((resolve, reject) => {
- ctx.AuthorizationManager.assertClientCanEditProjectAndDoc.yields(
- new Error('not authorized')
- )
- ctx.AuthorizationManager.assertClientCanViewProjectAndDoc.yields(null)
- ctx.AuthorizationManager.assertClientCanReviewProjectAndDoc.yields(
- null
- )
- ctx.WebsocketController._assertClientCanApplyUpdate(
- ctx.client,
- ctx.doc_id,
- { op: [{ p: 10, i: 'a' }] },
- error => {
- expect(error.message).to.equal('not authorized')
- resolve()
- }
- )
- })
- })
- })
- })
- })
|