| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280 |
- sinon = require('sinon')
- chai = require('chai')
- should = chai.should()
- modulePath = "../../../../app/js/UpdateManager.js"
- SandboxedModule = require('sandboxed-module')
- describe "UpdateManager", ->
- beforeEach ->
- @project_id = "project-id-123"
- @doc_id = "document-id-123"
- @callback = sinon.stub()
- @UpdateManager = SandboxedModule.require modulePath, requires:
- "./LockManager" : @LockManager = {}
- "./RedisManager" : @RedisManager = {}
- "./WebRedisManager" : @WebRedisManager = {}
- "./ShareJsUpdateManager" : @ShareJsUpdateManager = {}
- "./HistoryManager" : @HistoryManager = {}
- "logger-sharelatex": @logger = { log: sinon.stub() }
- "./Metrics": @Metrics =
- Timer: class Timer
- done: sinon.stub()
- "settings-sharelatex": Settings = {}
- "./DocumentManager": @DocumentManager = {}
- "./TrackChangesManager": @TrackChangesManager = {}
- describe "processOutstandingUpdates", ->
- beforeEach ->
- @UpdateManager.fetchAndApplyUpdates = sinon.stub().callsArg(2)
- @UpdateManager.processOutstandingUpdates @project_id, @doc_id, @callback
- it "should apply the updates", ->
- @UpdateManager.fetchAndApplyUpdates.calledWith(@project_id, @doc_id).should.equal true
- it "should call the callback", ->
- @callback.called.should.equal true
- it "should time the execution", ->
- @Metrics.Timer::done.called.should.equal true
- describe "processOutstandingUpdatesWithLock", ->
- describe "when the lock is free", ->
- beforeEach ->
- @LockManager.tryLock = sinon.stub().callsArgWith(1, null, true, @lockValue = "mock-lock-value")
- @LockManager.releaseLock = sinon.stub().callsArg(2)
- @UpdateManager.continueProcessingUpdatesWithLock = sinon.stub().callsArg(2)
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArg(2)
- describe "successfully", ->
- beforeEach ->
- @UpdateManager.processOutstandingUpdatesWithLock @project_id, @doc_id, @callback
- it "should acquire the lock", ->
- @LockManager.tryLock.calledWith(@doc_id).should.equal true
- it "should free the lock", ->
- @LockManager.releaseLock.calledWith(@doc_id, @lockValue).should.equal true
- it "should process the outstanding updates", ->
- @UpdateManager.processOutstandingUpdates.calledWith(@project_id, @doc_id).should.equal true
-
- it "should do everything with the lock acquired", ->
- @UpdateManager.processOutstandingUpdates.calledAfter(@LockManager.tryLock).should.equal true
- @UpdateManager.processOutstandingUpdates.calledBefore(@LockManager.releaseLock).should.equal true
- it "should continue processing new updates that may have come in", ->
- @UpdateManager.continueProcessingUpdatesWithLock.calledWith(@project_id, @doc_id).should.equal true
-
- it "should return the callback", ->
- @callback.called.should.equal true
- describe "when processOutstandingUpdates returns an error", ->
- beforeEach ->
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArgWith(2, @error = new Error("Something went wrong"))
- @UpdateManager.processOutstandingUpdatesWithLock @project_id, @doc_id, @callback
- it "should free the lock", ->
- @LockManager.releaseLock.calledWith(@doc_id, @lockValue).should.equal true
-
- it "should return the error in the callback", ->
- @callback.calledWith(@error).should.equal true
- describe "when the lock is taken", ->
- beforeEach ->
- @LockManager.tryLock = sinon.stub().callsArgWith(1, null, false)
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArg(2)
- @UpdateManager.processOutstandingUpdatesWithLock @project_id, @doc_id, @callback
- it "should return the callback", ->
- @callback.called.should.equal true
- it "should not process the updates", ->
- @UpdateManager.processOutstandingUpdates.called.should.equal false
-
- describe "continueProcessingUpdatesWithLock", ->
- describe "when there are outstanding updates", ->
- beforeEach ->
- @WebRedisManager.getUpdatesLength = sinon.stub().callsArgWith(1, null, 3)
- @UpdateManager.processOutstandingUpdatesWithLock = sinon.stub().callsArg(2)
- @UpdateManager.continueProcessingUpdatesWithLock @project_id, @doc_id, @callback
- it "should process the outstanding updates", ->
- @UpdateManager.processOutstandingUpdatesWithLock.calledWith(@project_id, @doc_id).should.equal true
- it "should return the callback", ->
- @callback.called.should.equal true
- describe "when there are no outstanding updates", ->
- beforeEach ->
- @WebRedisManager.getUpdatesLength = sinon.stub().callsArgWith(1, null, 0)
- @UpdateManager.processOutstandingUpdatesWithLock = sinon.stub().callsArg(2)
- @UpdateManager.continueProcessingUpdatesWithLock @project_id, @doc_id, @callback
- it "should not try to process the outstanding updates", ->
- @UpdateManager.processOutstandingUpdatesWithLock.called.should.equal false
- it "should return the callback", ->
- @callback.called.should.equal true
- describe "fetchAndApplyUpdates", ->
- describe "with updates", ->
- beforeEach ->
- @updates = [{p: 1, t: "foo"}]
- @updatedDocLines = ["updated", "lines"]
- @version = 34
- @WebRedisManager.getPendingUpdatesForDoc = sinon.stub().callsArgWith(1, null, @updates)
- @UpdateManager.applyUpdate = sinon.stub().callsArgWith(3, null, @updatedDocLines, @version)
- @UpdateManager.fetchAndApplyUpdates @project_id, @doc_id, @callback
- it "should get the pending updates", ->
- @WebRedisManager.getPendingUpdatesForDoc.calledWith(@doc_id).should.equal true
- it "should apply the updates", ->
- for update in @updates
- @UpdateManager.applyUpdate
- .calledWith(@project_id, @doc_id, update)
- .should.equal true
-
- it "should call the callback", ->
- @callback.called.should.equal true
- describe "when there are no updates", ->
- beforeEach ->
- @updates = []
- @WebRedisManager.getPendingUpdatesForDoc = sinon.stub().callsArgWith(1, null, @updates)
- @UpdateManager.applyUpdate = sinon.stub()
- @RedisManager.setDocument = sinon.stub()
- @UpdateManager.fetchAndApplyUpdates @project_id, @doc_id, @callback
- it "should not call applyUpdate", ->
- @UpdateManager.applyUpdate.called.should.equal false
- it "should call the callback", ->
- @callback.called.should.equal true
-
- describe "applyUpdate", ->
- beforeEach ->
- @update = {op: [{p: 42, i: "foo"}]}
- @updatedDocLines = ["updated", "lines"]
- @version = 34
- @lines = ["original", "lines"]
- @track_changes_entries = { entries: "mock", comments: "mock" }
- @updated_track_changes_entries = { entries: "updated", comments: "updated" }
- @appliedOps = ["mock-applied-ops"]
- @DocumentManager.getDoc = sinon.stub().yields(null, @lines, @version, @track_changes_entries)
- @TrackChangesManager.applyUpdate = sinon.stub().yields(null, @updated_track_changes_entries)
- @ShareJsUpdateManager.applyUpdate = sinon.stub().yields(null, @updatedDocLines, @version, @appliedOps)
- @RedisManager.updateDocument = sinon.stub().yields()
- @HistoryManager.pushUncompressedHistoryOps = sinon.stub().callsArg(3)
-
- describe "normally", ->
- beforeEach ->
- @UpdateManager.applyUpdate @project_id, @doc_id, @update, @callback
-
- it "should apply the updates via ShareJS", ->
- @ShareJsUpdateManager.applyUpdate
- .calledWith(@project_id, @doc_id, @update, @lines, @version)
- .should.equal true
-
- it "should update the track changes entries", ->
- @TrackChangesManager.applyUpdate
- .calledWith(@project_id, @doc_id, @track_changes_entries, @appliedOps)
- .should.equal true
- it "should save the document", ->
- @RedisManager.updateDocument
- .calledWith(@doc_id, @updatedDocLines, @version, @appliedOps, @updated_track_changes_entries)
- .should.equal true
-
- it "should push the applied ops into the track changes queue", ->
- @HistoryManager.pushUncompressedHistoryOps
- .calledWith(@project_id, @doc_id, @appliedOps)
- .should.equal true
- it "should call the callback", ->
- @callback.called.should.equal true
- describe "with UTF-16 surrogate pairs in the update", ->
- beforeEach ->
- @update = {op: [{p: 42, i: "\uD835\uDC00"}]}
- @UpdateManager.applyUpdate @project_id, @doc_id, @update, @callback
- it "should apply the update but with surrogate pairs removed", ->
- @ShareJsUpdateManager.applyUpdate
- .calledWith(@project_id, @doc_id, @update)
- .should.equal true
-
- # \uFFFD is 'replacement character'
- @update.op[0].i.should.equal "\uFFFD\uFFFD"
- describe "lockUpdatesAndDo", ->
- beforeEach ->
- @method = sinon.stub().callsArgWith(3, null, @response_arg1)
- @callback = sinon.stub()
- @arg1 = "argument 1"
- @response_arg1 = "response argument 1"
- @lockValue = "mock-lock-value"
- @LockManager.getLock = sinon.stub().callsArgWith(1, null, @lockValue)
- @LockManager.releaseLock = sinon.stub().callsArg(2)
- describe "successfully", ->
- beforeEach ->
- @UpdateManager.continueProcessingUpdatesWithLock = sinon.stub()
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArg(2)
- @UpdateManager.lockUpdatesAndDo @method, @project_id, @doc_id, @arg1, @callback
- it "should lock the doc", ->
- @LockManager.getLock
- .calledWith(@doc_id)
- .should.equal true
- it "should process any outstanding updates", ->
- @UpdateManager.processOutstandingUpdates
- .calledWith(@project_id, @doc_id)
- .should.equal true
- it "should call the method", ->
- @method
- .calledWith(@project_id, @doc_id, @arg1)
- .should.equal true
- it "should return the method response to the callback", ->
- @callback
- .calledWith(null, @response_arg1)
- .should.equal true
- it "should release the lock", ->
- @LockManager.releaseLock
- .calledWith(@doc_id, @lockValue)
- .should.equal true
- it "should continue processing updates", ->
- @UpdateManager.continueProcessingUpdatesWithLock
- .calledWith(@project_id, @doc_id)
- .should.equal true
- describe "when processOutstandingUpdates returns an error", ->
- beforeEach ->
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArgWith(2, @error = new Error("Something went wrong"))
- @UpdateManager.lockUpdatesAndDo @method, @project_id, @doc_id, @arg1, @callback
- it "should free the lock", ->
- @LockManager.releaseLock.calledWith(@doc_id, @lockValue).should.equal true
-
- it "should return the error in the callback", ->
- @callback.calledWith(@error).should.equal true
- describe "when the method returns an error", ->
- beforeEach ->
- @UpdateManager.processOutstandingUpdates = sinon.stub().callsArg(2)
- @method = sinon.stub().callsArgWith(3, @error = new Error("something went wrong"), @response_arg1)
- @UpdateManager.lockUpdatesAndDo @method, @project_id, @doc_id, @arg1, @callback
- it "should free the lock", ->
- @LockManager.releaseLock.calledWith(@doc_id, @lockValue).should.equal true
-
- it "should return the error in the callback", ->
- @callback.calledWith(@error).should.equal true
|