UserRegistrationHandlerTests.coffee 7.0 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197
  1. should = require('chai').should()
  2. SandboxedModule = require('sandboxed-module')
  3. assert = require('assert')
  4. path = require('path')
  5. modulePath = path.join __dirname, '../../../../app/js/Features/User/UserRegistrationHandler'
  6. sinon = require("sinon")
  7. expect = require("chai").expect
  8. EmailHelper = require '../../../../app/js/Features/Helpers/EmailHelper'
  9. describe "UserRegistrationHandler", ->
  10. beforeEach ->
  11. @user =
  12. _id: @user_id = "31j2lk21kjl"
  13. @User =
  14. update: sinon.stub().callsArgWith(2)
  15. @UserGetter =
  16. getUserByAnyEmail: sinon.stub()
  17. @UserCreator =
  18. createNewUser:sinon.stub().callsArgWith(1, null, @user)
  19. @AuthenticationManager =
  20. setUserPassword: sinon.stub().callsArgWith(2)
  21. @NewsLetterManager =
  22. subscribe: sinon.stub().callsArgWith(1)
  23. @EmailHandler =
  24. sendEmail:sinon.stub().callsArgWith(2)
  25. @OneTimeTokenHandler =
  26. getNewToken: sinon.stub()
  27. @handler = SandboxedModule.require modulePath, requires:
  28. "../../models/User": {User:@User}
  29. "./UserGetter": @UserGetter
  30. "./UserCreator": @UserCreator
  31. "../Authentication/AuthenticationManager":@AuthenticationManager
  32. "../Newsletter/NewsletterManager":@NewsLetterManager
  33. "logger-sharelatex": @logger = { log: sinon.stub() }
  34. "crypto": @crypto = {}
  35. "../Email/EmailHandler": @EmailHandler
  36. "../Security/OneTimeTokenHandler": @OneTimeTokenHandler
  37. "../Analytics/AnalyticsManager": @AnalyticsManager = { recordEvent: sinon.stub() }
  38. "settings-sharelatex": @settings = {siteUrl: "http://sl.example.com"}
  39. "../Helpers/EmailHelper": EmailHelper
  40. @passingRequest = {email:"something@email.com", password:"123"}
  41. describe 'validate Register Request', ->
  42. it 'allow working account through', ->
  43. result = @handler._registrationRequestIsValid @passingRequest
  44. result.should.equal true
  45. it 'not allow not valid email through ', ()->
  46. @passingRequest.email = "notemail"
  47. result = @handler._registrationRequestIsValid @passingRequest
  48. result.should.equal false
  49. it 'not allow no email through ', ->
  50. @passingRequest.email = ""
  51. result = @handler._registrationRequestIsValid @passingRequest
  52. result.should.equal false
  53. it 'not allow no password through ', ()->
  54. @passingRequest.password= ""
  55. result = @handler._registrationRequestIsValid @passingRequest
  56. result.should.equal false
  57. describe "registerNewUser", ->
  58. describe "holdingAccount", (done)->
  59. beforeEach ->
  60. @user.holdingAccount = true
  61. @handler._registrationRequestIsValid = sinon.stub().returns true
  62. @UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user)
  63. it "should not create a new user if there is a holding account there", (done)->
  64. @handler.registerNewUser @passingRequest, (err)=>
  65. @UserCreator.createNewUser.called.should.equal false
  66. done()
  67. it "should set holding account to false", (done)->
  68. @handler.registerNewUser @passingRequest, (err)=>
  69. update = @User.update.args[0]
  70. assert.deepEqual update[0], {_id:@user._id}
  71. assert.deepEqual update[1], {"$set":{holdingAccount:false}}
  72. done()
  73. describe "invalidRequest", ->
  74. it "should not create a new user if the the request is not valid", (done)->
  75. @handler._registrationRequestIsValid = sinon.stub().returns false
  76. @handler.registerNewUser @passingRequest, (err)=>
  77. expect(err).to.exist
  78. @UserCreator.createNewUser.called.should.equal false
  79. done()
  80. it "should return email registered in the error if there is a non holdingAccount there", (done)->
  81. @UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user = {holdingAccount:false})
  82. @handler.registerNewUser @passingRequest, (err, user)=>
  83. err.should.deep.equal new Error("EmailAlreadyRegistered")
  84. user.should.deep.equal @user
  85. done()
  86. describe "validRequest", ->
  87. beforeEach ->
  88. @handler._registrationRequestIsValid = sinon.stub().returns true
  89. @UserGetter.getUserByAnyEmail.callsArgWith 1
  90. it "should create a new user", (done)->
  91. @handler.registerNewUser @passingRequest, (err)=>
  92. @UserCreator.createNewUser.calledWith({email:@passingRequest.email, holdingAccount:false, first_name:@passingRequest.first_name, last_name:@passingRequest.last_name}).should.equal true
  93. done()
  94. it 'lower case email', (done)->
  95. @passingRequest.email = "soMe@eMail.cOm"
  96. @handler.registerNewUser @passingRequest, (err)=>
  97. @UserCreator.createNewUser.args[0][0].email.should.equal "some@email.com"
  98. done()
  99. it 'trim white space from email', (done)->
  100. @passingRequest.email = " some@email.com "
  101. @handler.registerNewUser @passingRequest, (err)=>
  102. @UserCreator.createNewUser.args[0][0].email.should.equal "some@email.com"
  103. done()
  104. it "should set the password", (done)->
  105. @handler.registerNewUser @passingRequest, (err)=>
  106. @AuthenticationManager.setUserPassword.calledWith(@user._id, @passingRequest.password).should.equal true
  107. done()
  108. it "should add the user to the news letter manager", (done)->
  109. @handler.registerNewUser @passingRequest, (err)=>
  110. @NewsLetterManager.subscribe.calledWith(@user).should.equal true
  111. done()
  112. it "should track the registration event", (done)->
  113. @handler.registerNewUser @passingRequest, (err)=>
  114. @AnalyticsManager.recordEvent
  115. .calledWith(@user._id, "user-registered")
  116. .should.equal true
  117. done()
  118. it "should call the ReferalAllocator", (done)->
  119. done()
  120. describe "registerNewUserAndSendActivationEmail", ->
  121. beforeEach ->
  122. @email = "email@example.com"
  123. @crypto.randomBytes = sinon.stub().returns({toString: () => @password = "mock-password"})
  124. @OneTimeTokenHandler.getNewToken.yields(null, @token = "mock-token")
  125. @handler.registerNewUser = sinon.stub()
  126. @callback = sinon.stub()
  127. describe "with a new user", ->
  128. beforeEach ->
  129. @handler.registerNewUser.callsArgWith(1, null, @user)
  130. @handler.registerNewUserAndSendActivationEmail @email, @callback
  131. it "should ask the UserRegistrationHandler to register user", ->
  132. @handler.registerNewUser
  133. .calledWith({
  134. email: @email
  135. password: @password
  136. }).should.equal true
  137. it "should generate a new password reset token", ->
  138. @OneTimeTokenHandler.getNewToken
  139. .calledWith('password', @user_id, expiresIn: 7 * 24 * 60 * 60)
  140. .should.equal true
  141. it "should send a registered email", ->
  142. @EmailHandler.sendEmail
  143. .calledWith("registered", {
  144. to: @user.email
  145. setNewPasswordUrl: "#{@settings.siteUrl}/user/activate?token=#{@token}&user_id=#{@user_id}"
  146. })
  147. .should.equal true
  148. it "should return the user", ->
  149. @callback
  150. .calledWith(null, @user, "#{@settings.siteUrl}/user/activate?token=#{@token}&user_id=#{@user_id}")
  151. .should.equal true
  152. describe "with a user that already exists", ->
  153. beforeEach ->
  154. @handler.registerNewUser.callsArgWith(1, new Error("EmailAlreadyRegistered"), @user)
  155. @handler.registerNewUserAndSendActivationEmail @email, @callback
  156. it "should still generate a new password token and email", ->
  157. @OneTimeTokenHandler.getNewToken.called.should.equal true
  158. @EmailHandler.sendEmail.called.should.equal true