| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521 |
- const { expect } = require('chai')
- const sinon = require('sinon')
- const modulePath = '../../../../app/src/Features/Compile/CompileManager.js'
- const SandboxedModule = require('sandboxed-module')
- describe('CompileManager', function () {
- beforeEach(function () {
- this.rateLimitGetStub = sinon.stub()
- this.ratelimiter = { addCount: sinon.stub() }
- this.timer = {
- done: sinon.stub(),
- }
- this.Metrics = {
- Timer: sinon.stub().returns(this.timer),
- inc: sinon.stub(),
- }
- this.CompileManager = SandboxedModule.require(modulePath, {
- requires: {
- '@overleaf/settings': (this.settings = {
- apis: { clsi: { defaultBackendClass: 'e2' } },
- redis: { web: { host: 'localhost', port: 42 } },
- rateLimit: { autoCompile: {} },
- }),
- '../../infrastructure/RedisWrapper': {
- client: () => (this.rclient = { auth() {} }),
- },
- '../Project/ProjectRootDocManager': (this.ProjectRootDocManager = {}),
- '../Project/ProjectGetter': (this.ProjectGetter = {}),
- '../User/UserGetter': (this.UserGetter = {}),
- './ClsiManager': (this.ClsiManager = {}),
- '../../infrastructure/RateLimiter': this.ratelimiter,
- '@overleaf/metrics': this.Metrics,
- '../SplitTests/SplitTestHandler': {
- getAssignmentForMongoUser: (this.getAssignmentForMongoUser = sinon
- .stub()
- .yields(null, {
- variant: 'default',
- })),
- },
- },
- })
- this.project_id = 'mock-project-id-123'
- this.user_id = 'mock-user-id-123'
- this.callback = sinon.stub()
- this.limits = {
- timeout: 42,
- compileGroup: 'standard',
- }
- })
- describe('compile', function () {
- beforeEach(function () {
- this.CompileManager._checkIfRecentlyCompiled = sinon
- .stub()
- .callsArgWith(2, null, false)
- this.ProjectRootDocManager.ensureRootDocumentIsSet = sinon
- .stub()
- .callsArgWith(1, null)
- this.CompileManager.getProjectCompileLimits = sinon
- .stub()
- .callsArgWith(1, null, this.limits)
- this.ClsiManager.sendRequest = sinon
- .stub()
- .callsArgWith(
- 3,
- null,
- (this.status = 'mock-status'),
- (this.outputFiles = 'mock output files'),
- (this.output = 'mock output')
- )
- })
- describe('succesfully', function () {
- beforeEach(function () {
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit = (
- isAutoCompile,
- compileGroup,
- cb
- ) => cb(null, true)
- this.CompileManager.compile(
- this.project_id,
- this.user_id,
- {},
- this.callback
- )
- })
- it('should check the project has not been recently compiled', function () {
- this.CompileManager._checkIfRecentlyCompiled
- .calledWith(this.project_id, this.user_id)
- .should.equal(true)
- })
- it('should ensure that the root document is set', function () {
- this.ProjectRootDocManager.ensureRootDocumentIsSet
- .calledWith(this.project_id)
- .should.equal(true)
- })
- it('should get the project compile limits', function () {
- this.CompileManager.getProjectCompileLimits
- .calledWith(this.project_id)
- .should.equal(true)
- })
- it('should run the compile with the compile limits', function () {
- this.ClsiManager.sendRequest
- .calledWith(this.project_id, this.user_id, {
- timeout: this.limits.timeout,
- compileGroup: 'standard',
- })
- .should.equal(true)
- })
- it('should call the callback with the output', function () {
- this.callback
- .calledWith(null, this.status, this.outputFiles, this.output)
- .should.equal(true)
- })
- it('should time the compile', function () {
- this.timer.done.called.should.equal(true)
- })
- })
- describe('when the project has been recently compiled', function () {
- it('should return', function (done) {
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit = (
- isAutoCompile,
- compileGroup,
- cb
- ) => cb(null, true)
- this.CompileManager._checkIfRecentlyCompiled = sinon
- .stub()
- .callsArgWith(2, null, true)
- this.CompileManager.compile(
- this.project_id,
- this.user_id,
- {},
- (err, status) => {
- if (err) {
- return done(err)
- }
- status.should.equal('too-recently-compiled')
- done()
- }
- )
- })
- })
- describe('should check the rate limit', function () {
- it('should return', function (done) {
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit = sinon
- .stub()
- .callsArgWith(2, null, false)
- this.CompileManager.compile(
- this.project_id,
- this.user_id,
- {},
- (err, status) => {
- if (err) {
- return done(err)
- }
- status.should.equal('autocompile-backoff')
- done()
- }
- )
- })
- })
- })
- describe('getProjectCompileLimits', function () {
- beforeEach(function () {
- this.features = {
- compileTimeout: (this.timeout = 42),
- compileGroup: (this.group = 'priority'),
- }
- this.ProjectGetter.getProject = sinon
- .stub()
- .callsArgWith(
- 2,
- null,
- (this.project = { owner_ref: (this.owner_id = 'owner-id-123') })
- )
- this.UserGetter.getUser = sinon
- .stub()
- .callsArgWith(
- 2,
- null,
- (this.user = { features: this.features, analyticsId: 'abc' })
- )
- this.CompileManager.getProjectCompileLimits(
- this.project_id,
- this.callback
- )
- })
- it('should look up the owner of the project', function () {
- this.ProjectGetter.getProject
- .calledWith(this.project_id, { owner_ref: 1 })
- .should.equal(true)
- })
- it("should look up the owner's features", function () {
- this.UserGetter.getUser
- .calledWith(this.project.owner_ref, {
- _id: 1,
- alphaProgram: 1,
- analyticsId: 1,
- betaProgram: 1,
- features: 1,
- splitTests: 1,
- })
- .should.equal(true)
- })
- it('should return the limits', function () {
- this.callback
- .calledWith(null, {
- timeout: this.timeout,
- compileGroup: this.group,
- compileBackendClass: 'e2',
- ownerAnalyticsId: 'abc',
- showFasterCompilesFeedbackUI: false,
- })
- .should.equal(true)
- })
- })
- describe('compileBackendClass', function () {
- beforeEach(function () {
- this.features = {
- compileTimeout: 42,
- compileGroup: 'standard',
- }
- this.ProjectGetter.getProject = sinon
- .stub()
- .yields(null, { owner_ref: 'owner-id-123' })
- this.UserGetter.getUser = sinon
- .stub()
- .yields(null, { features: this.features, analyticsId: 'abc' })
- })
- describe('with standard compile', function () {
- beforeEach(function () {
- this.features.compileGroup = 'standard'
- })
- it('should return the default class and disable ui', function (done) {
- this.CompileManager.getProjectCompileLimits(
- this.project_id,
- (err, { compileBackendClass, showFasterCompilesFeedbackUI }) => {
- if (err) return done(err)
- expect(compileBackendClass).to.equal('e2')
- expect(showFasterCompilesFeedbackUI).to.equal(false)
- done()
- }
- )
- })
- })
- describe('with priority compile', function () {
- beforeEach(function () {
- this.features.compileGroup = 'priority'
- })
- describe('split test not active', function () {
- beforeEach(function () {
- this.getAssignmentForMongoUser.yields(null, {
- analytics: { segmentation: {} },
- variant: 'default',
- })
- })
- it('should return the default class and disable ui', function (done) {
- this.CompileManager.getProjectCompileLimits(
- this.project_id,
- (err, { compileBackendClass, showFasterCompilesFeedbackUI }) => {
- if (err) return done(err)
- expect(compileBackendClass).to.equal('e2')
- expect(showFasterCompilesFeedbackUI).to.equal(false)
- done()
- }
- )
- })
- })
- describe('split test active', function () {
- describe('default variant', function () {
- beforeEach(function () {
- this.getAssignmentForMongoUser.yields(null, {
- analytics: { segmentation: { splitTest: 'foo' } },
- variant: 'default',
- })
- })
- it('should return the default class and enable ui', function (done) {
- this.CompileManager.getProjectCompileLimits(
- this.project_id,
- (err, { compileBackendClass, showFasterCompilesFeedbackUI }) => {
- if (err) return done(err)
- expect(compileBackendClass).to.equal('e2')
- expect(showFasterCompilesFeedbackUI).to.equal(true)
- done()
- }
- )
- })
- })
- describe('c2d variant', function () {
- beforeEach(function () {
- this.getAssignmentForMongoUser.yields(null, {
- analytics: { segmentation: { splitTest: 'foo' } },
- variant: 'c2d',
- })
- })
- it('should return the c2d class and enable ui', function (done) {
- this.CompileManager.getProjectCompileLimits(
- this.project_id,
- (err, { compileBackendClass, showFasterCompilesFeedbackUI }) => {
- if (err) return done(err)
- expect(compileBackendClass).to.equal('c2d')
- expect(showFasterCompilesFeedbackUI).to.equal(true)
- done()
- }
- )
- })
- })
- })
- })
- })
- describe('deleteAuxFiles', function () {
- beforeEach(function () {
- this.CompileManager.getProjectCompileLimits = sinon
- .stub()
- .callsArgWith(
- 1,
- null,
- (this.limits = { compileGroup: 'mock-compile-group' })
- )
- this.ClsiManager.deleteAuxFiles = sinon.stub().callsArg(3)
- this.CompileManager.deleteAuxFiles(
- this.project_id,
- this.user_id,
- this.callback
- )
- })
- it('should look up the compile group to use', function () {
- this.CompileManager.getProjectCompileLimits
- .calledWith(this.project_id)
- .should.equal(true)
- })
- it('should delete the aux files', function () {
- this.ClsiManager.deleteAuxFiles
- .calledWith(this.project_id, this.user_id, this.limits)
- .should.equal(true)
- })
- it('should call the callback', function () {
- this.callback.called.should.equal(true)
- })
- })
- describe('_checkIfRecentlyCompiled', function () {
- describe('when the key exists in redis', function () {
- beforeEach(function () {
- this.rclient.set = sinon.stub().callsArgWith(5, null, null)
- this.CompileManager._checkIfRecentlyCompiled(
- this.project_id,
- this.user_id,
- this.callback
- )
- })
- it('should try to set the key', function () {
- this.rclient.set
- .calledWith(
- `compile:${this.project_id}:${this.user_id}`,
- true,
- 'EX',
- this.CompileManager.COMPILE_DELAY,
- 'NX'
- )
- .should.equal(true)
- })
- it('should call the callback with true', function () {
- this.callback.calledWith(null, true).should.equal(true)
- })
- })
- describe('when the key does not exist in redis', function () {
- beforeEach(function () {
- this.rclient.set = sinon.stub().callsArgWith(5, null, 'OK')
- this.CompileManager._checkIfRecentlyCompiled(
- this.project_id,
- this.user_id,
- this.callback
- )
- })
- it('should try to set the key', function () {
- this.rclient.set
- .calledWith(
- `compile:${this.project_id}:${this.user_id}`,
- true,
- 'EX',
- this.CompileManager.COMPILE_DELAY,
- 'NX'
- )
- .should.equal(true)
- })
- it('should call the callback with false', function () {
- this.callback.calledWith(null, false).should.equal(true)
- })
- })
- })
- describe('_checkIfAutoCompileLimitHasBeenHit', function () {
- it('should be able to compile if it is not an autocompile', function (done) {
- this.ratelimiter.addCount.callsArgWith(2, null, true)
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit(
- false,
- 'everyone',
- (err, canCompile) => {
- if (err) {
- return done(err)
- }
- canCompile.should.equal(true)
- done()
- }
- )
- })
- it('should be able to compile if rate limit has remianing', function (done) {
- this.ratelimiter.addCount.callsArgWith(1, null, true)
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit(
- true,
- 'everyone',
- (err, canCompile) => {
- if (err) {
- return done(err)
- }
- const args = this.ratelimiter.addCount.args[0][0]
- args.throttle.should.equal(12.5)
- args.subjectName.should.be.oneOf(['everyone-b-one', 'everyone-b-two'])
- args.timeInterval.should.equal(20)
- args.endpointName.should.equal('auto_compile')
- canCompile.should.equal(true)
- done()
- }
- )
- })
- it('should be not able to compile if rate limit has no remianing', function (done) {
- this.ratelimiter.addCount.callsArgWith(1, null, false)
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit(
- true,
- 'everyone',
- (err, canCompile) => {
- if (err) {
- return done(err)
- }
- canCompile.should.equal(false)
- done()
- }
- )
- })
- it('should return false if there is an error in the rate limit', function (done) {
- this.ratelimiter.addCount.callsArgWith(1, 'error')
- this.CompileManager._checkIfAutoCompileLimitHasBeenHit(
- true,
- 'everyone',
- (err, canCompile) => {
- if (err) {
- return done(err)
- }
- canCompile.should.equal(false)
- done()
- }
- )
- })
- })
- describe('wordCount', function () {
- beforeEach(function () {
- this.CompileManager.getProjectCompileLimits = sinon
- .stub()
- .callsArgWith(
- 1,
- null,
- (this.limits = { compileGroup: 'mock-compile-group' })
- )
- this.ClsiManager.wordCount = sinon.stub().callsArg(4)
- this.CompileManager.wordCount(
- this.project_id,
- this.user_id,
- false,
- this.callback
- )
- })
- it('should look up the compile group to use', function () {
- this.CompileManager.getProjectCompileLimits
- .calledWith(this.project_id)
- .should.equal(true)
- })
- it('should call wordCount for project', function () {
- this.ClsiManager.wordCount
- .calledWith(this.project_id, this.user_id, false, this.limits)
- .should.equal(true)
- })
- it('should call the callback', function () {
- this.callback.called.should.equal(true)
- })
- })
- })
|