| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220 |
- import { vi, expect } from 'vitest'
- import { setTimeout } from 'timers/promises'
- import sinon from 'sinon'
- import tk from 'timekeeper'
- import { RequestFailedError } from '@overleaf/fetch-utils'
- const FILESTORE_URL = 'http://filestore.example.com'
- const CLSI_HOST = 'clsi.example.com'
- const MODULE_PATH = '../../../../app/src/Features/Compile/ClsiManager.mjs'
- const GLOBAL_BLOB_HASH = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
- describe('ClsiManager', function () {
- beforeEach(async function (ctx) {
- tk.freeze(Date.now())
- ctx.user_id = 'user-id'
- ctx.project = {
- _id: 'project-id',
- compiler: 'latex',
- rootDoc_id: 'mock-doc-id-1',
- imageName: 'mock-image-name',
- overleaf: { history: { id: 42 } },
- }
- ctx.docs = {
- '/main.tex': {
- name: 'main.tex',
- _id: 'mock-doc-id-1',
- lines: ['Hello', 'world'],
- },
- '/chapters/chapter1.tex': {
- name: 'chapter1.tex',
- _id: 'mock-doc-id-2',
- lines: ['Chapter 1'],
- },
- }
- ctx.files = {
- '/images/frog.png': {
- name: 'frog.png',
- _id: 'mock-file-id-1',
- created: new Date(),
- hash: GLOBAL_BLOB_HASH,
- },
- '/images/image.png': {
- name: 'image.png',
- _id: 'mock-file-id-2',
- created: new Date(),
- hash: 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb',
- },
- '/images/no-hash.png': {
- name: 'no-hash.png',
- _id: 'mock-file-id-3',
- created: new Date(),
- },
- }
- ctx.clsiCookieKey = 'clsiserver'
- ctx.clsiServerId = 'clsi-server-id'
- ctx.newClsiServerId = 'newserver'
- ctx.rawOutputFiles = {}
- ctx.responseBody = {
- compile: {
- status: 'success',
- stats: {
- isInitialCompile: 1,
- restoredClsiCache: 1,
- },
- timings: { compileE2E: 1337 },
- outputFiles: [
- {
- path: 'output.pdf',
- size: 42,
- url: 'http://localhost:3013/snip/output.pdf',
- },
- ],
- },
- }
- ctx.response = {
- ok: true,
- status: 200,
- headers: {
- raw: sinon.stub().returns({
- 'set-cookie': [`${ctx.clsiCookieKey}=${ctx.newClsiServerId}`],
- }),
- },
- }
- ctx.FetchUtils = {
- fetchString: sinon
- .stub()
- .callsFake(() => Promise.resolve(JSON.stringify(ctx.responseBody))),
- fetchStringWithResponse: sinon.stub().callsFake(() =>
- Promise.resolve({
- body: JSON.stringify(ctx.responseBody),
- response: ctx.response,
- })
- ),
- fetchStream: sinon.stub(),
- RequestFailedError,
- }
- ctx.ClsiCookieManager = {
- promises: {
- clearServerId: sinon.stub().resolves(),
- getServerId: sinon.stub().resolves('clsi-server-id'),
- setServerId: sinon.stub().resolves(),
- },
- }
- ctx.ClsiStateManager = {
- computeHash: sinon.stub().returns('01234567890abcdef'),
- }
- ctx.ClsiFormatChecker = {
- checkRecoursesForProblems: sinon.stub().returns(),
- }
- ctx.Project = {}
- ctx.ProjectEntityHandler = {
- getAllDocPathsFromProject: sinon.stub(),
- promises: {
- getAllDocs: sinon.stub().resolves(ctx.docs),
- getAllFiles: sinon.stub().resolves(ctx.files),
- },
- }
- ctx.ProjectGetter = {
- promises: {
- findById: sinon.stub().resolves(ctx.project),
- getProject: sinon.stub().resolves(ctx.project),
- },
- }
- ctx.DocumentUpdaterHandler = {
- promises: {
- clearProjectState: sinon.stub().resolves(),
- flushProjectToMongo: sinon.stub().resolves(),
- getProjectDocsIfMatch: sinon.stub().resolves(),
- },
- }
- ctx.Metrics = {
- Timer: class Metrics {
- constructor() {
- this.done = sinon.stub()
- }
- },
- inc: sinon.stub(),
- count: sinon.stub(),
- histogram: sinon.stub(),
- }
- ctx.Settings = {
- apis: {
- filestore: {
- url: FILESTORE_URL,
- secret: 'secret',
- },
- clsi: {
- url: `http://${CLSI_HOST}`,
- submissionBackendClass: 'n2d',
- },
- clsi_new: {
- sample: 100,
- },
- },
- enablePdfCaching: true,
- clsiCookie: { key: 'clsiserver' },
- }
- ctx.ClsiCacheHandler = {
- clearCache: sinon.stub().resolves(),
- }
- ctx.HistoryManager = {
- getFilestoreBlobURL: sinon.stub().callsFake((historyId, hash) => {
- if (hash === GLOBAL_BLOB_HASH) {
- return `${FILESTORE_URL}/history/global/hash/${hash}`
- }
- return `${FILESTORE_URL}/history/project/${historyId}/hash/${hash}`
- }),
- }
- ctx.SplitTestHandler = {
- getPercentile: sinon.stub().returns(42),
- }
- ctx.AnalyticsManager = {
- recordEventForUserInBackground: sinon.stub(),
- }
- vi.doMock('@overleaf/settings', () => ({
- default: ctx.Settings,
- }))
- vi.doMock(
- '../../../../app/src/Features/SplitTests/SplitTestHandler',
- () => ({
- default: ctx.SplitTestHandler,
- })
- )
- vi.doMock('../../../../app/src/models/Project', () => ({
- Project: ctx.Project,
- }))
- vi.doMock(
- '../../../../app/src/Features/Project/ProjectEntityHandler',
- () => ({
- default: ctx.ProjectEntityHandler,
- })
- )
- vi.doMock('../../../../app/src/Features/Project/ProjectGetter', () => ({
- default: ctx.ProjectGetter,
- }))
- vi.doMock(
- '../../../../app/src/Features/DocumentUpdater/DocumentUpdaterHandler',
- () => ({
- default: ctx.DocumentUpdaterHandler,
- })
- )
- vi.doMock('../../../../app/src/Features/Compile/ClsiCookieManager', () => ({
- default: () => ctx.ClsiCookieManager,
- }))
- vi.doMock('../../../../app/src/Features/Compile/ClsiStateManager', () => ({
- default: ctx.ClsiStateManager,
- }))
- vi.doMock('../../../../app/src/Features/Compile/ClsiCacheHandler', () => ({
- default: ctx.ClsiCacheHandler,
- }))
- vi.doMock('@overleaf/fetch-utils', () => ctx.FetchUtils)
- vi.doMock('../../../../app/src/Features/Compile/ClsiFormatChecker', () => ({
- default: ctx.ClsiFormatChecker,
- }))
- vi.doMock('@overleaf/metrics', () => ({
- default: ctx.Metrics,
- }))
- vi.doMock('../../../../app/src/Features/History/HistoryManager', () => ({
- default: ctx.HistoryManager,
- }))
- vi.doMock(
- '../../../../app/src/Features/Analytics/AnalyticsManager',
- () => ({
- default: ctx.AnalyticsManager,
- })
- )
- ctx.ClsiManager = (await import(MODULE_PATH)).default
- })
- afterAll(function () {
- tk.reset()
- })
- describe('sendRequest', function () {
- describe('with a successful compile', function () {
- const buildId = '18fbe9e7564-30dcb2f71250c690'
- beforeEach(async function (ctx) {
- ctx.outputFiles = [
- {
- url: `/project/${ctx.project_id}/user/${ctx.user_id}/build/1234/output/output.pdf`,
- path: 'output.pdf',
- type: 'pdf',
- build: buildId,
- },
- {
- url: `/project/${ctx.project_id}/user/${ctx.user_id}/build/1234/output/output.log`,
- path: 'output.log',
- type: 'log',
- build: buildId,
- },
- ]
- ctx.responseBody.compile.outputFiles = ctx.outputFiles.map(
- outputFile => ({
- ...outputFile,
- url: `http://${CLSI_HOST}${outputFile.url}`,
- })
- )
- ctx.responseBody.compile.buildId = buildId
- ctx.timeout = 100
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {
- compileBackendClass: 'n2d',
- compileGroup: 'standard',
- timeout: ctx.timeout,
- }
- )
- })
- it('should send the request to the CLSI', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}/compile` &&
- url.searchParams.get('compileBackendClass') === 'n2d' &&
- url.searchParams.get('compileGroup') === 'standard'
- ),
- {
- method: 'POST',
- json: sinon.match({
- compile: {
- options: {
- compiler: ctx.project.compiler,
- imageName: ctx.project.imageName,
- timeout: ctx.timeout,
- draft: false,
- compileGroup: 'standard',
- metricsMethod: 'standard',
- stopOnFirstError: false,
- syncType: undefined,
- },
- rootResourcePath: 'main.tex',
- resources: _makeResources(ctx.project, ctx.docs, ctx.files),
- },
- }),
- headers: {
- Accept: 'application/json',
- 'Content-Type': 'application/json',
- Cookie: `${ctx.clsiCookieKey}=${ctx.clsiServerId}`,
- },
- signal: sinon.match.instanceOf(AbortSignal),
- }
- )
- })
- it('should get the project with the required fields', function (ctx) {
- ctx.ProjectGetter.promises.getProject.should.have.been.calledWith(
- ctx.project._id,
- {
- compiler: 1,
- rootDoc_id: 1,
- imageName: 1,
- rootFolder: 1,
- 'overleaf.history.id': 1,
- }
- )
- })
- it('should flush the project to the database', function (ctx) {
- ctx.DocumentUpdaterHandler.promises.flushProjectToMongo.should.have.been.calledWith(
- ctx.project._id
- )
- })
- it('should get all the docs', function (ctx) {
- ctx.ProjectEntityHandler.promises.getAllDocs.should.have.been.calledWith(
- ctx.project._id
- )
- })
- it('should get all the files', function (ctx) {
- ctx.ProjectEntityHandler.promises.getAllFiles.should.have.been.calledWith(
- ctx.project._id
- )
- })
- it('should return the status and output files', function (ctx) {
- expect(ctx.result.status).to.equal('success')
- expect(ctx.result.outputFiles.map(f => f.path)).to.have.members(
- ctx.outputFiles.map(f => f.path)
- )
- })
- it('should return the buildId', function (ctx) {
- expect(ctx.result.buildId).to.equal(buildId)
- })
- it('should persist the cookie from the response', function (ctx) {
- expect(
- ctx.ClsiCookieManager.promises.setServerId
- ).to.have.been.calledWith(
- ctx.project._id,
- ctx.user_id,
- 'standard',
- 'n2d',
- ctx.newClsiServerId
- )
- })
- })
- describe('with ranges on the pdf and stats/timings details', function () {
- beforeEach(async function (ctx) {
- ctx.ranges = [{ start: 1, end: 42, hash: 'foo' }]
- ctx.startXRefTable = 123
- ctx.size = 456
- ctx.contentId = '123-321'
- ctx.outputFiles = [
- {
- url: `/project/${ctx.project._id}/user/${ctx.user_id}/build/1234/output/output.pdf`,
- path: 'output.pdf',
- type: 'pdf',
- build: 1234,
- contentId: ctx.contentId,
- ranges: ctx.ranges,
- startXRefTable: ctx.startXRefTable,
- size: ctx.size,
- },
- {
- url: `/project/${ctx.project._id}/user/${ctx.user_id}/build/1234/output/output.log`,
- path: 'output.log',
- type: 'log',
- build: 1234,
- },
- ]
- ctx.stats = { fooStat: 1 }
- ctx.timings = { barTiming: 2 }
- ctx.responseBody.compile.outputFiles = ctx.outputFiles.map(
- outputFile => ({
- ...outputFile,
- url: `http://${CLSI_HOST}${outputFile.url}`,
- })
- )
- ctx.responseBody.compile.stats = ctx.stats
- ctx.responseBody.compile.timings = ctx.timings
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- { compileBackendClass: 'n2d', compileGroup: 'standard' }
- )
- })
- it('should emit the caching details and stats/timings', function (ctx) {
- expect(ctx.result.status).to.equal('success')
- expect(ctx.result.clsiServerId).to.equal(ctx.newClsiServerId)
- expect(ctx.result.validationError).to.be.undefined
- expect(ctx.result.stats).to.deep.equal(ctx.stats)
- expect(ctx.result.timings).to.deep.equal(ctx.timings)
- const outputPdf = ctx.result.outputFiles.find(
- f => f.path === 'output.pdf'
- )
- expect(outputPdf.ranges).to.deep.equal(ctx.ranges)
- expect(outputPdf.startXRefTable).to.equal(ctx.startXRefTable)
- expect(outputPdf.contentId).to.equal(ctx.contentId)
- expect(outputPdf.size).to.equal(ctx.size)
- })
- })
- describe('with the incremental compile option', function () {
- beforeEach(async function (ctx) {
- const doc = ctx.docs['/main.tex']
- ctx.DocumentUpdaterHandler.promises.getProjectDocsIfMatch.resolves([
- { _id: doc._id, lines: doc.lines, v: 123 },
- ])
- ctx.ProjectEntityHandler.getAllDocPathsFromProject.returns({
- 'mock-doc-id-1': 'main.tex',
- })
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {
- timeout: 100,
- incrementalCompilesEnabled: true,
- compileBackendClass: 'n2d',
- compileGroup: 'priority',
- compileFromClsiCache: true,
- populateClsiCache: true,
- enablePdfCaching: true,
- pdfCachingMinChunkSize: 1337,
- }
- )
- })
- it('should get the project with the required fields', function (ctx) {
- ctx.ProjectGetter.promises.getProject.should.have.been.calledWith(
- ctx.project._id,
- {
- compiler: 1,
- rootDoc_id: 1,
- imageName: 1,
- rootFolder: 1,
- 'overleaf.history.id': 1,
- }
- )
- })
- it('should not explicitly flush the project to the database', function (ctx) {
- ctx.DocumentUpdaterHandler.promises.flushProjectToMongo.should.not.have.been.calledWith(
- ctx.project._id
- )
- })
- it('should get only the live docs from the docupdater with a background flush in docupdater', function (ctx) {
- ctx.DocumentUpdaterHandler.promises.getProjectDocsIfMatch.should.have.been.calledWith(
- ctx.project._id
- )
- })
- it('should not get any of the files', function (ctx) {
- ctx.ProjectEntityHandler.promises.getAllFiles.should.not.have.been
- .called
- })
- it('should build up the CLSI request', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match(
- url =>
- url.hostname === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}/compile` &&
- url.searchParams.get('compileBackendClass') === 'n2d' &&
- url.searchParams.get('compileGroup') === 'priority'
- ),
- {
- method: 'POST',
- json: sinon.match({
- compile: {
- options: {
- compiler: ctx.project.compiler,
- timeout: 100,
- imageName: ctx.project.imageName,
- draft: false,
- syncType: 'incremental',
- syncState: '01234567890abcdef',
- compileGroup: 'priority',
- compileFromClsiCache: true,
- populateClsiCache: true,
- enablePdfCaching: true,
- pdfCachingMinChunkSize: 1337,
- metricsMethod: 'priority',
- stopOnFirstError: false,
- },
- rootResourcePath: 'main.tex',
- resources: [
- {
- path: 'main.tex',
- content: ctx.docs['/main.tex'].lines.join('\n'),
- },
- ],
- },
- }),
- headers: {
- Accept: 'application/json',
- 'Content-Type': 'application/json',
- Cookie: `${ctx.clsiCookieKey}=${ctx.clsiServerId}`,
- },
- signal: sinon.match.instanceOf(AbortSignal),
- }
- )
- })
- })
- describe('when the root doc is set and not in the docupdater', function () {
- beforeEach(async function (ctx) {
- const doc = ctx.docs['/main.tex']
- ctx.DocumentUpdaterHandler.promises.getProjectDocsIfMatch.resolves([
- { _id: doc._id, lines: doc.lines, v: 123 },
- ])
- ctx.ProjectEntityHandler.getAllDocPathsFromProject.returns({
- 'mock-doc-id-1': 'main.tex',
- 'mock-doc-id-2': '/chapters/chapter1.tex',
- })
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {
- timeout: 100,
- incrementalCompilesEnabled: true,
- rootDoc_id: 'mock-doc-id-2',
- }
- )
- })
- it('should still change the root path', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { rootResourcePath: 'chapters/chapter1.tex' } },
- })
- )
- })
- })
- describe('when root doc override is valid', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- { rootDoc_id: 'mock-doc-id-2' }
- )
- })
- it('should change root path', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { rootResourcePath: 'chapters/chapter1.tex' } },
- })
- )
- })
- })
- describe('when root doc override is invalid', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- { rootDoc_id: 'invalid-id' }
- )
- })
- it('should fallback to default root doc', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { rootResourcePath: 'main.tex' } },
- })
- )
- })
- })
- describe('when the project has an invalid compiler', function () {
- beforeEach(async function (ctx) {
- ctx.project.compiler = 'context'
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should set the compiler to pdflatex', function (ctx) {
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { options: { compiler: 'pdflatex' } } },
- })
- )
- })
- })
- describe('when there is no valid root document', function () {
- beforeEach(async function (ctx) {
- ctx.project.rootDoc_id = 'not-valid'
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should set to main.tex', function (ctx) {
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { rootResourcePath: 'main.tex' } },
- })
- )
- })
- })
- describe('when there is no valid root document and no main.tex document', function () {
- beforeEach(async function (ctx) {
- ctx.project.rootDoc_id = 'not-valid'
- ctx.docs = {
- '/other.tex': {
- name: 'other.tex',
- _id: 'mock-doc-id-1',
- lines: ['Hello', 'world'],
- },
- '/chapters/chapter1.tex': {
- name: 'chapter1.tex',
- _id: 'mock-doc-id-2',
- lines: ['Chapter 1'],
- },
- }
- ctx.ProjectEntityHandler.promises.getAllDocs.resolves(ctx.docs)
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should report a validation problem', function (ctx) {
- expect(ctx.result.status).to.equal('validation-problems')
- })
- })
- describe('when there is no valid root document and a single document which is not main.tex', function () {
- beforeEach(async function (ctx) {
- ctx.project.rootDoc_id = 'not-valid'
- ctx.docs = {
- '/other.tex': {
- name: 'other.tex',
- _id: 'mock-doc-id-1',
- lines: ['Hello', 'world'],
- },
- }
- ctx.ProjectEntityHandler.promises.getAllDocs.resolves(ctx.docs)
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should set io to the only file', function (ctx) {
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { rootResourcePath: 'other.tex' } },
- })
- )
- })
- })
- describe('with the draft option', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {
- timeout: 100,
- draft: true,
- }
- )
- })
- it('should add the draft option into the request', function (ctx) {
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match.any,
- sinon.match({
- json: { compile: { options: { draft: true } } },
- })
- )
- })
- })
- describe('with a failed compile', function () {
- beforeEach(async function (ctx) {
- ctx.responseBody.compile.status = 'failure'
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should return a failure status', function (ctx) {
- expect(ctx.result.status).to.equal('failure')
- })
- })
- describe('with a sync conflict', function () {
- beforeEach(async function (ctx) {
- const conflictResponseBody = { compile: { status: 'conflict' } }
- ctx.FetchUtils.fetchStringWithResponse
- .withArgs(
- sinon.match.any,
- sinon.match({
- json: sinon.match(
- json => json.compile.options.syncType !== 'full'
- ),
- })
- )
- .resolves({
- body: JSON.stringify(conflictResponseBody),
- response: ctx.response,
- })
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {}
- )
- })
- it('should send two requests to CLSI', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledTwice
- })
- it('should call the CLSI first without syncType:full', function (ctx) {
- const compileOptions =
- ctx.FetchUtils.fetchStringWithResponse.getCall(0).args[1].json.compile
- .options
- expect(compileOptions.syncType).to.be.undefined
- })
- it('should call the CLSI a second time with syncType:full', function (ctx) {
- const compileOptions =
- ctx.FetchUtils.fetchStringWithResponse.getCall(1).args[1].json.compile
- .options
- expect(compileOptions.syncType).to.equal('full')
- })
- it('should return a success status', function (ctx) {
- ctx.result.status.should.equal('success')
- })
- })
- describe('with an unavailable response', function () {
- beforeEach(async function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.onCall(0).resolves({
- body: JSON.stringify({ compile: { status: 'unavailable' } }),
- response: ctx.response,
- })
- ctx.result = await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- { compileBackendClass: 'n2d' }
- )
- })
- it('should send two requests to CLSI', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledTwice
- })
- it('should call the CLSI first without syncType:full', function (ctx) {
- const compileOptions =
- ctx.FetchUtils.fetchStringWithResponse.getCall(0).args[1].json.compile
- .options
- expect(compileOptions.syncType).to.be.undefined
- })
- it('should call the CLSI a second time with syncType:full', function (ctx) {
- const compileOptions =
- ctx.FetchUtils.fetchStringWithResponse.getCall(1).args[1].json.compile
- .options
- expect(compileOptions.syncType).to.equal('full')
- })
- it('should clear the CLSI server id cookie', function (ctx) {
- expect(
- ctx.ClsiCookieManager.promises.clearServerId
- ).to.have.been.calledWith(ctx.project._id, ctx.user_id, 'n2d')
- })
- it('should return a success status', function (ctx) {
- expect(ctx.result.status).to.equal('success')
- })
- })
- describe('when the resources fail the precompile check', function () {
- beforeEach(function (ctx) {
- ctx.ClsiFormatChecker.checkRecoursesForProblems.throws(
- new Error('failed')
- )
- })
- it('should throw an error', async function (ctx) {
- await expect(
- ctx.ClsiManager.promises.sendRequest(ctx.project._id, ctx.user_id, {})
- ).to.be.rejected
- })
- })
- describe('when a new backend is configured', function () {
- beforeEach(async function (ctx) {
- ctx.Settings.apis.clsi_new = { url: 'https://compiles.somewhere.test' }
- await ctx.ClsiManager.promises.sendRequest(
- ctx.project._id,
- ctx.user_id,
- {
- compileBackendClass: 'c2d',
- compileGroup: 'priority',
- }
- )
- // wait for the background task to finish
- await setTimeout(0)
- })
- it('makes a request to the new backend', function (ctx) {
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledTwice
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}/compile` &&
- url.searchParams.get('compileBackendClass') === 'c2d' &&
- url.searchParams.get('compileGroup') === 'priority'
- )
- )
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match(
- url =>
- url.toString() ===
- `${ctx.Settings.apis.clsi_new.url}/project/${ctx.project._id}/user/${ctx.user_id}/compile?compileBackendClass=n4&compileGroup=priority`
- )
- )
- })
- it('should record an event', function (ctx) {
- expect(
- ctx.AnalyticsManager.recordEventForUserInBackground
- ).to.have.been.calledWith(ctx.user_id, 'double-compile-result', {
- projectId: 'project-id',
- compileBackendClass: 'c2d',
- newCompileBackendClass: 'n4',
- status: 'success',
- compileTime: 1337,
- newCompileTime: 1337,
- clsiServerId: 'newserver',
- newClsiServerId: 'clsi-server-id',
- pdfSize: 42,
- newPdfSize: 42,
- })
- })
- })
- })
- describe('sendExternalRequest', function () {
- beforeEach(function (ctx) {
- ctx.submissionId = 'submission-id'
- ctx.clsiRequest = 'mock-request'
- })
- describe('with a successful compile', function () {
- beforeEach(async function (ctx) {
- ctx.outputFiles = [
- {
- url: `/project/${ctx.submissionId}/build/1234/output/output.pdf`,
- path: 'output.pdf',
- type: 'pdf',
- build: 1234,
- },
- {
- url: `/project/${ctx.submissionId}/build/1234/output/output.log`,
- path: 'output.log',
- type: 'log',
- build: 1234,
- },
- ]
- ctx.responseBody.compile.outputFiles = ctx.outputFiles.map(
- outputFile => ({
- ...outputFile,
- url: `http://${CLSI_HOST}${outputFile.url}`,
- })
- )
- ctx.result = await ctx.ClsiManager.promises.sendExternalRequest(
- ctx.submissionId,
- ctx.clsiRequest,
- { compileBackendClass: 'n2d', compileGroup: 'standard' }
- )
- })
- it('should send the request to the CLSI', function (ctx) {
- ctx.FetchUtils.fetchStringWithResponse.should.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname === `/project/${ctx.submissionId}/compile` &&
- url.searchParams.get('compileBackendClass') === 'n2d' &&
- url.searchParams.get('compileGroup') === 'standard'
- ),
- {
- method: 'POST',
- json: ctx.clsiRequest,
- headers: {
- Accept: 'application/json',
- 'Content-Type': 'application/json',
- Cookie: `${ctx.clsiCookieKey}=${ctx.clsiServerId}`,
- },
- signal: sinon.match.instanceOf(AbortSignal),
- }
- )
- })
- it('should return the status and output files', function (ctx) {
- expect(ctx.result.status).to.equal('success')
- expect(ctx.result.outputFiles.map(f => f.path)).to.have.members(
- ctx.outputFiles.map(f => f.path)
- )
- })
- })
- describe('with a failed compile', function () {
- beforeEach(async function (ctx) {
- ctx.responseBody.compile.status = 'failure'
- ctx.result = await ctx.ClsiManager.promises.sendExternalRequest(
- ctx.submissionId,
- ctx.clsiRequest,
- {}
- )
- })
- it('should return a failure status', function (ctx) {
- expect(ctx.result.status).to.equal('failure')
- })
- })
- describe('when the resources fail the precompile check', function () {
- beforeEach(async function (ctx) {
- ctx.ClsiFormatChecker.checkRecoursesForProblems.throws(
- new Error('failed')
- )
- ctx.responseBody.compile.status = 'failure'
- })
- it('should throw an error', async function (ctx) {
- await expect(
- ctx.ClsiManager.promises.sendExternalRequest(
- ctx.submissionId,
- ctx.clsiRequest,
- {}
- )
- ).to.be.rejected
- })
- })
- })
- describe('deleteAuxFiles', function () {
- describe('with the standard compileGroup', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.deleteAuxFiles(
- ctx.project._id,
- ctx.user_id,
- { compileBackendClass: 'n2d', compileGroup: 'standard' },
- 'node-1'
- )
- })
- it('should call the delete method in the standard CLSI', function (ctx) {
- ctx.FetchUtils.fetchString.should.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}` &&
- url.searchParams.get('compileBackendClass') === 'n2d' &&
- url.searchParams.get('compileGroup') === 'standard' &&
- url.searchParams.get('clsiserverid') === 'node-1'
- ),
- { method: 'DELETE' }
- )
- })
- it('should clear the output.tar.gz files in clsi-cache', function (ctx) {
- ctx.ClsiCacheHandler.clearCache
- .calledWith(ctx.project._id, ctx.user_id)
- .should.equal(true)
- })
- it('should clear the project state from the docupdater', function (ctx) {
- ctx.DocumentUpdaterHandler.promises.clearProjectState
- .calledWith(ctx.project._id)
- .should.equal(true)
- })
- it('should clear the clsi persistance', function (ctx) {
- ctx.ClsiCookieManager.promises.clearServerId
- .calledWith(ctx.project._id, ctx.user_id, 'n2d')
- .should.equal(true)
- })
- it('should not persist a cookie on response', function (ctx) {
- expect(ctx.ClsiCookieManager.promises.setServerId).not.to.have.been
- .called
- })
- })
- describe('when a new backend is configured', function () {
- beforeEach(async function (ctx) {
- ctx.Settings.apis.clsi_new = { url: 'https://compiles.somewhere.test' }
- await ctx.ClsiManager.promises.deleteAuxFiles(
- ctx.project._id,
- ctx.user_id,
- { compileBackendClass: 'c2d', compileGroup: 'priority' },
- 'node-1'
- )
- // wait for the background task to finish
- await setTimeout(0)
- })
- it('should clear both cookies', function (ctx) {
- expect(
- ctx.ClsiCookieManager.promises.clearServerId
- ).to.have.been.calledWith(ctx.project._id, ctx.user_id, 'c2d')
- expect(
- ctx.ClsiCookieManager.promises.clearServerId
- ).to.have.been.calledWith(ctx.project._id, ctx.user_id, 'n4')
- })
- it('should forward delete request', function (ctx) {
- expect(ctx.FetchUtils.fetchString).to.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}` &&
- url.searchParams.get('compileBackendClass') === 'c2d' &&
- url.searchParams.get('compileGroup') === 'priority' &&
- url.searchParams.get('clsiserverid') === 'node-1'
- ),
- { method: 'DELETE' }
- )
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match(
- url =>
- url.host === 'compiles.somewhere.test' &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}` &&
- url.searchParams.get('compileBackendClass') === 'n4' &&
- url.searchParams.get('compileGroup') === 'priority' &&
- !url.searchParams.has('clsiserverid')
- ),
- sinon.match({ method: 'DELETE' })
- )
- })
- })
- })
- describe('wordCount', function () {
- describe('with root file', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.wordCount(
- ctx.project._id,
- ctx.user_id,
- false,
- { compileBackendClass: 'n2d', compileGroup: 'standard' },
- 'node-1'
- )
- })
- it('should call wordCount with root file', function (ctx) {
- expect(ctx.FetchUtils.fetchString).to.have.been.calledWith(
- sinon.match(
- url =>
- url.toString() ===
- `http://clsi.example.com/project/${ctx.project._id}/user/${ctx.user_id}/wordcount?compileBackendClass=n2d&compileGroup=standard&file=main.tex&image=mock-image-name&clsiserverid=node-1`
- )
- )
- })
- it('should not persist a cookie on response', function (ctx) {
- expect(ctx.ClsiCookieManager.promises.setServerId).not.to.have.been
- .called
- })
- })
- describe('with param file', function () {
- beforeEach(async function (ctx) {
- await ctx.ClsiManager.promises.wordCount(
- ctx.project._id,
- ctx.user_id,
- 'other.tex',
- { compileBackendClass: 'n2d', compileGroup: 'standard' },
- 'node-2'
- )
- })
- it('should call wordCount with param file', function (ctx) {
- expect(ctx.FetchUtils.fetchString).to.have.been.calledWith(
- sinon.match(
- url =>
- url.host === CLSI_HOST &&
- url.pathname ===
- `/project/${ctx.project._id}/user/${ctx.user_id}/wordcount` &&
- url.searchParams.get('compileBackendClass') === 'n2d' &&
- url.searchParams.get('compileGroup') === 'standard' &&
- url.searchParams.get('clsiserverid') === 'node-2' &&
- url.searchParams.get('file') === 'other.tex' &&
- url.searchParams.get('image') === 'mock-image-name'
- )
- )
- })
- it('should not persist a cookie on response', function (ctx) {
- expect(ctx.ClsiCookieManager.promises.setServerId).not.to.have.been
- .called
- })
- })
- describe('when a new backend is configured', function () {
- beforeEach(async function (ctx) {
- ctx.Settings.apis.clsi_new = { url: 'https://compiles.somewhere.test' }
- await ctx.ClsiManager.promises.wordCount(
- ctx.project._id,
- ctx.user_id,
- false,
- { compileBackendClass: 'c2d', compileGroup: 'priority' },
- 'node-1'
- )
- // wait for the background task to finish
- await setTimeout(0)
- })
- it('should forward wordcount request', function (ctx) {
- expect(ctx.FetchUtils.fetchString).to.have.been.calledWith(
- sinon.match(
- url =>
- url.toString() ===
- `http://clsi.example.com/project/${ctx.project._id}/user/${ctx.user_id}/wordcount?compileBackendClass=c2d&compileGroup=priority&file=main.tex&image=mock-image-name&clsiserverid=node-1`
- )
- )
- expect(ctx.FetchUtils.fetchStringWithResponse).to.have.been.calledWith(
- sinon.match(
- url =>
- url.toString() ===
- `${ctx.Settings.apis.clsi_new.url}/project/${ctx.project._id}/user/${ctx.user_id}/wordcount?compileBackendClass=n4&compileGroup=priority&file=main.tex&image=mock-image-name`
- )
- )
- })
- })
- })
- })
- function _makeResources(project, docs, files) {
- const resources = []
- for (const [path, doc] of Object.entries(docs)) {
- resources.push({
- path: path.replace(/^\//, ''),
- content: doc.lines.join('\n'),
- })
- }
- for (const [path, file] of Object.entries(files)) {
- let url
- if (file.hash === GLOBAL_BLOB_HASH) {
- url = `${FILESTORE_URL}/history/global/hash/${file.hash}`
- } else {
- url = `${FILESTORE_URL}/history/project/${project.overleaf.history.id}/hash/${file.hash}`
- }
- resources.push({
- path: path.replace(/^\//, ''),
- url,
- modified: file.created.getTime(),
- })
- }
- return resources
- }
|