| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243 |
- const { expect } = require('chai')
- const sinon = require('sinon')
- const SandboxedModule = require('sandboxed-module')
- const Errors = require('../../../../app/src/Features/Errors/Errors')
- const MODULE_PATH =
- '../../../../app/src/Features/FileStore/FileStoreController.js'
- describe('FileStoreController', function() {
- beforeEach(function() {
- this.FileStoreHandler = {
- getFileStream: sinon.stub(),
- getFileSize: sinon.stub()
- }
- this.ProjectLocator = { findElement: sinon.stub() }
- this.controller = SandboxedModule.require(MODULE_PATH, {
- requires: {
- 'settings-sharelatex': this.settings,
- '../Project/ProjectLocator': this.ProjectLocator,
- './FileStoreHandler': this.FileStoreHandler
- }
- })
- this.stream = {}
- this.projectId = '2k3j1lk3j21lk3j'
- this.fileId = '12321kklj1lk3jk12'
- this.req = {
- params: {
- Project_id: this.projectId,
- File_id: this.fileId
- },
- query: 'query string here',
- get(key) {
- return undefined
- }
- }
- this.res = {
- set: sinon.stub().returnsThis(),
- setHeader: sinon.stub(),
- setContentDisposition: sinon.stub(),
- status: sinon.stub().returnsThis()
- }
- this.file = { name: 'myfile.png' }
- })
- describe('getFile', function() {
- beforeEach(function() {
- this.FileStoreHandler.getFileStream.callsArgWith(3, null, this.stream)
- this.ProjectLocator.findElement.callsArgWith(1, null, this.file)
- })
- it('should call the file store handler with the project_id file_id and any query string', function(done) {
- this.stream.pipe = des => {
- this.FileStoreHandler.getFileStream
- .calledWith(
- this.req.params.Project_id,
- this.req.params.File_id,
- this.req.query
- )
- .should.equal(true)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- it('should pipe to res', function(done) {
- this.stream.pipe = des => {
- des.should.equal(this.res)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- it('should get the file from the db', function(done) {
- this.stream.pipe = des => {
- const opts = {
- project_id: this.projectId,
- element_id: this.fileId,
- type: 'file'
- }
- this.ProjectLocator.findElement.calledWith(opts).should.equal(true)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- it('should set the Content-Disposition header', function(done) {
- this.stream.pipe = des => {
- this.res.setContentDisposition
- .calledWith('attachment', { filename: this.file.name })
- .should.equal(true)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- // Test behaviour around handling html files
- ;['.html', '.htm', '.xhtml'].forEach(extension => {
- describe(`with a '${extension}' file extension`, function() {
- beforeEach(function() {
- this.file.name = `bad${extension}`
- this.req.get = key => {
- if (key === 'User-Agent') {
- return 'A generic browser'
- }
- }
- })
- describe('from a non-ios browser', function() {
- it('should not set Content-Type', function(done) {
- this.stream.pipe = des => {
- this.res.setHeader
- .calledWith('Content-Type', 'text/plain')
- .should.equal(false)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- })
- describe('from an iPhone', function() {
- beforeEach(function() {
- this.req.get = key => {
- if (key === 'User-Agent') {
- return 'An iPhone browser'
- }
- }
- })
- it("should set Content-Type to 'text/plain'", function(done) {
- this.stream.pipe = des => {
- this.res.setHeader
- .calledWith('Content-Type', 'text/plain')
- .should.equal(true)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- })
- describe('from an iPad', function() {
- beforeEach(function() {
- this.req.get = key => {
- if (key === 'User-Agent') {
- return 'An iPad browser'
- }
- }
- })
- it("should set Content-Type to 'text/plain'", function(done) {
- this.stream.pipe = des => {
- this.res.setHeader
- .calledWith('Content-Type', 'text/plain')
- .should.equal(true)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- })
- })
- })
- ;[
- // None of these should trigger the iOS/html logic
- ('x.html-is-rad',
- 'html.pdf',
- '.html-is-good-for-hidden-files',
- 'somefile')
- ].forEach(filename => {
- describe(`with filename as '${filename}'`, function() {
- beforeEach(function() {
- this.user_agent = 'A generic browser'
- this.file.name = filename
- this.req.get = key => {
- if (key === 'User-Agent') {
- return this.user_agent
- }
- }
- })
- ;[('iPhone', 'iPad', 'Firefox', 'Chrome')].forEach(browser => {
- describe(`downloaded from ${browser}`, function() {
- beforeEach(function() {
- this.user_agent = `Some ${browser} thing`
- })
- it('Should not set the Content-type', function(done) {
- this.stream.pipe = des => {
- this.res.setHeader
- .calledWith('Content-Type', 'text/plain')
- .should.equal(false)
- done()
- }
- this.controller.getFile(this.req, this.res)
- })
- })
- })
- })
- })
- })
- describe('getFileHead', function() {
- it('reports the file size', function(done) {
- const expectedFileSize = 99393
- this.FileStoreHandler.getFileSize.yields(
- new Error('getFileSize: unexpected arguments')
- )
- this.FileStoreHandler.getFileSize
- .withArgs(this.projectId, this.fileId)
- .yields(null, expectedFileSize)
- this.res.end = () => {
- expect(this.res.status.lastCall.args).to.deep.equal([200])
- expect(this.res.set.lastCall.args).to.deep.equal([
- 'Content-Length',
- expectedFileSize
- ])
- done()
- }
- this.controller.getFileHead(this.req, this.res)
- })
- it('returns 404 on NotFoundError', function(done) {
- this.FileStoreHandler.getFileSize.yields(new Errors.NotFoundError())
- this.res.end = () => {
- expect(this.res.status.lastCall.args).to.deep.equal([404])
- done()
- }
- this.controller.getFileHead(this.req, this.res)
- })
- it('returns 500 on error', function(done) {
- this.FileStoreHandler.getFileSize.yields(new Error('boom!'))
- this.res.end = () => {
- expect(this.res.status.lastCall.args).to.deep.equal([500])
- done()
- }
- this.controller.getFileHead(this.req, this.res)
- })
- })
- })
|