| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132 |
- const sinon = require('sinon')
- const { expect } = require('chai')
- const modulePath = '../../../../app/js/DocumentManager.js'
- const SandboxedModule = require('sandboxed-module')
- const Errors = require('../../../../app/js/Errors')
- const tk = require('timekeeper')
- describe('DocumentManager', function () {
- beforeEach(function () {
- tk.freeze(new Date())
- this.Metrics = {
- Timer: class Timer {},
- inc: sinon.stub(),
- }
- this.Metrics.Timer.prototype.done = sinon.stub()
- this.RedisManager = {
- promises: {
- clearUnflushedTime: sinon.stub().resolves(),
- getDoc: sinon.stub(),
- getPreviousDocOps: sinon.stub(),
- putDocInMemory: sinon.stub().resolves(),
- removeDocFromMemory: sinon.stub().resolves(),
- renameDoc: sinon.stub().resolves(),
- updateCommentState: sinon.stub().resolves(),
- updateDocument: sinon.stub().resolves(),
- },
- }
- this.ProjectHistoryRedisManager = {
- promises: {
- queueOps: sinon.stub().resolves(),
- queueResyncDocContent: sinon.stub().resolves(),
- },
- }
- this.PersistenceManager = {
- promises: {
- getDoc: sinon.stub(),
- setDoc: sinon.stub().resolves(),
- },
- }
- this.HistoryManager = {
- flushProjectChangesAsync: sinon.stub(),
- }
- this.DiffCodec = {
- diffAsShareJsOp: sinon.stub(),
- }
- this.UpdateManager = {
- promises: {
- applyUpdate: sinon.stub().resolves(),
- },
- }
- this.RangesManager = {
- acceptChanges: sinon.stub(),
- deleteComment: sinon.stub(),
- }
- this.DocumentManager = SandboxedModule.require(modulePath, {
- requires: {
- './RedisManager': this.RedisManager,
- './ProjectHistoryRedisManager': this.ProjectHistoryRedisManager,
- './PersistenceManager': this.PersistenceManager,
- './HistoryManager': this.HistoryManager,
- './Metrics': this.Metrics,
- './DiffCodec': this.DiffCodec,
- './UpdateManager': this.UpdateManager,
- './RangesManager': this.RangesManager,
- './Errors': Errors,
- },
- })
- this.project_id = 'project-id-123'
- this.projectHistoryId = 'history-id-123'
- this.doc_id = 'doc-id-123'
- this.user_id = 1234
- this.lines = ['one', 'two', 'three']
- this.version = 42
- this.ranges = { comments: 'mock', entries: 'mock' }
- this.resolvedCommentIds = ['comment-1']
- this.pathname = '/a/b/c.tex'
- this.unflushedTime = Date.now()
- this.lastUpdatedAt = Date.now()
- this.lastUpdatedBy = 'last-author-id'
- this.source = 'external-source'
- this.historyRangesSupport = false
- })
- afterEach(function () {
- tk.reset()
- })
- describe('flushAndDeleteDoc', function () {
- describe('successfully', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- await this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- {}
- )
- })
- it('should flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should remove the doc from redis', function () {
- this.RedisManager.promises.removeDocFromMemory
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when a flush error occurs', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon
- .stub()
- .rejects(new Error('boom!'))
- await expect(
- this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- {}
- )
- ).to.be.rejected
- })
- it('should not remove the doc from redis', function () {
- this.RedisManager.promises.removeDocFromMemory.called.should.equal(
- false
- )
- })
- describe('when ignoring flush errors', function () {
- it('should remove the doc from redis', async function () {
- await this.DocumentManager.promises.flushAndDeleteDoc(
- this.project_id,
- this.doc_id,
- { ignoreFlushErrors: true }
- )
- this.RedisManager.promises.removeDocFromMemory.called.should.equal(
- true
- )
- })
- })
- })
- })
- describe('flushDocIfLoaded', function () {
- describe('when the doc is in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- lastUpdatedAt: this.lastUpdatedAt,
- lastUpdatedBy: this.lastUpdatedBy,
- })
- await this.DocumentManager.promises.flushDocIfLoaded(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should write the doc lines to the persistence layer', function () {
- this.PersistenceManager.promises.setDoc.should.have.been.calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- this.ranges,
- this.lastUpdatedAt,
- this.lastUpdatedBy
- )
- })
- })
- describe('when the document is not in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: null,
- version: null,
- ranges: null,
- })
- await this.DocumentManager.promises.flushDocIfLoaded(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not write anything to the persistence layer', function () {
- this.PersistenceManager.promises.setDoc.called.should.equal(false)
- })
- })
- })
- describe('getDocAndRecentOps', function () {
- describe('with a previous version specified', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- })
- this.RedisManager.promises.getPreviousDocOps.resolves(this.ops)
- this.result = await this.DocumentManager.promises.getDocAndRecentOps(
- this.project_id,
- this.doc_id,
- this.fromVersion
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should get the doc ops', function () {
- this.RedisManager.promises.getPreviousDocOps
- .calledWith(this.doc_id, this.fromVersion, this.version)
- .should.equal(true)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ops: this.ops,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- })
- })
- })
- describe('with no previous version specified', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- })
- this.RedisManager.promises.getPreviousDocOps.resolves(this.ops)
- this.result = await this.DocumentManager.promises.getDocAndRecentOps(
- this.project_id,
- this.doc_id,
- -1
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not need to get the doc ops', function () {
- this.RedisManager.promises.getPreviousDocOps.called.should.equal(false)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ops: [],
- ranges: this.ranges,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- })
- })
- })
- })
- describe('getDoc', function () {
- describe('when the doc exists in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- lastUpdatedAt: this.lastUpdatedAt,
- lastUpdatedBy: this.lastUpdatedBy,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.result = await this.DocumentManager.promises.getDoc(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc from Redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return the doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: true,
- historyRangesSupport: this.historyRangesSupport,
- })
- })
- })
- describe('when the doc does not exist in Redis', function () {
- beforeEach(async function () {
- this.RedisManager.promises.getDoc.resolves({
- lines: null,
- version: null,
- ranges: null,
- pathname: null,
- projectHistoryId: null,
- })
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.result = await this.DocumentManager.promises.getDoc(
- this.project_id,
- this.doc_id
- )
- })
- it('should try to get the doc from Redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should get the doc from the PersistenceManager', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should set the doc in Redis', function () {
- this.RedisManager.promises.putDocInMemory
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- this.ranges,
- this.resolvedCommentIds,
- this.pathname,
- this.projectHistoryId,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- it('should return doc info', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: null,
- alreadyLoaded: false,
- historyRangesSupport: this.historyRangesSupport,
- })
- })
- })
- })
- describe('setDoc', function () {
- describe('with plain tex lines', function () {
- beforeEach(function () {
- this.beforeLines = ['before', 'lines']
- this.afterLines = ['after', 'lines']
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: true,
- })
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- this.DocumentManager.promises.flushAndDeleteDoc = sinon
- .stub()
- .resolves()
- })
- describe('when not loaded but with the same content', function () {
- beforeEach(async function () {
- this.DiffCodec.diffAsShareJsOp.returns([])
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: this.unflushedTime,
- alreadyLoaded: false,
- })
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.beforeLines,
- this.source,
- this.user_id,
- false
- )
- })
- it('should not apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate.called.should.equal(false)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'noop',
- method: 'evict',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush and delete the doc from redis', function () {
- this.DocumentManager.promises.flushAndDeleteDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when already loaded with the same content', function () {
- beforeEach(async function () {
- this.DiffCodec.diffAsShareJsOp.returns([])
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.beforeLines,
- this.source,
- this.user_id,
- false
- )
- })
- it('should not apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate.called.should.equal(false)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'noop',
- method: 'flush',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush the doc to Mongo', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- })
- describe('when already loaded', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- false
- )
- })
- it('should get the current doc lines', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return a diff of the old and new lines', function () {
- this.DiffCodec.diffAsShareJsOp
- .calledWith(this.beforeLines, this.afterLines)
- .should.equal(true)
- })
- it('should apply the diff as a ShareJS op', function () {
- this.UpdateManager.promises.applyUpdate
- .calledWith(this.project_id, this.doc_id, {
- doc: this.doc_id,
- v: this.version,
- op: this.ops,
- meta: {
- type: 'external',
- source: this.source,
- user_id: this.user_id,
- },
- })
- .should.equal(true)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'diff',
- method: 'flush',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should flush the doc to Mongo', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the project history', function () {
- this.HistoryManager.flushProjectChangesAsync.called.should.equal(
- false
- )
- })
- })
- describe('when not already loaded', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.beforeLines,
- version: this.version,
- pathname: this.pathname,
- unflushedTime: null,
- alreadyLoaded: false,
- })
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- false
- )
- })
- it('should flush and delete the doc from the doc updater', function () {
- this.DocumentManager.promises.flushAndDeleteDoc
- .calledWith(this.project_id, this.doc_id, {})
- .should.equal(true)
- })
- it('should increment the external update metric', function () {
- this.Metrics.inc
- .calledWith('external-update', 1, {
- status: 'diff',
- method: 'evict',
- path: this.source,
- })
- .should.equal(true)
- })
- it('should not flush the project history', function () {
- this.HistoryManager.flushProjectChangesAsync
- .calledWithExactly(this.project_id)
- .should.equal(true)
- })
- })
- describe('without new lines', function () {
- beforeEach(async function () {
- await expect(
- this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- null,
- this.source,
- this.user_id,
- false
- )
- ).to.be.rejectedWith('No lines were provided to setDoc')
- })
- it('should not try to get the doc lines', function () {
- this.DocumentManager.promises.getDoc.called.should.equal(false)
- })
- })
- describe('with the undoing flag', function () {
- beforeEach(async function () {
- // Copy ops so we don't interfere with other tests
- this.ops = [
- { i: 'foo', p: 4 },
- { d: 'bar', p: 42 },
- ]
- this.DiffCodec.diffAsShareJsOp.returns(this.ops)
- await this.DocumentManager.promises.setDoc(
- this.project_id,
- this.doc_id,
- this.afterLines,
- this.source,
- this.user_id,
- true
- )
- })
- it('should set the undo flag on each op', function () {
- this.ops.map(op => op.u.should.equal(true))
- })
- })
- })
- })
- describe('acceptChanges', function () {
- beforeEach(function () {
- this.change_id = 'mock-change-id'
- this.change_ids = [
- 'mock-change-id-1',
- 'mock-change-id-2',
- 'mock-change-id-3',
- 'mock-change-id-4',
- ]
- this.version = 34
- this.lines = ['original', 'lines']
- this.ranges = { entries: 'mock', comments: 'mock' }
- this.updated_ranges = { entries: 'updated', comments: 'updated' }
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- })
- this.RangesManager.acceptChanges.returns(this.updated_ranges)
- })
- describe('successfully with a single change', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.change_id]
- )
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should apply the accept change to the ranges', function () {
- this.RangesManager.acceptChanges.should.have.been.calledWith(
- [this.change_id],
- this.ranges
- )
- })
- it('should save the updated ranges', function () {
- this.RedisManager.promises.updateDocument
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- [],
- this.updated_ranges,
- {}
- )
- .should.equal(true)
- })
- })
- describe('successfully with multiple changes', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- this.change_ids
- )
- })
- it('should apply the accept change to the ranges', function () {
- this.RangesManager.acceptChanges
- .calledWith(this.change_ids, this.ranges)
- .should.equal(true)
- })
- })
- describe('when the doc is not found', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon
- .stub()
- .resolves({ lines: null, version: null, ranges: null })
- await expect(
- this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.change_id]
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- it('should not save anything', function () {
- this.RedisManager.promises.updateDocument.called.should.equal(false)
- })
- })
- })
- describe('deleteComment', function () {
- beforeEach(function () {
- this.comment_id = 'mock-comment-id'
- this.version = 34
- this.lines = ['original', 'lines']
- this.ranges = { comments: ['one', 'two', 'three'] }
- this.resolvedCommentIds = ['comment1']
- this.updated_ranges = { comments: ['one', 'three'] }
- this.historyRangesSupport = true
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- unflushedTime: Date.now() - 1e9,
- alreadyLoaded: true,
- historyRangesSupport: this.historyRangesSupport,
- })
- this.RangesManager.deleteComment.returns(this.updated_ranges)
- })
- describe('successfully', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.deleteComment(
- this.project_id,
- this.doc_id,
- this.comment_id,
- this.user_id
- )
- })
- it("should get the document's current ranges", function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should delete the comment from the ranges', function () {
- this.RangesManager.deleteComment
- .calledWith(this.comment_id, this.ranges)
- .should.equal(true)
- })
- it('should save the updated ranges', function () {
- this.RedisManager.promises.updateDocument
- .calledWith(
- this.project_id,
- this.doc_id,
- this.lines,
- this.version,
- [],
- this.updated_ranges,
- {}
- )
- .should.equal(true)
- })
- it('should unset the comment resolved state', function () {
- this.RedisManager.promises.updateCommentState.should.have.been.calledWith(
- this.doc_id,
- this.comment_id,
- false
- )
- })
- it('should queue the delete comment operation', function () {
- this.ProjectHistoryRedisManager.promises.queueOps.should.have.been.calledWith(
- this.project_id,
- JSON.stringify({
- pathname: this.pathname,
- deleteComment: this.comment_id,
- meta: {
- ts: new Date(),
- user_id: this.user_id,
- },
- })
- )
- })
- })
- describe('when the doc is not found', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon
- .stub()
- .resolves({ lines: null, version: null, ranges: null })
- await expect(
- this.DocumentManager.promises.acceptChanges(
- this.project_id,
- this.doc_id,
- [this.comment_id]
- )
- ).to.be.rejectedWith(Errors.NotFoundError)
- })
- it('should not save anything', function () {
- this.RedisManager.promises.updateDocument.called.should.equal(false)
- })
- })
- })
- describe('getDocAndFlushIfOld', function () {
- beforeEach(function () {
- this.DocumentManager.promises.flushDocIfLoaded = sinon.stub().resolves()
- })
- describe('when the doc is in Redis', function () {
- describe('and has changes to be flushed', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- projectHistoryId: this.projectHistoryId,
- pathname: this.pathname,
- unflushedTime: Date.now() - 1e9,
- alreadyLoaded: true,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- describe("and has only changes that don't need to be flushed", function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- pathname: this.pathname,
- unflushedTime: Date.now() - 100,
- alreadyLoaded: true,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded.called.should.equal(
- false
- )
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- })
- describe('when the doc is not in Redis', function () {
- beforeEach(async function () {
- this.DocumentManager.promises.getDoc = sinon.stub().resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- alreadyLoaded: false,
- })
- this.result = await this.DocumentManager.promises.getDocAndFlushIfOld(
- this.project_id,
- this.doc_id
- )
- })
- it('should get the doc', function () {
- this.DocumentManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('should not flush the doc', function () {
- this.DocumentManager.promises.flushDocIfLoaded.called.should.equal(
- false
- )
- })
- it('should return the lines and versions', function () {
- expect(this.result).to.deep.equal({
- lines: this.lines,
- version: this.version,
- })
- })
- })
- })
- describe('renameDoc', function () {
- beforeEach(function () {
- this.update = 'some-update'
- })
- describe('successfully', function () {
- beforeEach(async function () {
- await this.DocumentManager.promises.renameDoc(
- this.project_id,
- this.doc_id,
- this.user_id,
- this.update,
- this.projectHistoryId
- )
- })
- it('should rename the document', function () {
- this.RedisManager.promises.renameDoc
- .calledWith(
- this.project_id,
- this.doc_id,
- this.user_id,
- this.update,
- this.projectHistoryId
- )
- .should.equal(true)
- })
- })
- })
- describe('resyncDocContents', function () {
- describe('when doc is loaded in redis', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('gets the doc contents from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('queues a resync doc content update', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- this.ranges,
- this.resolvedCommentIds,
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- describe('when doc is not loaded in redis', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({})
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: this.ranges,
- resolvedCommentIds: this.resolvedCommentIds,
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('tries to get the doc contents from redis', function () {
- this.RedisManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id)
- .should.equal(true)
- })
- it('gets the doc contents from web', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id, { peek: true })
- .should.equal(true)
- })
- it('queues a resync doc content update', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- this.ranges,
- this.resolvedCommentIds,
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- describe('when a doc has no ranges in docstore', function () {
- beforeEach(async function () {
- this.pathnameFromProjectStructureUpdate = '/foo/bar.tex'
- this.RedisManager.promises.getDoc.resolves({})
- this.PersistenceManager.promises.getDoc.resolves({
- lines: this.lines,
- version: this.version,
- ranges: undefined,
- resolvedCommentIds: [],
- pathname: this.pathname,
- projectHistoryId: this.projectHistoryId,
- historyRangesSupport: this.historyRangesSupport,
- })
- await this.DocumentManager.promises.resyncDocContents(
- this.project_id,
- this.doc_id,
- this.pathnameFromProjectStructureUpdate
- )
- })
- it('gets the doc contents from web', function () {
- this.PersistenceManager.promises.getDoc
- .calledWith(this.project_id, this.doc_id, { peek: true })
- .should.equal(true)
- })
- it('queues a resync doc content update with an empty ranges object', function () {
- this.ProjectHistoryRedisManager.promises.queueResyncDocContent
- .calledWith(
- this.project_id,
- this.projectHistoryId,
- this.doc_id,
- this.lines,
- {},
- [],
- this.version,
- this.pathnameFromProjectStructureUpdate,
- this.historyRangesSupport
- )
- .should.equal(true)
- })
- })
- })
- })
|