| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614 |
- /* eslint-disable
- handle-callback-err,
- max-len,
- no-return-assign,
- no-unused-vars,
- no-useless-escape,
- */
- // TODO: This file was created by bulk-decaffeinate.
- // Fix any style issues and re-enable lint.
- /*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
- const sinon = require('sinon')
- const chai = require('chai')
- const should = chai.should()
- const { expect } = chai
- const modulePath =
- '../../../../app/src/Features/Authentication/AuthenticationManager.js'
- const SandboxedModule = require('sandboxed-module')
- const events = require('events')
- const { ObjectId } = require('mongojs')
- const Errors = require('../../../../app/src/Features/Errors/Errors')
- describe('AuthenticationManager', function() {
- beforeEach(function() {
- this.settings = { security: { bcryptRounds: 12 } }
- this.AuthenticationManager = SandboxedModule.require(modulePath, {
- globals: {
- console: console
- },
- requires: {
- '../../models/User': {
- User: (this.User = {})
- },
- '../../infrastructure/mongojs': {
- db: (this.db = { users: {} }),
- ObjectId
- },
- bcrypt: (this.bcrypt = {}),
- 'settings-sharelatex': this.settings,
- '../V1/V1Handler': (this.V1Handler = {}),
- '../User/UserGetter': (this.UserGetter = {})
- }
- })
- return (this.callback = sinon.stub())
- })
- describe('with real bcrypt', function() {
- beforeEach(function() {
- const bcrypt = require('bcrypt')
- this.bcrypt.compare = bcrypt.compare
- this.bcrypt.getRounds = bcrypt.getRounds
- this.bcrypt.genSalt = bcrypt.genSalt
- this.bcrypt.hash = bcrypt.hash
- // Hash of 'testpassword'
- return (this.testPassword =
- '$2a$12$zhtThy3R5tLtw5sCwr5XD.zhPENGn4ecjeMcP87oYSYrIICFqBpei')
- })
- describe('authenticate', function() {
- beforeEach(function() {
- this.user = {
- _id: 'user-id',
- email: (this.email = 'USER@sharelatex.com')
- }
- return (this.User.findOne = sinon
- .stub()
- .callsArgWith(1, null, this.user))
- })
- describe('when the hashed password matches', function() {
- beforeEach(function(done) {
- this.unencryptedPassword = 'testpassword'
- this.user.hashedPassword = this.testPassword
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencryptedPassword,
- (error, user) => {
- this.callback(error, user)
- return done()
- }
- )
- })
- it('should look up the correct user in the database', function() {
- return this.User.findOne
- .calledWith({ email: this.email })
- .should.equal(true)
- })
- it('should return the user', function() {
- return this.callback.calledWith(null, this.user).should.equal(true)
- })
- })
- describe('when the encrypted passwords do not match', function() {
- beforeEach(function() {
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- 'notthecorrectpassword',
- this.callback
- )
- })
- it('should not return the user', function() {
- return this.callback.calledWith(null, null).should.equal(true)
- })
- })
- })
- describe('setUserPasswordInV2', function() {
- beforeEach(function() {
- this.user = {
- _id: '5c8791477192a80b5e76ca7e',
- email: (this.email = 'USER@sharelatex.com')
- }
- return (this.db.users.update = sinon
- .stub()
- .callsArgWith(2, null, { nModified: 1 }))
- })
- it('should not produce an error', function(done) {
- return this.AuthenticationManager.setUserPasswordInV2(
- this.user._id,
- 'testpassword',
- (err, updated) => {
- expect(err).to.not.exist
- expect(updated).to.equal(true)
- return done()
- }
- )
- })
- it('should set the hashed password', function(done) {
- return this.AuthenticationManager.setUserPasswordInV2(
- this.user._id,
- 'testpassword',
- (err, updated) => {
- expect(err).to.not.exist
- const {
- hashedPassword
- } = this.db.users.update.lastCall.args[1].$set
- expect(hashedPassword).to.exist
- expect(hashedPassword.length).to.equal(60)
- expect(hashedPassword).to.match(/^\$2a\$12\$[a-zA-Z0-9\/.]{53}$/)
- return done()
- }
- )
- })
- })
- })
- describe('authenticate', function() {
- describe('when the user exists in the database', function() {
- beforeEach(function() {
- this.user = {
- _id: 'user-id',
- email: (this.email = 'USER@sharelatex.com')
- }
- this.unencryptedPassword = 'banana'
- return (this.User.findOne = sinon
- .stub()
- .callsArgWith(1, null, this.user))
- })
- describe('when the hashed password matches', function() {
- beforeEach(function(done) {
- this.user.hashedPassword = this.hashedPassword = 'asdfjadflasdf'
- this.bcrypt.compare = sinon.stub().callsArgWith(2, null, true)
- this.bcrypt.getRounds = sinon.stub().returns(12)
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencryptedPassword,
- (error, user) => {
- this.callback(error, user)
- return done()
- }
- )
- })
- it('should look up the correct user in the database', function() {
- return this.User.findOne
- .calledWith({ email: this.email })
- .should.equal(true)
- })
- it('should check that the passwords match', function() {
- return this.bcrypt.compare
- .calledWith(this.unencryptedPassword, this.hashedPassword)
- .should.equal(true)
- })
- it('should return the user', function() {
- return this.callback.calledWith(null, this.user).should.equal(true)
- })
- })
- describe('when the encrypted passwords do not match', function() {
- beforeEach(function() {
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencryptedPassword,
- this.callback
- )
- })
- it('should not return the user', function() {
- return this.callback.calledWith(null, null).should.equal(true)
- })
- })
- describe('when the hashed password matches but the number of rounds is too low', function() {
- beforeEach(function(done) {
- this.user.hashedPassword = this.hashedPassword = 'asdfjadflasdf'
- this.bcrypt.compare = sinon.stub().callsArgWith(2, null, true)
- this.bcrypt.getRounds = sinon.stub().returns(7)
- this.AuthenticationManager.setUserPassword = sinon
- .stub()
- .callsArgWith(2, null)
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencryptedPassword,
- (error, user) => {
- this.callback(error, user)
- return done()
- }
- )
- })
- it('should look up the correct user in the database', function() {
- return this.User.findOne
- .calledWith({ email: this.email })
- .should.equal(true)
- })
- it('should check that the passwords match', function() {
- return this.bcrypt.compare
- .calledWith(this.unencryptedPassword, this.hashedPassword)
- .should.equal(true)
- })
- it('should check the number of rounds', function() {
- return this.bcrypt.getRounds.called.should.equal(true)
- })
- it('should set the users password (with a higher number of rounds)', function() {
- return this.AuthenticationManager.setUserPassword
- .calledWith('user-id', this.unencryptedPassword)
- .should.equal(true)
- })
- it('should return the user', function() {
- return this.callback.calledWith(null, this.user).should.equal(true)
- })
- })
- describe('when the hashed password matches but the number of rounds is too low, but upgrades disabled', function() {
- beforeEach(function(done) {
- this.settings.security.disableBcryptRoundsUpgrades = true
- this.user.hashedPassword = this.hashedPassword = 'asdfjadflasdf'
- this.bcrypt.compare = sinon.stub().callsArgWith(2, null, true)
- this.bcrypt.getRounds = sinon.stub().returns(7)
- this.AuthenticationManager.setUserPassword = sinon
- .stub()
- .callsArgWith(2, null)
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencryptedPassword,
- (error, user) => {
- this.callback(error, user)
- return done()
- }
- )
- })
- it('should not check the number of rounds', function() {
- return this.bcrypt.getRounds.called.should.equal(false)
- })
- it('should not set the users password (with a higher number of rounds)', function() {
- return this.AuthenticationManager.setUserPassword
- .calledWith('user-id', this.unencryptedPassword)
- .should.equal(false)
- })
- it('should return the user', function() {
- return this.callback.calledWith(null, this.user).should.equal(true)
- })
- })
- })
- describe('when the user does not exist in the database', function() {
- beforeEach(function() {
- this.User.findOne = sinon.stub().callsArgWith(1, null, null)
- return this.AuthenticationManager.authenticate(
- { email: this.email },
- this.unencrpytedPassword,
- this.callback
- )
- })
- it('should not return a user', function() {
- return this.callback.calledWith(null, null).should.equal(true)
- })
- })
- })
- describe('validateEmail', function() {
- describe('valid', () =>
- it('should return null', function() {
- const result = this.AuthenticationManager.validateEmail(
- 'foo@example.com'
- )
- return expect(result).to.equal(null)
- }))
- describe('invalid', function() {
- it('should return validation error object for no email', function() {
- const result = this.AuthenticationManager.validateEmail('')
- expect(result).to.not.equal(null)
- return expect(result.message).to.equal('email not valid')
- })
- it('should return validation error object for invalid', function() {
- const result = this.AuthenticationManager.validateEmail('notanemail')
- expect(result).to.not.equal(null)
- return expect(result.message).to.equal('email not valid')
- })
- })
- })
- describe('validatePassword', function() {
- beforeEach(function() {
- // 73 characters:
- return (this.longPassword =
- '0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef012345678')
- })
- describe('with a null password', () =>
- it('should return an error', function() {
- return expect(this.AuthenticationManager.validatePassword()).to.eql({
- message: 'password not set'
- })
- }))
- describe('password length', function() {
- describe('with the default password length options', function() {
- it('should reject passwords that are too short', function() {
- expect(this.AuthenticationManager.validatePassword('')).to.eql({
- message: 'password is too short'
- })
- return expect(
- this.AuthenticationManager.validatePassword('foo')
- ).to.eql({ message: 'password is too short' })
- })
- it('should reject passwords that are too long', function() {
- return expect(
- this.AuthenticationManager.validatePassword(this.longPassword)
- ).to.eql({ message: 'password is too long' })
- })
- it('should accept passwords that are a good length', function() {
- return expect(
- this.AuthenticationManager.validatePassword('l337h4x0r')
- ).to.equal(null)
- })
- })
- describe('when the password length is specified in settings', function() {
- beforeEach(function() {
- return (this.settings.passwordStrengthOptions = {
- length: {
- min: 10,
- max: 12
- }
- })
- })
- it('should reject passwords that are too short', function() {
- return expect(
- this.AuthenticationManager.validatePassword('012345678')
- ).to.eql({ message: 'password is too short' })
- })
- it('should accept passwords of exactly minimum length', function() {
- return expect(
- this.AuthenticationManager.validatePassword('0123456789')
- ).to.equal(null)
- })
- it('should reject passwords that are too long', function() {
- return expect(
- this.AuthenticationManager.validatePassword('0123456789abc')
- ).to.eql({ message: 'password is too long' })
- })
- it('should accept passwords of exactly maximum length', function() {
- return expect(
- this.AuthenticationManager.validatePassword('0123456789ab')
- ).to.equal(null)
- })
- })
- describe('when the maximum password length is set to >72 characters in settings', function() {
- beforeEach(function() {
- return (this.settings.passwordStrengthOptions = {
- length: {
- max: 128
- }
- })
- })
- it('should still reject passwords > 72 characters in length', function() {
- return expect(
- this.AuthenticationManager.validatePassword(this.longPassword)
- ).to.eql({ message: 'password is too long' })
- })
- })
- })
- describe('allowed characters', function() {
- describe('with the default settings for allowed characters', function() {
- it('should allow passwords with valid characters', function() {
- expect(
- this.AuthenticationManager.validatePassword(
- 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'
- )
- ).to.equal(null)
- return expect(
- this.AuthenticationManager.validatePassword(
- '1234567890@#$%^&*()-_=+[]{};:<>/?!£€.,'
- )
- ).to.equal(null)
- })
- it('should not allow passwords with invalid characters', function() {
- return expect(
- this.AuthenticationManager.validatePassword(
- 'correct horse battery staple'
- )
- ).to.eql({ message: 'password contains an invalid character' })
- })
- })
- describe('when valid characters are overridden in settings', function() {
- beforeEach(function() {
- return (this.settings.passwordStrengthOptions = {
- chars: {
- symbols: ' '
- }
- })
- })
- it('should allow passwords with valid characters', function() {
- return expect(
- this.AuthenticationManager.validatePassword(
- 'correct horse battery staple'
- )
- ).to.equal(null)
- })
- it('should disallow passwords with invalid characters', function() {
- return expect(
- this.AuthenticationManager.validatePassword(
- '1234567890@#$%^&*()-_=+[]{};:<>/?!£€.,'
- )
- ).to.eql({ message: 'password contains an invalid character' })
- })
- })
- describe('when allowAnyChars is set', function() {
- beforeEach(function() {
- return (this.settings.passwordStrengthOptions = {
- allowAnyChars: true
- })
- })
- it('should allow any characters', function() {
- expect(
- this.AuthenticationManager.validatePassword(
- 'correct horse battery staple'
- )
- ).to.equal(null)
- return expect(
- this.AuthenticationManager.validatePassword(
- '1234567890@#$%^&*()-_=+[]{};:<>/?!£€.,'
- )
- ).to.equal(null)
- })
- })
- })
- })
- describe('setUserPassword', function() {
- beforeEach(function() {
- this.user_id = ObjectId()
- this.password = 'banana'
- this.hashedPassword = 'asdkjfa;osiuvandf'
- this.salt = 'saltaasdfasdfasdf'
- this.bcrypt.genSalt = sinon.stub().callsArgWith(2, null, this.salt)
- this.bcrypt.hash = sinon.stub().callsArgWith(2, null, this.hashedPassword)
- return (this.db.users.update = sinon.stub().callsArg(2))
- })
- describe('too long', function() {
- beforeEach(function() {
- this.settings.passwordStrengthOptions = {
- length: {
- max: 10
- }
- }
- return (this.password = 'dsdsadsadsadsadsadkjsadjsadjsadljs')
- })
- it('should return and error', function(done) {
- return this.AuthenticationManager.setUserPassword(
- this.user_id,
- this.password,
- function(err) {
- expect(err).to.exist
- return done()
- }
- )
- })
- it('should not start the bcrypt process', function(done) {
- return this.AuthenticationManager.setUserPassword(
- this.user_id,
- this.password,
- err => {
- this.bcrypt.genSalt.called.should.equal(false)
- this.bcrypt.hash.called.should.equal(false)
- return done()
- }
- )
- })
- })
- describe('too short', function() {
- beforeEach(function() {
- this.settings.passwordStrengthOptions = {
- length: {
- max: 10,
- min: 6
- }
- }
- return (this.password = 'dsd')
- })
- it('should return and error', function(done) {
- return this.AuthenticationManager.setUserPassword(
- this.user_id,
- this.password,
- function(err) {
- expect(err).to.exist
- return done()
- }
- )
- })
- it('should not start the bcrypt process', function(done) {
- return this.AuthenticationManager.setUserPassword(
- this.user_id,
- this.password,
- err => {
- this.bcrypt.genSalt.called.should.equal(false)
- this.bcrypt.hash.called.should.equal(false)
- return done()
- }
- )
- })
- })
- describe('successful password set attempt', function() {
- beforeEach(function() {
- this.UserGetter.getUser = sinon.stub().yields(null, { overleaf: null })
- this.AuthenticationManager.setUserPassword(
- this.user_id,
- this.password,
- this.callback
- )
- })
- it("should update the user's password in the database", function() {
- const { args } = this.db.users.update.lastCall
- expect(args[0]).to.deep.equal({
- _id: ObjectId(this.user_id.toString())
- })
- return expect(args[1]).to.deep.equal({
- $set: {
- hashedPassword: this.hashedPassword
- },
- $unset: {
- password: true
- }
- })
- })
- it('should hash the password', function() {
- this.bcrypt.genSalt.calledWith(12).should.equal(true)
- return this.bcrypt.hash
- .calledWith(this.password, this.salt)
- .should.equal(true)
- })
- it('should call the callback', function() {
- return this.callback.called.should.equal(true)
- })
- })
- })
- })
|