| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621 |
- const SandboxedModule = require('sandboxed-module')
- const sinon = require('sinon')
- const { expect } = require('chai')
- const { ObjectId } = require('mongodb')
- const MockRequest = require('../helpers/MockRequest')
- const MockResponse = require('../helpers/MockResponse')
- const PrivilegeLevels = require('../../../../app/src/Features/Authorization/PrivilegeLevels')
- const MODULE_PATH =
- '../../../../app/src/Features/TokenAccess/TokenAccessController'
- describe('TokenAccessController', function () {
- beforeEach(function () {
- this.token = 'abc123'
- this.user = { _id: new ObjectId() }
- this.project = {
- _id: new ObjectId(),
- tokenAccessReadAndWrite_refs: [],
- tokenAccessReadOnly_refs: [],
- }
- this.req = new MockRequest()
- this.res = new MockResponse()
- this.Settings = {}
- this.TokenAccessHandler = {
- TOKEN_TYPES: {
- READ_ONLY: 'readOnly',
- READ_AND_WRITE: 'readAndWrite',
- },
- isReadAndWriteToken: sinon.stub().returns(true),
- isReadOnlyToken: sinon.stub().returns(true),
- tokenAccessEnabledForProject: sinon.stub().returns(true),
- checkTokenHashPrefix: sinon.stub(),
- makeTokenUrl: sinon.stub().returns('/'),
- grantSessionTokenAccess: sinon.stub(),
- promises: {
- addReadAndWriteUserToProject: sinon.stub().resolves(),
- addReadOnlyUserToProject: sinon.stub().resolves(),
- getProjectByToken: sinon.stub().resolves(this.project),
- getV1DocPublishedInfo: sinon.stub().resolves({ allow: true }),
- getV1DocInfo: sinon.stub(),
- },
- }
- this.SessionManager = {
- getLoggedInUserId: sinon.stub().returns(this.user._id),
- }
- this.AuthenticationController = {
- setRedirectInSession: sinon.stub(),
- }
- this.AuthorizationManager = {
- promises: {
- getPrivilegeLevelForProject: sinon
- .stub()
- .resolves(PrivilegeLevels.NONE),
- },
- }
- this.AuthorizationMiddleware = {}
- this.ProjectAuditLogHandler = {
- promises: {
- addEntry: sinon.stub().resolves(),
- },
- }
- this.TokenAccessController = SandboxedModule.require(MODULE_PATH, {
- requires: {
- '@overleaf/settings': this.Settings,
- './TokenAccessHandler': this.TokenAccessHandler,
- '../Authentication/AuthenticationController':
- this.AuthenticationController,
- '../Authentication/SessionManager': this.SessionManager,
- '../Authorization/AuthorizationManager': this.AuthorizationManager,
- '../Authorization/AuthorizationMiddleware':
- this.AuthorizationMiddleware,
- '../Project/ProjectAuditLogHandler': this.ProjectAuditLogHandler,
- '../Errors/Errors': (this.Errors = { NotFoundError: sinon.stub() }),
- },
- })
- })
- describe('grantTokenAccessReadAndWrite', function () {
- describe('normal case', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('grants read and write access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadAndWriteUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'join-via-token',
- this.user._id,
- this.req.ip,
- { privileges: 'readAndWrite' }
- )
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when the access was already granted', function () {
- beforeEach(function (done) {
- this.project.tokenAccessReadAndWrite_refs.push(this.user._id)
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it("doesn't write a project audit log", function () {
- expect(this.ProjectAuditLogHandler.promises.addEntry).to.not.have.been
- .called
- })
- it('checks token hash', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('hash prefix missing in request', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('grants read and write access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadAndWriteUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('checks the hash prefix', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('user is owner of project', function () {
- beforeEach(function (done) {
- this.AuthorizationManager.promises.getPrivilegeLevelForProject.returns(
- PrivilegeLevels.OWNER
- )
- this.req.params = { token: this.token }
- this.req.body = {}
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('checks token hash and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readAndWrite',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'user already has higher or same privilege',
- }
- )
- })
- })
- describe('when user is not logged in', function () {
- beforeEach(function () {
- this.SessionManager.getLoggedInUserId.returns(null)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- })
- describe('ANONYMOUS_READ_AND_WRITE_ENABLED is undefined', function () {
- beforeEach(function (done) {
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to restricted', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: '/restricted',
- anonWriteAccessDenied: true,
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- null,
- {
- action: 'denied anonymous read-and-write token access',
- }
- )
- })
- it('saves redirect URL with URL fragment', function () {
- expect(
- this.AuthenticationController.setRedirectInSession.lastCall.args[1]
- ).to.equal('/#prefix')
- })
- })
- describe('ANONYMOUS_READ_AND_WRITE_ENABLED is true', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.ANONYMOUS_READ_AND_WRITE_ENABLED = true
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('redirects to project', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: `/project/${this.project._id}`,
- grantAnonymousAccess: 'readAndWrite',
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- null,
- {
- projectId: this.project._id,
- action: 'granting read-write anonymous access',
- }
- )
- })
- })
- })
- describe('when Overleaf SaaS', function () {
- beforeEach(function () {
- this.Settings.overleaf = {}
- })
- describe('when token is for v1 project', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.TokenAccessHandler.promises.getV1DocInfo.resolves({
- exists: true,
- has_owner: true,
- })
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('returns v1 import data', function () {
- expect(this.res.json).to.have.been.calledWith({
- v1Import: {
- status: 'canDownloadZip',
- projectId: this.token,
- hasOwner: true,
- name: 'Untitled',
- brandInfo: undefined,
- },
- })
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: 'import v1',
- }
- )
- })
- })
- describe('when token is not for a v1 or v2 project', function () {
- beforeEach(function (done) {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.TokenAccessHandler.promises.getV1DocInfo.resolves({
- exists: false,
- })
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- done
- )
- })
- it('returns 404', function () {
- expect(this.res.sendStatus).to.have.been.calledWith(404)
- })
- it('checks the hash prefix and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: '404',
- }
- )
- })
- })
- })
- describe('not Overleaf SaaS', function () {
- beforeEach(function () {
- this.TokenAccessHandler.promises.getProjectByToken.resolves(undefined)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- })
- it('passes Errors.NotFoundError to next when project not found and still checks token hash', function (done) {
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- action: '404',
- }
- )
- done()
- }
- )
- })
- })
- it('passes Errors.NotFoundError to next when token access is not enabled but still checks token hash', function (done) {
- this.TokenAccessHandler.tokenAccessEnabledForProject.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readAndWrite',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'token access not enabled',
- }
- )
- done()
- }
- )
- })
- it('returns 400 when not using a read write token', function () {
- this.TokenAccessHandler.isReadAndWriteToken.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadAndWrite(
- this.req,
- this.res
- )
- expect(this.res.sendStatus).to.have.been.calledWith(400)
- })
- })
- describe('grantTokenAccessReadOnly', function () {
- describe('normal case', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true, tokenHashPrefix: '#prefix' }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('grants read-only access', function () {
- expect(
- this.TokenAccessHandler.promises.addReadOnlyUserToProject
- ).to.have.been.calledWith(this.user._id, this.project._id)
- })
- it('writes a project audit log', function () {
- expect(
- this.ProjectAuditLogHandler.promises.addEntry
- ).to.have.been.calledWith(
- this.project._id,
- 'join-via-token',
- this.user._id,
- this.req.ip,
- { privileges: 'readOnly' }
- )
- })
- it('checks if hash prefix matches', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readOnly',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- describe('when the access was already granted', function () {
- beforeEach(function (done) {
- this.project.tokenAccessReadOnly_refs.push(this.user._id)
- this.req.params = { token: this.token }
- this.req.body = { confirmedByUser: true }
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it("doesn't write a project audit log", function () {
- expect(this.ProjectAuditLogHandler.promises.addEntry).to.not.have.been
- .called
- })
- it('still checks if hash prefix matches', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readOnly',
- this.user._id,
- { projectId: this.project._id, action: 'continue' }
- )
- })
- })
- it('returns 400 when not using a read only token', function () {
- this.TokenAccessHandler.isReadOnlyToken.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadOnly(this.req, this.res)
- expect(this.res.sendStatus).to.have.been.calledWith(400)
- })
- describe('anonymous users', function () {
- beforeEach(function (done) {
- this.req.params = { token: this.token }
- this.SessionManager.getLoggedInUserId.returns(null)
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('allows anonymous users and checks the token hash', function () {
- expect(this.res.json).to.have.been.calledWith({
- redirect: `/project/${this.project._id}`,
- grantAnonymousAccess: 'readOnly',
- })
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(this.token, undefined, 'readOnly', null, {
- projectId: this.project._id,
- action: 'granting read-only anonymous access',
- })
- })
- })
- describe('user is owner of project', function () {
- beforeEach(function (done) {
- this.AuthorizationManager.promises.getPrivilegeLevelForProject.returns(
- PrivilegeLevels.OWNER
- )
- this.req.params = { token: this.token }
- this.req.body = {}
- this.res.callback = done
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- done
- )
- })
- it('checks token hash and includes log data', function () {
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- undefined,
- 'readOnly',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'user already has higher or same privilege',
- }
- )
- })
- })
- it('passes Errors.NotFoundError to next when token access is not enabled but still checks token hash', function (done) {
- this.TokenAccessHandler.tokenAccessEnabledForProject.returns(false)
- this.req.params = { token: this.token }
- this.req.body = { tokenHashPrefix: '#prefix' }
- this.TokenAccessController.grantTokenAccessReadOnly(
- this.req,
- this.res,
- args => {
- expect(args).to.be.instanceof(this.Errors.NotFoundError)
- expect(
- this.TokenAccessHandler.checkTokenHashPrefix
- ).to.have.been.calledWith(
- this.token,
- '#prefix',
- 'readOnly',
- this.user._id,
- {
- projectId: this.project._id,
- action: 'token access not enabled',
- }
- )
- done()
- }
- )
- })
- })
- })
|