Merge pull request #2512 from overleaf/jel-plans-scroll-event

Fix throttle used for scroll event

GitOrigin-RevId: fd453a74fca823391c3ca962f076a89f778f9f28

services/web/frontend/js/directives/eventTracking.js

@@ -84,18 +84,18 @@ define(['base'], App =>
             timer = setTimeout(() => sendEvent(), timeoutAmt)
           })
           .on('mouseleave', () => clearTimeout(timer))
-      } else if (attrs.eventTrackingTrigger === 'scroll') {
-        if (!eventTracking.eventInCache(scope.eventTracking)) {
-          return $(window).on('resize scroll', () =>
-            _.throttle(
-              isInViewport(element) &&
-              !eventTracking.eventInCache(scope.eventTracking)
-                ? sendEvent(true)
-                : undefined,
-              500
-            )
-          )
-        }
+      } else if (
+        attrs.eventTrackingTrigger === 'scroll' &&
+        !eventTracking.eventInCache(scope.eventTracking)
+      ) {
+        $(window).on(
+          'resize scroll',
+          _.throttle(() => {
+            if (isInViewport(element)) {
+              sendEvent(true)
+            }
+          }, 500)
+        )
       }
     }
   })))