Răsfoiți Sursa

Merge pull request #22016 from overleaf/jpa-fix-flaky-test

[history-v1] back_fill_file_hash: fix typo in tests and add comments

GitOrigin-RevId: a4055d7dd33ba584a2a86053470585f412392305
Jakob Ackermann 1 an în urmă
părinte
comite
1fca37af61

+ 5 - 2
services/history-v1/test/acceptance/js/storage/back_fill_file_hash.test.mjs

@@ -1020,8 +1020,11 @@ describe('back_fill_file_hash script', function () {
       filesRetries: 0,
       readFromGCSCount: 0,
     })
-    expect(stats.filesRetries).to.be.greaterThan(0)
-    expect(stats.filesRetries).to.be.greaterThan(STATS_ALL.readFromGCSCount)
+    expect(stats.filesRetries).to.be.greaterThan(0, 'should have retried')
+    expect(stats.readFromGCSCount).to.be.greaterThan(
+      STATS_ALL.readFromGCSCount,
+      'should have read more times from GCS compared to normal operations'
+    )
   })
 
   describe('full run CONCURRENCY=1', function () {