Просмотр исходного кода

Merge pull request #8199 from overleaf/ii-settings-ts-fixes

[web] Fix TS errors in settings area

GitOrigin-RevId: 48f3695570bd794b4865bd45a29aa6fc9bf57502
Timothée Alby 4 лет назад
Родитель
Сommit
20d5291308

+ 2 - 1
services/web/frontend/js/features/settings/components/emails/add-email.tsx

@@ -120,7 +120,8 @@ function AddEmail() {
             />
           </Cell>
         </Col>
-        {ssoAvailableForDomain(newEmailMatchedDomain) ? (
+        {newEmailMatchedDomain &&
+        ssoAvailableForDomain(newEmailMatchedDomain) ? (
           <Col md={8}>
             <Cell>
               <SsoLinkingInfo

+ 11 - 5
services/web/frontend/js/features/settings/components/emails/add-email/input.tsx

@@ -125,11 +125,17 @@ function Input({ onChange, handleAddNewEmail }: InputProps) {
 
         if (suggestion) {
           setInputValueAndResetSuggestion()
-        } else {
-          const match = matchLocalAndDomain(inputValue)
-          if (match.local && match.domain) {
-            handleAddNewEmail()
-          }
+
+          return
+        }
+
+        if (!inputValue) {
+          return
+        }
+
+        const match = matchLocalAndDomain(inputValue)
+        if (match.local && match.domain) {
+          handleAddNewEmail()
         }
       }
 

+ 1 - 1
services/web/frontend/js/features/settings/components/emails/email.tsx

@@ -11,7 +11,7 @@ function Email({ userEmailData }: EmailProps) {
   const { t } = useTranslation()
 
   const ssoAvailable = ssoAvailableForInstitution(
-    userEmailData.affiliation?.institution
+    userEmailData.affiliation?.institution || null
   )
 
   return (